Fix invalid syntax in test code

This commit is contained in:
Jeroen Engels 2024-09-08 18:40:23 +02:00
parent 5a82e53388
commit 9b2b19d2cb
4 changed files with 51 additions and 20 deletions

View File

@ -1361,6 +1361,7 @@ tests : Test
tests = Test.describe "thing" B.helper tests = Test.describe "thing" B.helper
""", """ """, """
module B exposing (helper) module B exposing (helper)
{-| Module docs -}
{-| @ignore-helper -} {-| @ignore-helper -}
helper = 1 helper = 1
""" ] """ ]

View File

@ -156,6 +156,7 @@ b = 2"""
, test "should report unused top-level variables with documentation attached" <| , test "should report unused top-level variables with documentation attached" <|
\() -> \() ->
"""module SomeModule exposing (b) """module SomeModule exposing (b)
{-| Module docs -}
{-| Documentation {-| Documentation
-} -}
unusedVar = 1 unusedVar = 1
@ -168,11 +169,13 @@ b = 2"""
, under = "unusedVar" , under = "unusedVar"
} }
|> Review.Test.whenFixed """module SomeModule exposing (b) |> Review.Test.whenFixed """module SomeModule exposing (b)
{-| Module docs -}
b = 2""" b = 2"""
] ]
, test "should report unused top-level variables with documentation attached even if they are annotated" <| , test "should report unused top-level variables with documentation attached even if they are annotated" <|
\() -> \() ->
"""module SomeModule exposing (b) """module SomeModule exposing (b)
{-| Module docs -}
{-| Documentation {-| Documentation
-} -}
unusedVar : Int unusedVar : Int
@ -185,8 +188,9 @@ b = 2"""
, details = details , details = details
, under = "unusedVar" , under = "unusedVar"
} }
|> Review.Test.atExactly { start = { row = 5, column = 1 }, end = { row = 5, column = 10 } } |> Review.Test.atExactly { start = { row = 6, column = 1 }, end = { row = 6, column = 10 } }
|> Review.Test.whenFixed """module SomeModule exposing (b) |> Review.Test.whenFixed """module SomeModule exposing (b)
{-| Module docs -}
b = 2""" b = 2"""
] ]
, test "should not report unused top-level variables if everything is exposed (functions)" <| , test "should not report unused top-level variables if everything is exposed (functions)" <|
@ -642,7 +646,7 @@ topLevelVariablesUsedInLetInTests =
"""module SomeModule exposing (a) """module SomeModule exposing (a)
b = 1 b = 1
a = let c = 1 a = let c = 1
in b + c""" in b + c"""
|> Review.Test.run rule |> Review.Test.run rule
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should not report top-level variables used inside let declarations" <| , test "should not report top-level variables used inside let declarations" <|
@ -650,21 +654,25 @@ in b + c"""
"""module SomeModule exposing (a) """module SomeModule exposing (a)
b = 1 b = 1
a = let c = b a = let c = b
in c""" in c
"""
|> Review.Test.run rule |> Review.Test.run rule
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
, test "should not report top-level variables used in nested lets" <| , test "should not report top-level variables used in nested lets" <|
\() -> \() ->
"""module SomeModule exposing (a) """module SomeModule exposing (a)
b = 1 b = 1
a = let a =
c = b let
d = let c = b
e = 1 d =
in let
b + c + e e = 1
in in
d""" b + c + e
in
d
"""
|> Review.Test.run rule |> Review.Test.run rule
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors
] ]
@ -2016,6 +2024,7 @@ a = 1"""
, test "should report unused custom type declarations with documentation" <| , test "should report unused custom type declarations with documentation" <|
\() -> \() ->
"""module SomeModule exposing (a) """module SomeModule exposing (a)
{-| Module docs -}
{-| Documentation -} {-| Documentation -}
type UnusedType = B | C type UnusedType = B | C
a = 1""" a = 1"""
@ -2027,6 +2036,7 @@ a = 1"""
, under = "UnusedType" , under = "UnusedType"
} }
|> Review.Test.whenFixed """module SomeModule exposing (a) |> Review.Test.whenFixed """module SomeModule exposing (a)
{-| Module docs -}
a = 1""" a = 1"""
] ]
, test "should report unused custom type declaration even when it references itself" <| , test "should report unused custom type declaration even when it references itself" <|
@ -2089,6 +2099,7 @@ a = 1"""
, test "should report unused type aliases declarations with documentation" <| , test "should report unused type aliases declarations with documentation" <|
\() -> \() ->
"""module SomeModule exposing (a) """module SomeModule exposing (a)
{-| Module docs -}
{-| Documentation -} {-| Documentation -}
type alias UnusedType = { a : B } type alias UnusedType = { a : B }
a = 1""" a = 1"""
@ -2100,6 +2111,7 @@ a = 1"""
, under = "UnusedType" , under = "UnusedType"
} }
|> Review.Test.whenFixed """module SomeModule exposing (a) |> Review.Test.whenFixed """module SomeModule exposing (a)
{-| Module docs -}
a = 1""" a = 1"""
] ]
, test "should not report type alias used in a signature" <| , test "should not report type alias used in a signature" <|

View File

@ -143,7 +143,7 @@ Hint: Maybe you forgot to add the module definition at the top, like:
, test "when there are multiple files" <| , test "when there are multiple files" <|
\() -> \() ->
[ "module MyModule exposing (.." [ "module MyModule exposing (.."
, "module MyOtherModule exposing (..)" , "module MyOtherModule exposing (..)\na = 1"
] ]
|> Review.Test.runOnModules testRuleReportsLiterals |> Review.Test.runOnModules testRuleReportsLiterals
|> Review.Test.expectNoErrors |> Review.Test.expectNoErrors

View File

@ -274,10 +274,19 @@ shiftRange : ( ESN.Node String, Int ) -> { node : ESN.Node String } -> { a | nod
shiftRange input _ _ = shiftRange input _ _ =
let let
asList : ( ESN.Node, Int ) -> List ESN.Node asList : ( ESN.Node, Int ) -> List ESN.Node
asList ( node, _ ) = [ node ] asList ( node, _ ) =
( ESN.Node range1 value1, length1 ) = input [ node ]
[ ESN.Node range2 value2 ] = asList input
ESN.Node range3 value3 :: [] = asList input ( ESN.Node range value, length1 ) =
case asList input of
[ ESN.Node range2 value2 ] ->
input
ESN.Node range3 value3 :: _ ->
input
_ ->
input
in in
range range
""" """
@ -298,10 +307,19 @@ shiftRange : ( Node.Node String, Int ) -> { node : Node.Node String } -> { a | n
shiftRange input _ _ = shiftRange input _ _ =
let let
asList : ( Node.Node, Int ) -> List Node.Node asList : ( Node.Node, Int ) -> List Node.Node
asList ( node, _ ) = [ node ] asList ( node, _ ) =
( Node.Node range1 value1, length1 ) = input [ node ]
[ Node.Node range2 value2 ] = asList input
Node.Node range3 value3 :: [] = asList input ( Node.Node range value, length1 ) =
case asList input of
[ Node.Node range2 value2 ] ->
input
Node.Node range3 value3 :: _ ->
input
_ ->
input
in in
range range
""" """