jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Re-use cache for scope rule

Browse Source
This commit is contained in:
Jeroen Engels 2020-08-26 16:59:30 +02:00
parent 21fa8c9520
commit 9d500b25f2
1 changed files with 29 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/Review/Rule.elm
View File

@ -417,7 +417,12 @@ review rules project =
Ok nodeContexts ->
let
scopeResult : { errors : List (Error {}), rule : Rule, extract : Maybe Extract }
scopeResult :
{ errors : List (Error {})
, rule : Rule
, cache : ProjectRuleCache ScopeProjectContext
, extract : Maybe Extract
}
scopeResult =
runProjectVisitor
"DUMMY"
@ -529,12 +534,26 @@ reviewWithPrecollectionOfData rules maybeProjectData project =
Ok nodeContexts ->
let
scopeResult : { errors : List (Error {}), rule : Rule, extract : Maybe Extract }
scopeCache : Maybe (ProjectRuleCache ScopeProjectContext)
scopeCache =
case maybeProjectData of
Just (ProjectData data) ->
Just data
Nothing ->
Nothing
scopeResult :
{ errors : List (Error {})
, rule : Rule
, cache : ProjectRuleCache ScopeProjectContext
, extract : Maybe Extract
}
scopeResult =
runProjectVisitor
"DUMMY"
scopeRule
Nothing
scopeCache
Exceptions.init
project
nodeContexts
@ -554,7 +573,7 @@ reviewWithPrecollectionOfData rules maybeProjectData project =
if not (List.isEmpty scopeResult.errors) then
{ errors = List.map errorToReviewError scopeResult.errors
, rules = rules
, projectData = Just ProjectData
, projectData = Just (ProjectData scopeResult.cache)
}
else
@ -564,7 +583,7 @@ reviewWithPrecollectionOfData rules maybeProjectData project =
in
{ errors = List.map errorToReviewError errors
, rules = newRules
, projectData = Just ProjectData
, projectData = Just (ProjectData scopeResult.cache)
}
modulesThatFailedToParse ->
@ -575,7 +594,7 @@ reviewWithPrecollectionOfData rules maybeProjectData project =
type ProjectData
= ProjectData
= ProjectData (ProjectRuleCache ScopeProjectContext)
duplicateModulesGlobalError : { moduleName : ModuleName, paths : List String } -> ReviewError
@ -995,7 +1014,7 @@ fromProjectRuleSchema ((ProjectRuleSchema schema) as projectRuleSchema) =
, ruleImplementation =
\exceptions project nodeContexts ->
let
result : { errors : List (Error {}), rule : Rule, extract : Maybe Extract }
result : { errors : List (Error {}), rule : Rule, cache : ProjectRuleCache projectContext, extract : Maybe Extract }
result =
runProjectVisitor schema.name
(fromProjectRuleSchemaToRunnableProjectVisitor projectRuleSchema)
@ -3234,7 +3253,7 @@ runProjectVisitor :
-> Exceptions
-> Project
-> List (Graph.NodeContext ModuleName ())
-> { errors : List (Error {}), rule : Rule, extract : Maybe Extract }
-> { errors : List (Error {}), rule : Rule, cache : ProjectRuleCache projectContext, extract : Maybe Extract }
runProjectVisitor name projectVisitor maybePreviousCache exceptions project nodeContexts =
let
cacheWithInitialContext : ProjectRuleCache projectContext
@ -3326,7 +3345,7 @@ runProjectVisitor name projectVisitor maybePreviousCache exceptions project node
, ruleImplementation =
\newExceptions newProject newNodeContexts ->
let
result : { errors : List (Error {}), rule : Rule, extract : Maybe Extract }
result : { errors : List (Error {}), rule : Rule, cache : ProjectRuleCache projectContext, extract : Maybe Extract }
result =
runProjectVisitor
name
@ -3338,6 +3357,7 @@ runProjectVisitor name projectVisitor maybePreviousCache exceptions project node
in
( result.errors, result.rule )
}
, cache = newCache
, extract =
case
projectVisitor.dataExtractor