jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-13 06:28:43 +03:00
Code Issues Packages Projects Releases Wiki Activity

Simplify runReview

Browse Source
This commit is contained in:
Jeroen Engels 2020-08-30 09:09:33 +02:00
parent 5fd2e0847f
commit 9ecef7b8c3
1 changed files with 10 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/Review/Rule.elm
View File

@ -563,17 +563,8 @@ extractResultValue result =
runReview : Project -> List Rule -> Maybe ProjectData -> List (Graph.NodeContext ModuleName ()) -> { errors : List ReviewError, rules : List Rule, projectData : Maybe ProjectData }
runReview project rules maybeProjectData nodeContexts =
runReview ((Project p) as project) rules maybeProjectData nodeContexts =
let
scopeCache : Maybe (ProjectRuleCache ScopeProjectContext)
scopeCache =
case maybeProjectData of
Just (ProjectData data) ->
Just data
Nothing ->
Nothing
scopeResult : { projectData : Maybe ProjectData, extract : Maybe Extract }
scopeResult =
if needsToComputeScope rules then
@ -582,7 +573,7 @@ runReview project rules maybeProjectData nodeContexts =
runProjectVisitor
"DUMMY"
scopeRule
scopeCache
(Maybe.map extractProjectData maybeProjectData)
Exceptions.init
project
nodeContexts
@ -600,17 +591,13 @@ runReview project rules maybeProjectData nodeContexts =
moduleNameLookupTables =
Maybe.map (\(Extract moduleNameLookupTables_) -> moduleNameLookupTables_) scopeResult.extract
projectWithLookupTable : Project
projectWithLookupTable =
let
(Project p) =
project
in
projectWithLookupTables : Project
projectWithLookupTables =
Project { p | moduleNameLookupTables = moduleNameLookupTables }
in
let
( errors, newRules ) =
runRules rules projectWithLookupTable nodeContexts
runRules rules projectWithLookupTables nodeContexts
in
{ errors = List.map errorToReviewError errors
, rules = newRules
@ -622,6 +609,11 @@ type ProjectData
= ProjectData (ProjectRuleCache ScopeProjectContext)
extractProjectData : ProjectData -> ProjectRuleCache ScopeProjectContext
extractProjectData (ProjectData data) =
data
needsToComputeScope : List Rule -> Bool
needsToComputeScope rules =
List.any