jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-20 04:27:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fail test if a global error is missing

Browse Source
This commit is contained in:
Jeroen Engels 2021-03-03 20:29:44 +01:00
parent 47f21ecab8
commit 9ff74101e1
1 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
src/Review/Test.elm
View File

@ -402,21 +402,16 @@ moduleToRunResult errors projectModule =
globalErrorsRunResult : List ReviewError -> List SuccessfulRunResult
globalErrorsRunResult errors =
case List.filter (\error_ -> Rule.errorTarget error_ == Error.UserGlobal) errors of
[] ->
[]
globalErrors_ ->
[ { moduleName = "GLOBAL ERROR"
, inspector =
{ isModule = False
, source = ""
, getCodeAtLocation = always Nothing
, checkIfLocationIsAmbiguous = \_ _ -> Expect.pass
}
, errors = globalErrors_
}
]
[ { moduleName = "GLOBAL ERROR"
, inspector =
{ isModule = False
, source = ""
, getCodeAtLocation = always Nothing
, checkIfLocationIsAmbiguous = \_ _ -> Expect.pass
}
, errors = List.filter (\error_ -> Rule.errorTarget error_ == Error.UserGlobal) errors
}
]
elmJsonRunResult : List ReviewError -> Project -> List SuccessfulRunResult
@ -689,7 +684,7 @@ expectErrorsForModules expectedErrorsList reviewResult =
maybeUnknownModule =
Set.diff
(expectedErrorsList |> List.map Tuple.first |> Set.fromList)
(Set.fromList ("GLOBAL ERROR" :: List.map .moduleName runResults))
(Set.fromList (List.map .moduleName runResults))
|> Set.toList
|> List.head
in
@ -699,18 +694,23 @@ expectErrorsForModules expectedErrorsList reviewResult =
|> Expect.fail
Nothing ->
runResults
|> List.map
(\runResult () ->
expectedErrorsList
|> ListExtra.find (\( moduleName, _ ) -> moduleName == runResult.moduleName)
|> Maybe.map Tuple.second
|> Maybe.withDefault []
|> checkAllErrorsMatch runResult
)
expectErrorsForModuleFiles expectedErrorsList runResults
|> (\expectations -> Expect.all expectations ())
expectErrorsForModuleFiles : List ( String, List ExpectedError ) -> List SuccessfulRunResult -> List (() -> Expectation)
expectErrorsForModuleFiles expectedErrorsList runResults =
List.map
(\runResult () ->
expectedErrorsList
|> ListExtra.find (\( moduleName, _ ) -> moduleName == runResult.moduleName)
|> Maybe.map Tuple.second
|> Maybe.withDefault []
|> checkAllErrorsMatch runResult
)
runResults
{-| Assert that the rule reported some errors for the `elm.json` file, by specifying which ones.
test "report an error when a module is unused" <|