From a26dd4138249e91c7ebd630738e837ad15373840 Mon Sep 17 00:00:00 2001 From: Jeroen Engels Date: Tue, 6 Apr 2021 17:32:30 +0200 Subject: [PATCH] Backport rules from elm-review-common --- tests/NoExposingEverything.elm | 2 +- tests/NoExposingEverythingTest.elm | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/NoExposingEverything.elm b/tests/NoExposingEverything.elm index 65cdaee9..2da227e4 100644 --- a/tests/NoExposingEverything.elm +++ b/tests/NoExposingEverything.elm @@ -84,7 +84,7 @@ declarationListVisitor declarations context = ( [ Rule.errorWithFix { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] } { start = { row = range.start.row, column = range.start.column - 1 } diff --git a/tests/NoExposingEverythingTest.elm b/tests/NoExposingEverythingTest.elm index a91c3682..97156d47 100644 --- a/tests/NoExposingEverythingTest.elm +++ b/tests/NoExposingEverythingTest.elm @@ -29,7 +29,7 @@ bar = 2 [ Review.Test.error { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] , under = "(..)" } @@ -51,7 +51,7 @@ type Foo = Foo [ Review.Test.error { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] , under = "(..)" } @@ -72,7 +72,7 @@ type alias Foo = String [ Review.Test.error { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] , under = "(..)" } @@ -93,7 +93,7 @@ port foo : String [ Review.Test.error { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] , under = "(..)" } @@ -118,7 +118,7 @@ cons = [ Review.Test.error { message = "Module exposes everything implicitly \"(..)\"" , details = - [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access it's internal details. Therefore, the API should be explicitly defined and ideally as small as possible." + [ "Modules should have hidden implementation details with an explicit API so that the module is used in a proper and controlled way. The users of this module should not have to know about what is inside a module it is using, and they shouldn't need to access its internal details. Therefore, the API should be explicitly defined and ideally as small as possible." ] , under = "(..)" }