jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

NoUnusedVariables: Do not report variables modified in a record update expression

Browse Source
This commit is contained in:
Jeroen Engels 2019-07-02 11:16:03 +02:00
parent 003336a735
commit b1b2a31e48
2 changed files with 30 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Lint/Rule/NoUnusedVariables.elm
View File

@ -250,6 +250,9 @@ expressionVisitor node direction context =
in
( [], newContext )
( Rule.OnExit, RecordUpdateExpression expr _ ) ->
( [], markAsUsed (Node.value expr) context )
( Rule.OnExit, LetExpression _ ) ->
let
( errors, remainingUsed ) =

27
tests/NoUnusedVariablesTest.elm
View File

@ -165,6 +165,33 @@ a = let
in
d"""
|> Lint.Test.expectNoErrors
, test "should not report variables used in a record update expression's value to be updated" <|
\() ->
testRule """module A exposing (a)
b = { c = 1 }
a = { b | c = 3 }"""
|> Lint.Test.expectNoErrors
, test "should not report variables used in a record update expression's updates" <|
\() ->
testRule """module A exposing (a)
b = { y = 1, z = 1 }
d = 3
e = 3
a = { b | y = d, z = e }"""
|> Lint.Test.expectNoErrors
, test "should report variables even if they appear as keys of a record update expression's updates" <|
\() ->
testRule """module A exposing (a)
b = { z = 1, c = 2 }
c = 1
a = { b | c = 3 }"""
|> Lint.Test.expectErrors
[ Lint.Test.error
{ message = "Variable `c` is not used"
, under = "c"
}
|> Lint.Test.atExactly { start = { row = 3, column = 1 }, end = { row = 3, column = 2 } }
]
, test "should not report variables from let declarations that are used in the expression" <|
\() ->
testRule """module A exposing (a)