jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-12-25 10:41:47 +03:00
Code Issues Packages Projects Releases Wiki Activity

Make graph creation a bit more performant

Browse Source
This commit is contained in:
Jeroen Engels 2020-01-15 15:53:35 +01:00
parent d7d49501e1
commit c4fbda59c4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Review/Project.elm
View File

@ -299,8 +299,8 @@ nodesAndEdges getFileId module_ fileId =
, importedModules module_
|> List.filterMap getFileId
|> List.map
(\importFileId ->
Graph.Edge fileId importFileId ()
(\importedFileId ->
Graph.Edge importedFileId fileId ()
)
)

8
src/Review/Rule.elm
View File

@ -809,8 +809,8 @@ importedModulesFirst (MultiSchema schema) startCache project =
newCache : MultiRuleCache globalContext
newCache =
-- TODO Need to invalidate the cache if an imported module changes
List.foldr
(\{ node, outgoing } cache ->
List.foldl
(\{ node, incoming } cache ->
let
maybeModule : Maybe ParsedFile
maybeModule =
@ -823,7 +823,7 @@ importedModulesFirst (MultiSchema schema) startCache project =
Just module_ ->
case Dict.get module_.path cache of
Nothing ->
Dict.insert module_.path (computeModule cache outgoing module_) cache
Dict.insert module_.path (computeModule cache incoming module_) cache
Just cacheEntry ->
if cacheEntry.source == module_.source then
@ -831,7 +831,7 @@ importedModulesFirst (MultiSchema schema) startCache project =
cache
else
Dict.insert module_.path (computeModule cache outgoing module_) cache
Dict.insert module_.path (computeModule cache incoming module_) cache
)
startCache
nodeContexts