jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-09-21 04:57:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use new test module for NoExtraBooleanComparison

Browse Source
This commit is contained in:
Jeroen Engels 2019-06-30 11:53:49 +02:00
parent 75931b0f23
commit e96b6610b2
1 changed files with 53 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
tests/NoExtraBooleanComparisonTest.elm
View File

@ -1,9 +1,7 @@
module NoExtraBooleanComparisonTest exposing (all)
import Elm.Syntax.Range exposing (Location, Range)
import Lint.Rule as Rule exposing (Error, Rule)
import Lint.Rule.NoExtraBooleanComparison exposing (rule)
import Lint.Test exposing (LintResult)
import Lint.Test2 exposing (LintResult)
import Test exposing (Test, describe, test)
@ -11,7 +9,7 @@ testRule : String -> LintResult
testRule string =
"module A exposing (..)\n\n"
++ string
|> Lint.Test.run rule
|> Lint.Test2.run rule
tests : List Test
@ -19,7 +17,7 @@ tests =
[ test "should not report condition without an operator" <|
\() ->
testRule "a = if n then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange []
|> Lint.Test2.expectNoErrors
, test "should not report condition with integer operators" <|
\() ->
testRule """
@ -28,51 +26,83 @@ b = if n <= 1 then 1 else 2
c = if n > 1 then 1 else 2
d = if n >= 1 then 1 else 2
"""
|> Lint.Test.expectErrorsWithoutRange []
|> Lint.Test2.expectNoErrors
, test "should not report condition using `not`" <|
\() ->
testRule "a = if not n then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange []
|> Lint.Test2.expectNoErrors
, test "should report condition with `expr == True`" <|
\() ->
testRule "a = if b == True then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `True`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `True`"
, under = " True "
}
]
, test "should report condition with `True == expr`" <|
\() ->
testRule "a = if True == b then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `True`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `True`"
, under = " True "
}
]
, test "should report condition with `expr == False`" <|
\() ->
testRule "a = if b == False then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `False`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `False`"
, under = " False "
}
]
, test "should report condition with `False == expr`" <|
\() ->
testRule "a = if False == b then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `False`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `False`"
, under = " False "
}
]
, test "should report condition with `expr /= True`" <|
\() ->
testRule "a = if b /= True then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `True`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `True`"
, under = " True "
}
]
, test "should report condition with `True /= expr`" <|
\() ->
testRule "a = if True /= b then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `True`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `True`"
, under = " True "
}
]
, test "should report condition with `expr /= False`" <|
\() ->
testRule "a = if b /= False then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `False`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `False`"
, under = " False "
}
]
, test "should report condition with `False /= expr`" <|
\() ->
testRule "a = if False /= b then 1 else 2"
|> Lint.Test.expectErrorsWithoutRange
[ Lint.Test.errorWithoutRange "Unnecessary comparison with `False`" ]
|> Lint.Test2.expectErrors
[ Lint.Test2.error
{ message = "Unnecessary comparison with `False`"
, under = " False "
}
]
]