jfmengels/elm-review
1
1
Fork 0
mirror of https://github.com/jfmengels/elm-review.git synced 2024-11-23 23:05:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Only compute the module visitors once

Browse Source
This commit is contained in:
Jeroen Engels 2020-03-19 00:06:58 +01:00
parent 8f83d4161f
commit f37b19d6ed
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/Review/Rule.elm
View File

@ -234,7 +234,7 @@ import Elm.Syntax.Infix as Infix
import Elm.Syntax.Module as Module exposing (Module)
import Elm.Syntax.ModuleName exposing (ModuleName)
import Elm.Syntax.Node as Node exposing (Node)
import Elm.Syntax.Range exposing (Range)
import Elm.Syntax.Range as Range exposing (Range)
import Review.Exceptions as Exceptions exposing (Exceptions)
import Review.Fix exposing (Fix)
import Review.Project exposing (Project, ProjectModule)
@ -1119,6 +1119,23 @@ runProjectRule ((ProjectRuleSchema schema) as wrappedSchema) startCache exceptio
|> List.map .path
|> Set.fromList
dummyInitialContext : moduleContext
dummyInitialContext =
schema.context.fromProjectToModule
(ModuleKey "dummy")
(Node.Node Range.emptyRange [ "Dummy" ])
initialContext
moduleVisitor : ModuleRuleSchema { hasAtLeastOneVisitor : () } moduleContext
moduleVisitor =
List.foldl
(\addVisitors (ModuleRuleSchema moduleVisitorSchema) ->
addVisitors (ModuleRuleSchema moduleVisitorSchema)
)
(emptySchema "" dummyInitialContext)
schema.moduleVisitorCreators
|> reverseVisitors
-- TODO make it so we don't compute modules at all if there are no module visitors
-- We can probably do that by setting an initial context, and then just replacing in the call to visitModuleForProjectRule
computeModule : ProjectRuleCache projectContext -> List ProjectModule -> ProjectModule -> { source : String, errors : List Error, context : projectContext }
@ -1151,17 +1168,6 @@ runProjectRule ((ProjectRuleSchema schema) as wrappedSchema) startCache exceptio
|> List.foldl schema.context.foldProjectContexts initialContext
|> schema.context.fromProjectToModule moduleKey moduleNameNode_
-- TODO Make it so that we only compute the module visitors once
moduleVisitor : ModuleRuleSchema { hasAtLeastOneVisitor : () } moduleContext
moduleVisitor =
List.foldl
(\addVisitors (ModuleRuleSchema moduleVisitorSchema) ->
addVisitors (ModuleRuleSchema moduleVisitorSchema)
)
(emptySchema "" initialModuleContext)
schema.moduleVisitorCreators
|> reverseVisitors
( fileErrors, context ) =
visitModuleForProjectRule
moduleVisitor