Commit Graph

295 Commits

Author SHA1 Message Date
Jeroen Engels
50b0c6ad23 Copy the Reporter from the CLI 2019-07-30 21:01:38 +02:00
Jeroen Engels
a67321e0a0 Turn Lint.LintError into an opaque type
This will help make the type extensible later on without breaking 
changes
2019-07-29 23:56:23 +02:00
Jeroen Engels
daf16f11d5 Make the colors of the reporter by the same as the compiler's 2019-07-29 19:44:48 +02:00
Jeroen Engels
a845cbd86d Make lintSource always return a list, not a result 2019-07-28 21:16:01 +02:00
Jeroen Engels
e1146c634f Reword parts of the README 2019-07-28 19:36:12 +02:00
Jeroen Engels
58e4ef5954 Remove the FAQ and move out some questions 2019-07-28 19:30:34 +02:00
Jeroen Engels
6763340cb8 Add section on when to write or enable a rule 2019-07-28 19:20:23 +02:00
Jeroen Engels
faf7ca3efc Enforce that docs are valid when running tests 2019-07-28 17:43:56 +02:00
Jeroen Engels
00215346ca Fix a bunch of typos about "it's" 2019-07-28 17:37:21 +02:00
Jeroen Engels
cff014d5ad Show the linting errors in the example like we do in the terminal 2019-07-28 17:37:21 +02:00
Jeroen Engels
2274505ebc Rewrite the part about messages in "what makes a good rule" 2019-07-28 17:37:21 +02:00
Jeroen Engels
061fca8274 Check that the details are correct 2019-07-28 10:27:46 +02:00
Jeroen Engels
e27ea65b1a Add details in tests 2019-07-28 10:27:46 +02:00
Jeroen Engels
68b3b72f8d Update calls to Rule.error in documentation 2019-07-28 10:27:46 +02:00
Jeroen Engels
d593bae052 Add details to the message of every rule
This will make it easier to have helpful explanations and suggestions
like the Elm compiler does
2019-07-28 10:27:46 +02:00
Jeroen Engels
ad8fccb116 NoDebug rule: tell when (not) to use this rule 2019-07-28 10:27:46 +02:00
Jeroen Engels
18a8514073 Show an example with Debug.todo rather than Debug.crash in NoDebug
Debug.crash has been removed in 0.19, and replaced by Debug.todo
2019-07-28 10:27:46 +02:00
Jeroen Engels
174faec216 Write what makes a rule good 2019-07-28 10:27:46 +02:00
Jeroen Engels
f4cd561c20 Tiny documentation changes 2019-07-28 10:27:46 +02:00
Jeroen Engels
a993a0e01e Run elm make in tests 2019-07-26 11:01:21 +02:00
Jeroen Engels
a70013ca24 Remove the concept of Severity 2019-07-25 14:37:10 +02:00
Jeroen Engels
e569ea4d5d Add new motivation for writing a rule 2019-07-25 12:49:16 +02:00
Jeroen Engels
1cec4abc7f Rename module name in tests cases
Since the module name and the type were often the same, this should help 
remove some potential confusion
2019-07-25 11:16:54 +02:00
Jeroen Engels
45a10ebb3a Report unused import aliases that are named like a type 2019-07-25 10:40:23 +02:00
Jeroen Engels
527ee1c43a Report unused import aliases 2019-07-25 09:14:33 +02:00
Jeroen Engels
78562d1de5 Detect used types in pattern matching patterns 2019-07-25 00:19:43 +02:00
Jeroen Engels
f3fb8c59b9 Remove the "project aim and status" section 2019-07-24 23:25:48 +02:00
Jeroen Engels
f726d61d71 Add reasons for the rules/configuration being in Elm 2019-07-24 23:23:57 +02:00
Jeroen Engels
7a2bc49d41 Explain rationale behind not having a way to disable a rule locally 2019-07-24 23:20:10 +02:00
Jeroen Engels
2a56ed2ed1 Add elm-xref 2019-07-24 19:44:35 +02:00
Jeroen Engels
6f2a8b4605 Improve the use of phantom types for Rule.Schema
This gets rid of warnings that Configured and NotConfigured are unused
types
2019-07-24 19:44:25 +02:00
Jeroen Engels
2800e084e9 Organize the NoUnusedVariable rule tests 2019-07-24 18:58:56 +02:00
Jeroen Engels
7912badedd Stop importing everything from Html 2019-07-24 18:12:35 +02:00
Jeroen Engels
5417c67cea Remove unused type import 2019-07-24 18:11:22 +02:00
Jeroen Engels
4ae0c3749f Add tips on how to write rules/tests 2019-07-23 09:23:08 +02:00
Jeroen Engels
22ddced606 Add documentation on how the visitor functions work 2019-07-23 08:44:25 +02:00
Jeroen Engels
23f8fcad7e Give a simplified example for the Button use-case 2019-07-23 00:34:53 +02:00
Jeroen Engels
7dc2094ff8 Reword the error message for the NoDebug rule 2019-07-23 00:16:02 +02:00
Jeroen Engels
661bee3ef3 Add situations on when not to use the NoExtraBooleanComparison rule 2019-07-22 23:56:20 +02:00
Jeroen Engels
51014a5163 Rework the documentation for NoImportingEverything 2019-07-22 23:50:24 +02:00
Jeroen Engels
825dc676e0 Move the Fail/Success examples from the module to the rule documentation 2019-07-22 23:38:39 +02:00
Jeroen Engels
a3a57e468b Recommend using elm-xref in NoUnusedTypeConstructors 2019-07-13 15:25:03 +02:00
Jeroen Engels
6486148d25 Run missing locationIsAmbiguousInSourceCode test 2019-07-13 10:09:08 +02:00
Jeroen Engels
b829ab4f63 Lint.Test: Make error messgae formatting more consistent 2019-07-13 10:03:59 +02:00
Jeroen Engels
685e7dd6e1 Simplify the language used in Test error messages 2019-07-13 10:03:59 +02:00
Jeroen Engels
996c3039d6 Limit all Lint.Test error messages to 76 characters
This is so that they fit nicely in the terminal. The limit is usually 80
characters, but elm-test prepends every line by 4 spaces.
2019-07-13 10:03:58 +02:00
Jeroen Engels
905a74f901 Lint.Test: Add an identifiable name to errors to quickly be able to know what the problem is 2019-07-13 10:03:32 +02:00
Jeroen Engels
d6c8cb55bf Rewrite Lint.Test checks in a way that emphasizes the actual check 2019-07-11 17:53:23 +02:00
Jeroen Engels
b6464dbff2 Move error messages out of Lint.Test and into Lint.Test.ErrorMessage 2019-07-11 08:47:33 +02:00
Jeroen Engels
1d3333f489 Add tests for the Test error messages 2019-07-11 08:47:33 +02:00