Commit Graph

210 Commits

Author SHA1 Message Date
Jeroen Engels
1bd923cd5f Fix wrong error message. Thanks Anton Komissarov! 2020-03-23 20:42:29 +01:00
Jeroen Engels
023bbd60b5 Rename Project.withReadme to Project.addReadme 2020-03-20 19:06:09 +01:00
Jeroen Engels
6f73e42b9a Rename Project.withDependency and Project.withElmJson to Project.add* 2020-03-19 23:50:41 +01:00
Jeroen Engels
160cea7323 Remove module visitors for rules that didn't need them 2020-03-19 19:35:45 +01:00
Jeroen Engels
3077047e63 Make Scope add all visitors at once 2020-03-19 19:28:01 +01:00
Jeroen Engels
f076643150 Remove context and visitor argument for newProjectRuleSchema 2020-03-19 19:21:49 +01:00
Jeroen Engels
ce7c6b7021 Move initial project context to an argument of Rule.newProjectRuleSchema 2020-03-19 19:03:12 +01:00
Jeroen Engels
3b2449af08 Allow to expect for README errors in tests 2020-03-18 23:25:56 +01:00
Jeroen Engels
8273322832 Allow elm.json visitors to report errors in project rules 2020-03-18 23:08:06 +01:00
Jeroen Engels
7c76d8947a Add README support to Review.Project 2020-03-18 21:01:12 +01:00
Jeroen Engels
4263f35db9 Add dummy rule that will look at the README 2020-03-18 20:32:31 +01:00
Jeroen Engels
c619e2c484 Improve the range for NoTodoComment 2020-03-18 17:35:11 +01:00
Jeroen Engels
8013011d1a Handle phantom types outside of the module 2020-03-15 22:53:45 +01:00
Jeroen Engels
68eda525b5 Handle imports from other modules 2020-03-15 14:12:22 +01:00
Jeroen Engels
abcd73f0e4 Mark custom types... 2020-03-14 21:13:23 +01:00
Jeroen Engels
36b71557da WIP Mark custom type constructors from other modules as used. 2020-03-12 19:19:06 +01:00
Jeroen Engels
ad2f929d7e Report custom type constructors that are exposed 2020-03-12 17:46:51 +01:00
Jeroen Engels
36a3478828 NoUnused.CustomTypeConstructors: Report unused exposed type constructors 2020-03-12 17:23:00 +01:00
Jeroen Engels
4117baf838 Rename NoUnused.CustomTypeConstructors temporarily 2020-03-12 17:05:36 +01:00
Jeroen Engels
ce1c059d4c NoUnused.CustomTypeConstructors: Transform into a project rule 2020-03-12 16:59:14 +01:00
Jeroen Engels
b2fd92f529 NoUnused.CustomTypeConstructors: Prepare looking at other modules 2020-03-12 16:50:03 +01:00
Jeroen Engels
ce4febc1ac Support phantom types in NoUnused.CustomTypeConstructors 2020-03-11 17:51:09 +01:00
Jeroen Engels
c67aa1321c WIP: Don't report custom type constructors used as phantom types 2020-03-09 22:42:16 +01:00
Jeroen Engels
e438da283d Copy over NoUnused.CustomTypeConstructors temporarily 2020-03-09 21:21:38 +01:00
Jeroen Engels
c141fdb1ae Rename module rule's phantom fields to canCollectProjectData 2020-03-08 00:54:18 +01:00
Jeroen Engels
0d33ab05e7 Improve the error message when Review.Test.runOnModules is given an empty list 2020-03-07 20:11:07 +01:00
Jeroen Engels
801fae798a Remove version from dependency data 2020-03-07 19:57:16 +01:00
Jeroen Engels
37981b65db Make Dependencies opaque 2020-03-07 18:38:39 +01:00
Jeroen Engels
ec326af739 Write NoDebugTodoOrToString rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
8f1ec1dd3a Write NoDebugLog rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
5cfd68fb6b Rename withModuleDependenciesVisitor to withDependenciesModuleVisitor 2020-03-02 22:53:37 +01:00
Jeroen Engels
c09c46e4eb Rename withProjectElmJsonVisitor to withElmJsonProjectVisitor 2020-03-02 22:52:31 +01:00
Jeroen Engels
8406c29fd3 Rename withModuleElmJsonVisitor to withElmJsonModuleVisitor 2020-03-02 22:51:25 +01:00
Jeroen Engels
0b0b6d1b85 Use "List nothing" instead of "List Error" where possible 2020-02-28 17:11:15 +01:00
Jeroen Engels
d7f645241d Continue documentation for project rules 2020-02-27 19:19:33 +01:00
Jeroen Engels
fbcc11d6a9 Simplify Scope by not having a setter and getter 2020-02-16 23:29:11 +01:00
Jeroen Engels
c2c53fdbe6 Rename Rule.FileKey to Rule.ModuleKey 2020-02-16 21:54:05 +01:00
Jeroen Engels
382a6c8604 Add NoInvalidLicense 2020-02-16 21:40:59 +01:00
Jeroen Engels
c652a24d48 Store more information about the project's dependencies 2020-02-16 21:40:59 +01:00
Jeroen Engels
a91d66ea60 Add Review.Test.expectErrorsForElmJson 2020-02-16 16:56:33 +01:00
Jeroen Engels
0f39773e75 Change how dependencies are stored, and add NoUnused.Dependencies rule 2020-02-16 16:56:33 +01:00
Jeroen Engels
6bfc9f0757 Remove unused elements in tests 2020-02-16 16:56:19 +01:00
Jeroen Engels
24723bf066 Make it possible to report errors in the elm.json file 2020-02-16 16:56:19 +01:00
Jeroen Engels
f28b7698d7 Give a nicer error message when under is passed empty 2020-02-11 18:47:28 +01:00
Jeroen Engels
b72326085b Give a nicer error message in tests when the location could not be found 2020-02-11 18:12:51 +01:00
Jeroen Engels
e00ab39cd7 Fail tests if there are unknown module names in the expected errors list for expectErrorsForModules 2020-02-11 17:46:06 +01:00
Jeroen Engels
ac0ec7fe34 Rename traversingImportedModulesFirst to withContextFromImportedModules 2020-02-10 23:18:09 +01:00
Jeroen Engels
89a3a3d1b4 Rename withDependenciesVisitor to withModuleDependenciesVisitor 2020-01-27 17:18:06 +01:00
Jeroen Engels
0cada05fe3 Rename withElmJsonVisitor to withModuleElmJsonVisitor 2020-01-27 17:18:06 +01:00
Jeroen Engels
66bf74baac Rename withFinalEvaluation to withFinalModuleEvaluation 2020-01-26 13:28:57 +01:00