Commit Graph

60 Commits

Author SHA1 Message Date
Jeroen Engels
7a2978925f Make emptyDetails take a String 2021-03-10 17:02:21 +01:00
Jeroen Engels
49025a5855 Fail when expected error could not be found 2021-03-10 17:02:21 +01:00
Jeroen Engels
253b04187e Add unexpectedGlobalErrorDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
f1f97de257 Change error message for unexpectedDetails 2021-03-10 17:02:21 +01:00
Jeroen Engels
279ac055bb Remove handling of global error module name 2021-03-10 17:02:21 +01:00
Jeroen Engels
cb84596b08 Handle global errors differently 2021-03-10 17:02:21 +01:00
Jeroen Engels
f46f3216bb Make a specific error for too many global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
cc17889499 Make a specific error for unexpected global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
4cb8d74815 Change the error message for global errors 2021-03-10 17:02:21 +01:00
Jeroen Engels
cb604c782f Backport unused and test-values 2020-12-23 19:12:04 +01:00
Jeroen Engels
e925d0a25a Fix files not being evaluated when they're ignored in project rules without a folder 2020-09-09 18:50:42 +02:00
Jeroen Engels
4c43013fb8 Remove Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
d2220e652b Use Rule instead of Rule3 2020-06-28 08:01:44 +02:00
Jeroen Engels
7bd35b1941 Add project visitors to module visitors 2020-06-26 00:08:31 +02:00
Jeroen Engels
1d5ca98a61 Make visitor order test more robust 2020-06-25 23:09:09 +02:00
Jeroen Engels
2082f1fd34 Use withExpressionEnterVisitor in tests and examples 2020-06-19 17:57:27 +02:00
Jeroen Engels
5e2b633c54 Fix inversion of result and expected fixed source code in whitespace failure message 2020-06-19 12:36:12 +02:00
Jeroen Engels
210dbea5e1 Enable NoUnused.Parameters 2020-06-14 16:44:44 +02:00
Jeroen Engels
be43b18a2f Make every test failure title red and bold 2020-06-03 19:16:42 +02:00
Jeroen Engels
ca98c71e43 Make "Rule reported less errors than expected" error more informative 2020-05-19 19:41:11 +02:00
Jeroen Engels
c76d4d972f Make expected errors order-agnostic
Fixes #12
2020-05-17 17:08:27 +02:00
Jeroen Engels
d2c37dd489 Fix typo in test failure messages 2020-05-14 20:45:16 +02:00
Jeroen Engels
06564b9cc1 Rename ErrorMessage to FailureMessage 2020-05-14 20:45:16 +02:00
Jeroen Engels
bd4377f106 Fix files not being ignored correctly in Windows 2020-04-29 19:32:06 +02:00
Jeroen Engels
9ce54258a6 Remove references to withFixes 2020-04-05 09:25:17 +02:00
Jeroen Engels
f96b38160b Improve how fixes are applied 2020-04-04 14:29:40 +02:00
Jeroen Engels
1143afeb31 Re-allow README to be automatically fixed 2020-04-04 12:35:29 +02:00
Jeroen Engels
30eabfde39 Reorganize test files for the core internals 2020-04-03 16:19:24 +02:00
Jeroen Engels
ec4044826b Re-organize test rules 2020-04-03 16:19:24 +02:00
Jeroen Engels
60106d7958 Add NoUnused rules like they are in jfmengels/review-unused 2020-04-03 16:19:24 +02:00
Jeroen Engels
61aaf0f873 Give less useless details in NoUnused rules 2020-04-01 22:40:23 +02:00
Jeroen Engels
0f25a734e5 Change the order of Scope.realModuleName arguments 2020-04-01 20:13:45 +02:00
Jeroen Engels
402eb6f813 Update NoUnusedVariable 2020-04-01 20:13:45 +02:00
Jeroen Engels
143ecb9618 Rename realFunctionOrType by realModuleName 2020-04-01 20:13:45 +02:00
Jeroen Engels
9328872aa6 Rename Scope2 to Review.Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
5dec76b06c Prevent use of error in project visitors 2020-04-01 20:13:45 +02:00
Jeroen Engels
31cd0c6691 Add phantom type variable to Error in other files than Review.Rule 2020-04-01 20:13:45 +02:00
Jeroen Engels
6f73e42b9a Rename Project.withDependency and Project.withElmJson to Project.add* 2020-03-19 23:50:41 +01:00
Jeroen Engels
160cea7323 Remove module visitors for rules that didn't need them 2020-03-19 19:35:45 +01:00
Jeroen Engels
f076643150 Remove context and visitor argument for newProjectRuleSchema 2020-03-19 19:21:49 +01:00
Jeroen Engels
ce7c6b7021 Move initial project context to an argument of Rule.newProjectRuleSchema 2020-03-19 19:03:12 +01:00
Jeroen Engels
8273322832 Allow elm.json visitors to report errors in project rules 2020-03-18 23:08:06 +01:00
Jeroen Engels
8f1ec1dd3a Write NoDebugLog rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
5cfd68fb6b Rename withModuleDependenciesVisitor to withDependenciesModuleVisitor 2020-03-02 22:53:37 +01:00
Jeroen Engels
c09c46e4eb Rename withProjectElmJsonVisitor to withElmJsonProjectVisitor 2020-03-02 22:52:31 +01:00
Jeroen Engels
8406c29fd3 Rename withModuleElmJsonVisitor to withElmJsonModuleVisitor 2020-03-02 22:51:25 +01:00
Jeroen Engels
0b0b6d1b85 Use "List nothing" instead of "List Error" where possible 2020-02-28 17:11:15 +01:00
Jeroen Engels
d7f645241d Continue documentation for project rules 2020-02-27 19:19:33 +01:00
Jeroen Engels
6bfc9f0757 Remove unused elements in tests 2020-02-16 16:56:19 +01:00
Jeroen Engels
24723bf066 Make it possible to report errors in the elm.json file 2020-02-16 16:56:19 +01:00