Commit Graph

226 Commits

Author SHA1 Message Date
Jeroen Engels
8637b6050e Move misc rules into a separate folder 2020-04-03 23:00:51 +02:00
Jeroen Engels
30eabfde39 Reorganize test files for the core internals 2020-04-03 16:19:24 +02:00
Jeroen Engels
ec4044826b Re-organize test rules 2020-04-03 16:19:24 +02:00
Jeroen Engels
19f35f835f Move test rules into tests/ 2020-04-03 16:19:24 +02:00
Jeroen Engels
60106d7958 Add NoUnused rules like they are in jfmengels/review-unused 2020-04-03 16:19:24 +02:00
Jeroen Engels
02d7665e91 Add NoDebug rules like they are in jfmengels/review-debug 2020-04-03 16:19:24 +02:00
Jeroen Engels
61aaf0f873 Give less useless details in NoUnused rules 2020-04-01 22:40:23 +02:00
Jeroen Engels
0f25a734e5 Change the order of Scope.realModuleName arguments 2020-04-01 20:13:45 +02:00
Jeroen Engels
402eb6f813 Update NoUnusedVariable 2020-04-01 20:13:45 +02:00
Jeroen Engels
143ecb9618 Rename realFunctionOrType by realModuleName 2020-04-01 20:13:45 +02:00
Jeroen Engels
9328872aa6 Rename Scope2 to Review.Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
baafd04810 Fix prelude loading in Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
69c6f4e515 Use Scope2 instead of Scope 2020-04-01 20:13:45 +02:00
Jeroen Engels
ab360b6db1 Add phantom type variable to Error in documentation examples 2020-04-01 20:13:45 +02:00
Jeroen Engels
5dec76b06c Prevent use of error in project visitors 2020-04-01 20:13:45 +02:00
Jeroen Engels
31cd0c6691 Add phantom type variable to Error in other files than Review.Rule 2020-04-01 20:13:45 +02:00
Jeroen Engels
1bd923cd5f Fix wrong error message. Thanks Anton Komissarov! 2020-03-23 20:42:29 +01:00
Jeroen Engels
023bbd60b5 Rename Project.withReadme to Project.addReadme 2020-03-20 19:06:09 +01:00
Jeroen Engels
6f73e42b9a Rename Project.withDependency and Project.withElmJson to Project.add* 2020-03-19 23:50:41 +01:00
Jeroen Engels
160cea7323 Remove module visitors for rules that didn't need them 2020-03-19 19:35:45 +01:00
Jeroen Engels
3077047e63 Make Scope add all visitors at once 2020-03-19 19:28:01 +01:00
Jeroen Engels
f076643150 Remove context and visitor argument for newProjectRuleSchema 2020-03-19 19:21:49 +01:00
Jeroen Engels
ce7c6b7021 Move initial project context to an argument of Rule.newProjectRuleSchema 2020-03-19 19:03:12 +01:00
Jeroen Engels
3b2449af08 Allow to expect for README errors in tests 2020-03-18 23:25:56 +01:00
Jeroen Engels
8273322832 Allow elm.json visitors to report errors in project rules 2020-03-18 23:08:06 +01:00
Jeroen Engels
7c76d8947a Add README support to Review.Project 2020-03-18 21:01:12 +01:00
Jeroen Engels
4263f35db9 Add dummy rule that will look at the README 2020-03-18 20:32:31 +01:00
Jeroen Engels
c619e2c484 Improve the range for NoTodoComment 2020-03-18 17:35:11 +01:00
Jeroen Engels
8013011d1a Handle phantom types outside of the module 2020-03-15 22:53:45 +01:00
Jeroen Engels
68eda525b5 Handle imports from other modules 2020-03-15 14:12:22 +01:00
Jeroen Engels
abcd73f0e4 Mark custom types... 2020-03-14 21:13:23 +01:00
Jeroen Engels
36b71557da WIP Mark custom type constructors from other modules as used. 2020-03-12 19:19:06 +01:00
Jeroen Engels
ad2f929d7e Report custom type constructors that are exposed 2020-03-12 17:46:51 +01:00
Jeroen Engels
36a3478828 NoUnused.CustomTypeConstructors: Report unused exposed type constructors 2020-03-12 17:23:00 +01:00
Jeroen Engels
4117baf838 Rename NoUnused.CustomTypeConstructors temporarily 2020-03-12 17:05:36 +01:00
Jeroen Engels
ce1c059d4c NoUnused.CustomTypeConstructors: Transform into a project rule 2020-03-12 16:59:14 +01:00
Jeroen Engels
b2fd92f529 NoUnused.CustomTypeConstructors: Prepare looking at other modules 2020-03-12 16:50:03 +01:00
Jeroen Engels
ce4febc1ac Support phantom types in NoUnused.CustomTypeConstructors 2020-03-11 17:51:09 +01:00
Jeroen Engels
c67aa1321c WIP: Don't report custom type constructors used as phantom types 2020-03-09 22:42:16 +01:00
Jeroen Engels
e438da283d Copy over NoUnused.CustomTypeConstructors temporarily 2020-03-09 21:21:38 +01:00
Jeroen Engels
c141fdb1ae Rename module rule's phantom fields to canCollectProjectData 2020-03-08 00:54:18 +01:00
Jeroen Engels
0d33ab05e7 Improve the error message when Review.Test.runOnModules is given an empty list 2020-03-07 20:11:07 +01:00
Jeroen Engels
801fae798a Remove version from dependency data 2020-03-07 19:57:16 +01:00
Jeroen Engels
37981b65db Make Dependencies opaque 2020-03-07 18:38:39 +01:00
Jeroen Engels
ec326af739 Write NoDebugTodoOrToString rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
8f1ec1dd3a Write NoDebugLog rule 2020-03-07 16:09:35 +01:00
Jeroen Engels
5cfd68fb6b Rename withModuleDependenciesVisitor to withDependenciesModuleVisitor 2020-03-02 22:53:37 +01:00
Jeroen Engels
c09c46e4eb Rename withProjectElmJsonVisitor to withElmJsonProjectVisitor 2020-03-02 22:52:31 +01:00
Jeroen Engels
8406c29fd3 Rename withModuleElmJsonVisitor to withElmJsonModuleVisitor 2020-03-02 22:51:25 +01:00
Jeroen Engels
0b0b6d1b85 Use "List nothing" instead of "List Error" where possible 2020-02-28 17:11:15 +01:00