Commit Graph

2735 Commits

Author SHA1 Message Date
Jeroen Engels
48ed3ae405 Return the rule 2023-04-12 22:59:45 +02:00
Jeroen Engels
05a930ae9b Pass the rule to standardFindFix 2023-04-12 22:59:45 +02:00
Jeroen Engels
99fc0e7c05 Use a case expression 2023-04-12 22:59:45 +02:00
Jeroen Engels
8a3f519234 Add FindFixResult 2023-04-12 22:59:45 +02:00
Jeroen Engels
c6ed336ad9 Add an accumulator for errors we've seen 2023-04-12 22:59:45 +02:00
Jeroen Engels
87f237de4a Add setErrors to RuleProjectVisitor 2023-04-12 22:59:45 +02:00
Jeroen Engels
9e7c9593aa Add setErrors 2023-04-12 22:59:45 +02:00
Jeroen Engels
4dc5ad8c9f Duplicate function 2023-04-12 22:59:45 +02:00
Jeroen Engels
51b614af39 Don't pass fixedErrors 2023-04-12 22:59:45 +02:00
Jeroen Engels
9d89aec28b Re-invert case 2023-04-12 22:59:45 +02:00
Jeroen Engels
421d174660 Explicit all fields 2023-04-12 22:59:45 +02:00
Jeroen Engels
5e6fd9b61f Use type alias 2023-04-12 22:59:45 +02:00
Jeroen Engels
4a712de0ba Don't pass ruleProjectVisitors separately 2023-04-12 22:59:45 +02:00
Jeroen Engels
21e98d8dc2 Inverse case 2023-04-12 22:59:45 +02:00
Jeroen Engels
0f4ae72a83 Add findErrorsInCache 2023-04-12 22:59:45 +02:00
Jeroen Engels
6e40d4c84b Pass fixed errors 2023-04-12 22:59:45 +02:00
Jeroen Engels
e6f8fd604f Remove unused computeModuleWithRuleVisitorsAndFindFix 2023-04-12 22:59:45 +02:00
Jeroen Engels
13be5c105a Don't pass redundant exceptions 2023-04-12 22:59:45 +02:00
Jeroen Engels
bf0ef63977 Add TODO 2023-04-12 22:59:45 +02:00
Jeroen Engels
4640e180ae Check for errors even when no rules are being run 2023-04-12 22:56:02 +02:00
Jeroen Engels
70f1b1ad7a Extract computeWhatsRequiredToAnalyze 2023-04-12 22:56:02 +02:00
Jeroen Engels
369664a032 Take only the required parameters 2023-04-12 22:56:02 +02:00
Jeroen Engels
82561eba66 Avoid passing the file path 2023-04-12 22:56:02 +02:00
Jeroen Engels
4c723d3948 Split analyzing the module and finding a fixable error in it 2023-04-12 22:56:02 +02:00
Jeroen Engels
cc981322d4 Extract computation of lookup table 2023-04-12 22:56:02 +02:00
Jeroen Engels
34e0809490 Remove TODO 2023-04-12 22:56:02 +02:00
Jeroen Engels
240361565f Inline ignoreModule 2023-04-12 22:56:02 +02:00
Jeroen Engels
aabdaf68d3 Remove helper function 2023-04-12 22:56:02 +02:00
Jeroen Engels
faae8be580 Remove helper function 2023-04-12 22:56:02 +02:00
Jeroen Engels
0be7e92914 Remove helper function 2023-04-12 22:56:02 +02:00
Jeroen Engels
d4acf91a46 Add comment 2023-04-12 22:56:02 +02:00
Jeroen Engels
ae233a0969 Attempt marking error as failing as side-effect 2023-04-12 22:55:11 +02:00
Jeroen Engels
3117c6b04f Add markFixesAsProblem 2023-04-12 22:55:11 +02:00
Jeroen Engels
389bfbfcde Make applying fixes return a Result 2023-04-12 22:55:11 +02:00
Jeroen Engels
f01dc718a4 Move definition of FixProblem 2023-04-12 22:55:11 +02:00
Jeroen Engels
9902fcad00 Add Review.Rule.errorFixFailure 2023-04-12 22:55:11 +02:00
Jeroen Engels
ed59b64dae Turn fixes into ErrorFixes 2023-04-11 00:13:48 +02:00
Jeroen Engels
9f0d97aaca Add ErrorFixes type 2023-04-10 23:53:58 +02:00
Jeroen Engels
5a536d906b Change order of arguments 2023-04-10 16:46:38 +02:00
Jeroen Engels
f2c96c3369 Abort early when noticing a fixable error in elm.json 2023-04-10 16:45:26 +02:00
Jeroen Engels
f68055dc59 Split into helper function 2023-04-10 16:43:21 +02:00
Jeroen Engels
b7695db578 Remove unused Output type 2023-04-10 16:41:44 +02:00
Jeroen Engels
db5be5a947 Change order of arguments 2023-04-10 16:41:32 +02:00
Jeroen Engels
60d1763a48 Change order of arguments 2023-04-10 16:41:20 +02:00
Jeroen Engels
8ed7a1854d Compute dependencies data only once 2023-04-10 16:23:23 +02:00
Jeroen Engels
ca09ba23fb Abort early when noticing a fixable error in dependencies 2023-04-10 16:16:56 +02:00
Jeroen Engels
2830d16cb5 Simplify computeFinalProjectEvaluation 2023-04-10 16:03:52 +02:00
Jeroen Engels
20b69a5a7e Create helper to find fixes 2023-04-10 16:02:59 +02:00
Jeroen Engels
c0f05f1f42 Merge computeReadmeHelp functions 2023-04-10 15:50:54 +02:00
Jeroen Engels
43b3cfc8f4 Don't return errors 2023-04-10 15:50:14 +02:00