mirror of
https://github.com/jfmengels/elm-review.git
synced 2024-11-23 14:55:35 +03:00
235 lines
8.4 KiB
Elm
235 lines
8.4 KiB
Elm
module NoInconsistentAliases.Visitor exposing (rule)
|
|
|
|
import Elm.Syntax.Import exposing (Import)
|
|
import Elm.Syntax.ModuleName exposing (ModuleName)
|
|
import Elm.Syntax.Node as Node exposing (Node(..))
|
|
import NoInconsistentAliases.BadAlias as BadAlias exposing (BadAlias)
|
|
import NoInconsistentAliases.Config exposing (Config)
|
|
import NoInconsistentAliases.Context as Context
|
|
import NoInconsistentAliases.MissingAlias as MissingAlias exposing (MissingAlias)
|
|
import NoInconsistentAliases.ModuleUse as ModuleUse exposing (ModuleUse)
|
|
import NoInconsistentAliases.Visitor.Options as Options exposing (Options)
|
|
import Review.Fix as Fix exposing (Fix)
|
|
import Review.Rule as Rule exposing (Error, Rule)
|
|
import Vendor.NameVisitor as NameVisitor
|
|
|
|
|
|
rule : Config -> Rule
|
|
rule config =
|
|
let
|
|
options : Options
|
|
options =
|
|
Options.fromConfig config
|
|
in
|
|
Rule.newModuleRuleSchema "NoInconsistentAliases" Context.initial
|
|
|> Rule.withImportVisitor (importVisitor options)
|
|
|> NameVisitor.withNameVisitor moduleCallVisitor
|
|
|> Rule.withFinalModuleEvaluation (finalEvaluation options.lookupAlias)
|
|
|> Rule.providesFixesForModuleRule
|
|
|> Rule.fromModuleRuleSchema
|
|
|
|
|
|
importVisitor : Options -> Node Import -> Context.Module -> ( List (Error {}), Context.Module )
|
|
importVisitor options (Node _ { moduleName, moduleAlias }) context =
|
|
( []
|
|
, context
|
|
|> rememberModuleAlias moduleName moduleAlias
|
|
|> rememberBadAlias options moduleName moduleAlias
|
|
)
|
|
|
|
|
|
rememberModuleAlias : Node ModuleName -> Maybe (Node ModuleName) -> Context.Module -> Context.Module
|
|
rememberModuleAlias moduleName maybeModuleAlias context =
|
|
let
|
|
moduleAlias =
|
|
maybeModuleAlias |> Maybe.withDefault moduleName |> Node.map formatModuleName
|
|
in
|
|
context |> Context.addModuleAlias (Node.value moduleName) (Node.value moduleAlias)
|
|
|
|
|
|
rememberBadAlias : Options -> Node ModuleName -> Maybe (Node ModuleName) -> Context.Module -> Context.Module
|
|
rememberBadAlias { lookupAlias, canMissAliases } (Node moduleNameRange moduleName) maybeModuleAlias context =
|
|
case ( lookupAlias moduleName, maybeModuleAlias ) of
|
|
( Just expectedAlias, Just (Node moduleAliasRange moduleAlias) ) ->
|
|
if [ expectedAlias ] /= moduleAlias then
|
|
let
|
|
badAlias =
|
|
BadAlias.new
|
|
{ name = moduleAlias |> formatModuleName
|
|
, moduleName = moduleName
|
|
, expectedName = expectedAlias
|
|
, range = moduleAliasRange
|
|
}
|
|
in
|
|
context |> Context.addBadAlias badAlias
|
|
|
|
else
|
|
context
|
|
|
|
( Just expectedAlias, Nothing ) ->
|
|
if canMissAliases then
|
|
context
|
|
|
|
else
|
|
let
|
|
missingAlias =
|
|
MissingAlias.new moduleName expectedAlias moduleNameRange
|
|
in
|
|
context |> Context.addMissingAlias missingAlias
|
|
|
|
( Nothing, _ ) ->
|
|
context
|
|
|
|
|
|
moduleCallVisitor : Node ( ModuleName, String ) -> Context.Module -> ( List (Error {}), Context.Module )
|
|
moduleCallVisitor node context =
|
|
case Node.value node of
|
|
( moduleName, function ) ->
|
|
( [], Context.addModuleCall moduleName function (Node.range node) context )
|
|
|
|
|
|
finalEvaluation : Options.AliasLookup -> Context.Module -> List (Error {})
|
|
finalEvaluation lookupAlias context =
|
|
let
|
|
lookupModuleName =
|
|
Context.lookupModuleName context
|
|
in
|
|
Context.foldBadAliases (foldBadAliasError lookupAlias lookupModuleName) [] context
|
|
++ Context.foldMissingAliases foldMissingAliasError [] context
|
|
|
|
|
|
foldBadAliasError : Options.AliasLookup -> ModuleNameLookup -> BadAlias -> List (Error {}) -> List (Error {})
|
|
foldBadAliasError lookupAlias lookupModuleName badAlias errors =
|
|
let
|
|
moduleName =
|
|
badAlias |> BadAlias.mapModuleName identity
|
|
|
|
expectedAlias =
|
|
badAlias |> BadAlias.mapExpectedName identity
|
|
|
|
moduleClash =
|
|
detectCollision (lookupModuleName expectedAlias) moduleName
|
|
|
|
aliasClash =
|
|
moduleClash |> Maybe.andThen lookupAlias
|
|
in
|
|
case ( aliasClash, moduleClash ) of
|
|
( Just _, _ ) ->
|
|
errors
|
|
|
|
( Nothing, Just collisionName ) ->
|
|
Rule.error (collisionAliasMessage collisionName expectedAlias badAlias) (BadAlias.range badAlias)
|
|
:: errors
|
|
|
|
( Nothing, Nothing ) ->
|
|
let
|
|
badRange =
|
|
BadAlias.range badAlias
|
|
|
|
fixes =
|
|
Fix.replaceRangeBy badRange expectedAlias
|
|
:: BadAlias.mapUses (fixModuleUse expectedAlias) badAlias
|
|
in
|
|
Rule.errorWithFix (incorrectAliasMessage expectedAlias badAlias) badRange fixes
|
|
:: errors
|
|
|
|
|
|
foldMissingAliasError : MissingAlias -> List (Error {}) -> List (Error {})
|
|
foldMissingAliasError missingAlias errors =
|
|
if MissingAlias.hasUses missingAlias then
|
|
let
|
|
expectedAlias =
|
|
missingAlias |> MissingAlias.mapExpectedName identity
|
|
|
|
badRange =
|
|
MissingAlias.range missingAlias
|
|
|
|
fixes =
|
|
Fix.insertAt badRange.end (" as " ++ expectedAlias)
|
|
:: MissingAlias.mapUses (fixModuleUse expectedAlias) missingAlias
|
|
in
|
|
Rule.errorWithFix (missingAliasMessage expectedAlias missingAlias) badRange fixes
|
|
:: errors
|
|
|
|
else
|
|
errors
|
|
|
|
|
|
detectCollision : Maybe ModuleName -> ModuleName -> Maybe ModuleName
|
|
detectCollision maybeCollisionName moduleName =
|
|
maybeCollisionName
|
|
|> Maybe.andThen
|
|
(\collisionName ->
|
|
if collisionName == moduleName then
|
|
Nothing
|
|
|
|
else
|
|
Just collisionName
|
|
)
|
|
|
|
|
|
incorrectAliasMessage : String -> BadAlias -> { message : String, details : List String }
|
|
incorrectAliasMessage expectedAlias badAlias =
|
|
let
|
|
badAliasName =
|
|
BadAlias.mapName identity badAlias
|
|
|
|
moduleName =
|
|
BadAlias.mapModuleName formatModuleName badAlias
|
|
in
|
|
{ message =
|
|
"Incorrect alias `" ++ badAliasName ++ "` for module `" ++ moduleName ++ "`."
|
|
, details =
|
|
[ "This import does not use your preferred alias `" ++ expectedAlias ++ "` for `" ++ moduleName ++ "`."
|
|
, "You should update the alias to be consistent with the rest of the project. Remember to change all references to the alias in this module too."
|
|
]
|
|
}
|
|
|
|
|
|
collisionAliasMessage : ModuleName -> String -> BadAlias -> { message : String, details : List String }
|
|
collisionAliasMessage collisionName expectedAlias badAlias =
|
|
let
|
|
badAliasName =
|
|
BadAlias.mapName identity badAlias
|
|
|
|
moduleName =
|
|
BadAlias.mapModuleName formatModuleName badAlias
|
|
in
|
|
{ message =
|
|
"Incorrect alias `" ++ badAliasName ++ "` for module `" ++ moduleName ++ "`."
|
|
, details =
|
|
[ "This import does not use your preferred alias `" ++ expectedAlias ++ "` for `" ++ moduleName ++ "`."
|
|
, "Your preferred alias has already been taken by `" ++ formatModuleName collisionName ++ "`."
|
|
, "You should change the alias for both modules to be consistent with the rest of the project. Remember to change all references to the alias in this module too."
|
|
]
|
|
}
|
|
|
|
|
|
missingAliasMessage : String -> MissingAlias -> { message : String, details : List String }
|
|
missingAliasMessage expectedAlias missingAlias =
|
|
let
|
|
moduleName =
|
|
MissingAlias.mapModuleName formatModuleName missingAlias
|
|
in
|
|
{ message =
|
|
"Expected alias `" ++ expectedAlias ++ "` missing for module `" ++ moduleName ++ "`."
|
|
, details =
|
|
[ "This import does not use your preferred alias `" ++ expectedAlias ++ "` for `" ++ moduleName ++ "`."
|
|
, "You should update the alias to be consistent with the rest of the project. Remember to change all references to the alias in this module too."
|
|
]
|
|
}
|
|
|
|
|
|
fixModuleUse : String -> ModuleUse -> Fix
|
|
fixModuleUse expectedAlias use =
|
|
Fix.replaceRangeBy (ModuleUse.range use) (ModuleUse.mapFunction (\name -> expectedAlias ++ "." ++ name) use)
|
|
|
|
|
|
formatModuleName : ModuleName -> String
|
|
formatModuleName moduleName =
|
|
String.join "." moduleName
|
|
|
|
|
|
type alias ModuleNameLookup =
|
|
String -> Maybe ModuleName
|