From 304ccf33ab61d4b73a22b57c1ff1aeecd6b235fb Mon Sep 17 00:00:00 2001
From: Jamie Wong <jamie.lf.wong@gmail.com>
Date: Sun, 16 Jul 2023 15:31:31 -0700
Subject: [PATCH] Update publish-and-deploy to remove automated release
 creation (#440)

Turns out the `--attach` command was hallucinated by GPT!
---
 scripts/publish-and-deploy.sh | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/scripts/publish-and-deploy.sh b/scripts/publish-and-deploy.sh
index 7912751..06aa487 100755
--- a/scripts/publish-and-deploy.sh
+++ b/scripts/publish-and-deploy.sh
@@ -43,9 +43,32 @@ git push --tags
 # Publish to npm
 npm publish
 
+# Deploy the website
+npm run deploy
+
 # Create a new release on Github
 "$script_dir/prepare-zip-file.sh"
-gh release create "$tagname" --title "$tagname" --notes "$changelog_update" --attach "dist/release/speedscope-$version.zip"
 
-# Deploy the website
-npm run deploy
\ No newline at end of file
+# Don't double echo the below commands
+set +x
+
+echo
+echo
+echo "Visit https://github.com/jlfwong/speedscope/releases/new to create a new release."
+echo
+echo "tag: $tagname"
+echo "title: $tagname"
+echo "attachment: dist/release/speedscope-$version.zip"
+echo "$changelog_update"
+
+# NOTE: This part is almost-but-not-quite-automatable using a command like this:
+#
+#    gh release create "$tagname" --title "$tagname" --notes "$changelog_update"
+#      --attach "dist/release/speedscope-$version.zip"
+#
+# There are two problems.
+#
+# 1. The "--attach" flag doesn't exit
+# 2. I don't want the changelog notes to include the version and date like they do in CHANGELOG.md
+#
+# If 1. was solveable, then 2. would be easy to work-around.
\ No newline at end of file