speedscope/sample
Jamie Wong ac4a015559
Add bounds checking for sampleTypeIndex (#449)
Wow this was surprising. As reported in #448, the `simple.speedscope.json` file failed import. This was surprising to me because there's a test that covers that file to ensure it imports correctly.

The file provided in #448, however, is from a version of speedscope from 5 years ago before the file had been pretty printed. It turns out that when this *particular* file is not pretty-printed, it's a schematically valid pprof profile.

The fix is to do some bounds checks and return null. After the change, the file imports as you'd expect after realizing its not actually a valid pprof profile.

Fixes #448
2023-12-07 18:43:47 -08:00
..
profiles Add bounds checking for sampleTypeIndex (#449) 2023-12-07 18:43:47 -08:00
programs Stackprof: weight on-cpu samples by period rather than timestamp delta (#425) 2023-06-17 20:50:19 -07:00