mirror of
https://github.com/jlfwong/speedscope.git
synced 2024-11-26 15:45:50 +03:00
ca1abfdd32
Fixes #268 I fixed it by dropping the dependency on quicktype entirely, and using its dependency directly. I still don't understand why the version of typescript used in this repository affects what quicktype is doing, but it seems like the issue is in quicktype, not its dependency. I validated this change was correct by diffing the output of `node scripts/generate-file-format-schema-json.js` with what's currently on http://speedscope.app/file-format-schema.json. There's no difference. This PR also includes changes to the CI script to ensure that we can catch this before hitting master next time.
8 lines
141 B
Bash
Executable File
8 lines
141 B
Bash
Executable File
#!/bin/bash
|
|
|
|
set -euxo pipefail
|
|
|
|
npm run typecheck
|
|
npm run lint
|
|
npm run coverage
|
|
node scripts/generate-file-format-schema-json.js > /dev/null |