b8e9793 · jsaddle · git.iko.soy

git.iko.soy/jsaddle

Fix GHC JavaScript.Array.write

Without this, we get `TypeError: jsaddle_values.get(...).apply is not a function` on GHC, but GHCJS works fine.

commitb8e9793455562e3f30f45f9e311443a76ea1dc4f authorTom Smalley <tomsmalley@users.noreply.github.com> dateSat 19 Oct 2019, 17:40 (7 years ago) parente00d268

1 file changed+2−2

compare with master

unifiedsplit

jsaddle/src-ghc/JavaScript/Array.hs+2−2

jsaddle/src-ghc/JavaScript/Array.hs+2−2

@@ -48,7 +48,7 @@ import Language.Javascript.JSaddle.Types

4848 (JSM, JSVal, SomeJSArray(..), JSArray,

4949 MutableJSArray, GHCJSPure(..))

5050import Control.Lens.Operators ((^.))

51−import Language.Javascript.JSaddle.Object (js2, js0, (##), js1, js)

51+import Language.Javascript.JSaddle.Object (js2, js0, (<##), js1, js)

5252import Language.Javascript.JSaddle.Value (valToNumber)

5353import JavaScript.Array.Internal (create, fromList, fromListIO, toList, toListIO, index, read, push)

5454

@@ -69,7 +69,7 @@ append (SomeJSArray x) (SomeJSArray y) = SomeJSArray <$> x ^. js1 "concat" y

6969{-# INLINE append #-}

7070

7171write :: Int -> JSVal -> MutableJSArray -> JSM ()

72−write n e (SomeJSArray x) = void $ (x ## n) e

72+write n e (SomeJSArray x) = void $ (x <## n) e

7373{-# INLINE write #-}

7474

7575pop :: MutableJSArray -> JSM JSVal