jtdaugherty/brick
1
1
Fork 0
mirror of https://github.com/jtdaugherty/brick.git synced 2024-11-29 21:46:11 +03:00
Code Issues Projects Releases Wiki Activity

Merge pull request #402 from frasertweedale/perf/renderBox-redundant-crops

Browse Source 
renderBox: avoid redundant cropResultToContext calls
This commit is contained in:
Jonathan Daugherty 2022-10-15 09:13:05 -07:00 committed by GitHub
commit b0ebc63e7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Brick/Widgets/Core.hs
View File

@ -639,18 +639,13 @@ renderBox br ws =
(his, lows) = partition (\p -> (primaryWidgetSize br $ snd p) == Fixed)
pairsIndexed
let availPrimary = c^.(contextPrimary br)
availSecondary = c^.(contextSecondary br)
renderHi prim = do
remainingPrimary <- get
result <- lift $ render $ limitPrimary br remainingPrimary
$ limitSecondary br availSecondary
$ cropToContext prim
result <- lift $ render $ limitPrimary br remainingPrimary prim
result <$ (put $! remainingPrimary - (result^.imageL.(to $ imagePrimary br)))
(renderedHis, remainingPrimary) <-
runStateT (traverse (traverse renderHi) his) availPrimary
runStateT (traverse (traverse renderHi) his) (c ^. contextPrimary br)
renderedLows <- case lows of
[] -> return []
@ -660,10 +655,7 @@ renderBox br ws =
primaries = replicate rest (primaryPerLow + 1) <>
replicate (length ls - rest) primaryPerLow
let renderLow ((i, prim), pri) =
(i,) <$> (render $ limitPrimary br pri
$ limitSecondary br availSecondary
$ cropToContext prim)
let renderLow ((i, prim), pri) = (i,) <$> render (limitPrimary br pri prim)
if remainingPrimary > 0 then mapM renderLow (zip ls primaries) else return []