jtheoof/swappy
1
1
Fork 0
mirror of https://github.com/jtheoof/swappy.git synced 2024-10-05 19:07:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(pixbuf): handle overflow when filename_format is too long

Browse Source 
Most of the filesystems have max filename limited to 255 chars.

Let's set that limit and handle the case where the resulting `strftime`
format is larger.

Closes #74
This commit is contained in:
Jeremy Attali 2021-02-21 14:54:33 -05:00 committed by Jeremy Attali
parent c6b09e5639
commit 185575bf75
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/pixbuf.c
View File

@ -26,14 +26,23 @@ void pixbuf_save_state_to_folder(GdkPixbuf *pixbuf, char *folder,
char *filename_format) {
time_t current_time = time(NULL);
char *c_time_string;
char filename[strlen(filename_format) + 3];
char filename[255];
char path[MAX_PATH];
size_t bytes_formated;
c_time_string = ctime(&current_time);
c_time_string[strlen(c_time_string) - 1] = '\0';
strftime(filename, sizeof(filename), filename_format,
localtime(&current_time));
char path[MAX_PATH];
bytes_formated = strftime(filename, sizeof(filename), filename_format,
localtime(&current_time));
if (!bytes_formated) {
g_warning(
"filename_format: %s overflows filename limit - file cannot be saved",
filename_format);
return;
}
g_snprintf(path, MAX_PATH, "%s/%s", folder, filename);
g_info("saving surface to path: %s", path);
write_file(pixbuf, path);
}