changelog

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## [0.6.51]
+- Make commit and stash detail view update on changes (fixes #282)
+
 ## [0.6.50]
 - Show commit hash under cursor when checkout (@bzy-debug Bao Zhiyuan)
 - Fix vscode-insiders path for the remote environment (@ianic Igor Anić)

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "magit",
-  "version": "0.6.50",
+  "version": "0.6.51",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "magit",
-      "version": "0.6.50",
+      "version": "0.6.51",
       "license": "MIT",
       "dependencies": {
         "@vscode/iconv-lite-umd": "^0.7.0",

package.json

@@ -7,12 +7,13 @@
   "author": {
     "name": "Kristian Andersen Hole"
   },
-  "version": "0.6.50",
+  "version": "0.6.51",
   "engines": {
     "vscode": "^1.50.0"
   },
   "icon": "images/edamagit_logo.png",
   "categories": [
+    "SCM Providers",
     "Other"
   ],
   "keywords": [

src/views/blameView.ts

@@ -18,8 +18,6 @@ export class BlameView extends DocumentView {
     this.addSubview(blameTextView);
   }
 
-  public update(state: MagitRepository): void { }
-
   static index = 0;
   static encodeLocation(repository: MagitRepository, fileUri: Uri): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${BlameView.UriPath}/${fileUri.path}?${repository.uri.fsPath}#${fileUri.path}#${BlameView.index++}`);

src/views/commitDetailView.ts

@@ -12,7 +12,6 @@ export class CommitDetailView extends DocumentView {
 
   static UriPath: string = 'commit.magit';
   isHighlightable = false;
-  needsUpdate = false;
 
   constructor(uri: Uri, public commit: MagitCommit, header: string, diffChanges: MagitChange[]) {
     super(uri);
@@ -25,8 +24,6 @@ export class CommitDetailView extends DocumentView {
     this.addSubview(commitTextView);
   }
 
-  public update(state: MagitRepository): void { }
-
   static encodeLocation(repository: MagitRepository, commitHash: string): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${CommitDetailView.UriPath}?${repository.uri.fsPath}#${commitHash}`);
   }

src/views/diffView.ts

@@ -18,8 +18,6 @@ export class DiffView extends DocumentView {
     this.addSubview(diffTextView);
   }
 
-  public update(state: MagitRepository): void { }
-
   static index = 0;
   static encodeLocation(repository: MagitRepository, diffId: string): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${DiffView.UriPath}?${repository.uri.fsPath}#${diffId}${DiffView.index++}`);

src/views/general/documentView.ts

@@ -13,7 +13,9 @@ export abstract class DocumentView extends View {
     super();
   }
 
-  public abstract update(state: MagitRepository): void;
+  public update(state: MagitRepository): void {
+    this.triggerUpdate();
+  }
 
   public triggerUpdate() {
     if (this.emitter) {

src/views/helpView.ts

@@ -20,8 +20,6 @@ export class HelpView extends DocumentView {
     this.addSubview(diffTextView);
   }
 
-  public update(state: MagitRepository): void { }
-
   static encodeLocation(repository: MagitRepository): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${HelpView.UriPath}?${repository.uri.path}#help`);
   }

src/views/logView.ts

@@ -8,15 +8,13 @@ import GitTextUtils from '../utils/gitTextUtils';
 import { CommitItemView } from './commits/commitSectionView';
 import { DocumentView } from './general/documentView';
 import { TextView } from './general/textView';
-import { Token } from './general/semanticTextView';
-import { SemanticTokenTypes } from '../common/constants';
-import { Ref, RefType } from '../typings/git';
+import { Ref } from '../typings/git';
 import ViewUtils from '../utils/viewUtils';
-import { MagitRemote } from '../models/magitRemote';
 
 export default class LogView extends DocumentView {
 
   static UriPath: string = 'log.magit';
+  needsUpdate = false;
 
   constructor(uri: Uri, log: MagitLog, magitState: MagitRepository, defaultBranches?: { [remoteName: string]: string }) {
     super(uri);
@@ -28,8 +26,6 @@ export default class LogView extends DocumentView {
     ];
   }
 
-  public update(state: MagitRepository): void { }
-
   static index = 0;
   static encodeLocation(repository: MagitRepository): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${LogView.UriPath}?${repository.uri.fsPath}#${LogView.index++}`);

src/views/stashDetailView.ts

@@ -11,7 +11,6 @@ import { Stash } from '../models/stash';
 export class StashDetailView extends DocumentView {
 
   static UriPath: string = 'stash.magit';
-  needsUpdate = false;
 
   constructor(public uri: Uri, stash: Stash, diffChanges: MagitChange[], untrackedFiles: MagitChange[] ) {
     super(uri);
@@ -25,8 +24,6 @@ export class StashDetailView extends DocumentView {
     this.addSubview(new ChangeSectionView(Section.Changes, diffChanges, `-stashDetail@{${stash.index}}`));
   }
 
-  public update(state: MagitRepository): void { }
-
   static index = 0;
   static encodeLocation(repository: MagitRepository, stash: Stash): Uri {
     return Uri.parse(`${Constants.MagitUriScheme}:${StashDetailView.UriPath}?${repository.uri.fsPath}#stash@{${stash.index}}#${StashDetailView.index++}`);