kanaka/mal
1
1
Fork 0
mirror of https://github.com/kanaka/mal.git synced 2024-07-07 10:26:18 +03:00
Code Issues Projects Releases Wiki Activity

wasm: fix odd WASI readline behavior.

Browse Source 
Most of the time, the WASI fd_read call returns the whole line including
the newline. Other times, it returns everything except the newline. So
before stompiing the newline, check for that condition. This fixes the
WASI based wasm implementations (wasmtime, wasmer, lucet).
This commit is contained in:
Joel Martin 2021-12-20 12:17:19 -06:00
parent 58a6054e51
commit 1e8a122ddd
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
impls/wasm/platform_wasi.wam
View File

@ -49,7 +49,12 @@
(if (i32.le_s (i32.load $nread_ptr) 0)
(return 0))
;; Replace ending newline with NULL
(i32.store8 (i32.add $buf (i32.sub (i32.load $nread_ptr) 1)) 0)
;; NOTE: oddly, there isn't always a newline so check first
;; Specifically, this input chops too much:
;; (abcd abcdefg (abc (n) (if (> n 0) (+ n (abcdefg (- n 1))) 0)))
(if (i32.eq (CHR "\n")
(i32.load8_u (i32.add $buf (i32.sub (i32.load $nread_ptr) 1)) 0))
(i32.store8 (i32.add $buf (i32.sub (i32.load $nread_ptr) 1)) 0))
1
)