From 31ef021712bf18a90609822cfcb7c327ab2e60f0 Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Tue, 14 May 2019 23:33:44 +0100 Subject: [PATCH 1/5] python: Correct spelling in a test comment. --- python/tests/stepA_mal.mal | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/tests/stepA_mal.mal b/python/tests/stepA_mal.mal index 79851922..44669f85 100644 --- a/python/tests/stepA_mal.mal +++ b/python/tests/stepA_mal.mal @@ -1,6 +1,6 @@ ;; Testing Python interop -;; Testing Python experesions +;; Testing Python expressions (py* "7") ;=>7 (py* "'7'") From 69990448a0f11f9e7a390e848a3b9867203411b9 Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Sun, 19 May 2019 12:22:36 +0100 Subject: [PATCH 2/5] README: Escape asterisks in "SQL*Plus". --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 66ebee3e..4511c6e4 100644 --- a/README.md +++ b/README.md @@ -807,10 +807,10 @@ The PL/pgSQL implementation of mal requires a running Oracle DB server (the "kanaka/mal-test-plsql" docker image automatically starts an Oracle Express server). The implementation connects to the Oracle server to create types, tables and stored procedures. The -default SQL*Plus logon value (username/password@connect_identifier) is +default SQL\*Plus logon value (username/password@connect_identifier) is "system/oracle" but this can be overridden with the ORACLE_LOGON environment variable. The implementation has been tested with Oracle -Express Edition 11g Release 2. Note that any SQL*Plus connection +Express Edition 11g Release 2. Note that any SQL\*Plus connection warnings (user password expiration, etc) will interfere with the ability of the wrapper script to communicate with the DB. From e007416e0c059bf2a398020fe0a544ee9852801a Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Sun, 19 May 2019 12:26:35 +0100 Subject: [PATCH 3/5] README: Correct capitalisation of "PostScript" and "Ghostscript". --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 4511c6e4..a2aaf1c5 100644 --- a/README.md +++ b/README.md @@ -821,10 +821,10 @@ cd plsql ORACLE_LOGON=myuser/mypass@ORCL ./wrap.sh stepX_YYY.sql ``` -### Postscript Level 2/3 +### PostScript Level 2/3 -The Postscript implementation of mal requires ghostscript to run. It -has been tested with ghostscript 9.10. +The PostScript implementation of mal requires Ghostscript to run. It +has been tested with Ghostscript 9.10. ``` cd ps From 26460a25ff67999e67d584f5c249109ec3a3b372 Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Sun, 19 May 2019 12:27:25 +0100 Subject: [PATCH 4/5] README: Correct a stray mention of PL/pgSQL in the PL/SQL section. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index a2aaf1c5..5f438962 100644 --- a/README.md +++ b/README.md @@ -803,7 +803,7 @@ PSQL_USER=myuser PGPASSWORD=mypass ./wrap.sh stepX_YYY.sql ### PL/SQL (Oracle SQL Procedural Language) -The PL/pgSQL implementation of mal requires a running Oracle DB +The PL/SQL implementation of mal requires a running Oracle DB server (the "kanaka/mal-test-plsql" docker image automatically starts an Oracle Express server). The implementation connects to the Oracle server to create types, tables and stored procedures. The From 33102dd1b4c6805fb0010e1a11957c60525d9c01 Mon Sep 17 00:00:00 2001 From: Ben Harris Date: Sun, 19 May 2019 12:33:52 +0100 Subject: [PATCH 5/5] README: Pedantically refer to PostgreSQL by its proper name. --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 5f438962..66eab5cd 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ | [Perl 6](#perl-6) | [Hinrik Örn Sigurðsson](https://github.com/hinrik) | | [PHP](#php-53) | [Joel Martin](https://github.com/kanaka) | | [Picolisp](#picolisp) | [Vasilij Schneidermann](https://github.com/wasamasa) | -| [PL/pgSQL](#plpgsql-postgres-sql-procedural-language) (Postgres) | [Joel Martin](https://github.com/kanaka) | +| [PL/pgSQL](#plpgsql-postgresql-sql-procedural-language) (PostgreSQL) | [Joel Martin](https://github.com/kanaka) | | [PL/SQL](#plsql-oracle-sql-procedural-language) (Oracle) | [Joel Martin](https://github.com/kanaka) | | [PostScript](#postscript-level-23) | [Joel Martin](https://github.com/kanaka) | | [PowerShell](#powershell) | [Joel Martin](https://github.com/kanaka) | @@ -782,17 +782,17 @@ cd picolisp ./run ``` -### PL/pgSQL (Postgres SQL Procedural Language) +### PL/pgSQL (PostgreSQL SQL Procedural Language) -The PL/pgSQL implementation of mal requires a running Postgres server +The PL/pgSQL implementation of mal requires a running PostgreSQL server (the "kanaka/mal-test-plpgsql" docker image automatically starts -a Postgres server). The implementation connects to the Postgres server +a PostgreSQL server). The implementation connects to the PostgreSQL server and create a database named "mal" to store tables and stored procedures. The wrapper script uses the psql command to connect to the server and defaults to the user "postgres" but this can be overridden with the PSQL_USER environment variable. A password can be specified using the PGPASSWORD environment variable. The implementation has been -tested with Postgres 9.4. +tested with PostgreSQL 9.4. ``` cd plpgsql