The bullet point for `with-meta` describes how to implement it for Mal functions, but it's applicable to all Mal types, while the last sentence can be reordered to emphasize the details specific to metadata on functions.
This isn't a perfect solution because if somebody pushes a new
implementation and then later pushes the updates to these files, it
probably won't trigger any implementations. However, the workflow can
always be manually triggered for a specific implementation and branch so
that's probably okay. At least this way, the addition of a new
implementation won't always trigger every other implementation to be
tested.
Use raw or multiline string litterals to make some hard-coded strings
more readable.
Replace some lambda constructs with more idiomatic generator
expressions, removing several temporary sequences (conversions,
contatenations, slices, arguments).
Replace definitions with assignments when possible.
Replace most python2/3 wrappers with code compatible with both
versions. Use a non-printable ASCII characters instead of Unicode
characters (in order to avoid unicode in python2).
core:
Close file open by 'slurp' after reading.
coll_Q: remove as obsolete.
conj: do not preserve metadata.
env:
Replace find with an optional argument to get.
Search in outer environments with a loop instead of a recursion.
(python is not intended for large recursions).
readline:
Copy the example from the docs.
Write the history once.
mal_types:
clone: copy.copy() everything except callables.
functions: construct fn* functions in steps, where they are used
(there was no encapsulation anyway)
Derive List and Vector from tuple, which is more efficient than list
for immutable structures. Remove the need for __getitem__ stuff.
maps: provide an asPairs iterator.
printer:
Introduce a pr_list helper like many other implementations.
steps:
Remove obviously backported stuff from first steps.
Port forward the limitation of the exception backtrace size from step5
to later steps, so that REGRESS=1 does not crash stepA tests.
Fix the detection of special forms (strings were accepted as well as
symbols).
Let try* benefit from TCO.
Readability
* Use implicit parameter transmission ($(_list?) instead of $(call
_list?,$1),
first/lastword instead of word 1/words,
$1 instead of $(1).
* Use an undefined $(rem) macro and some automatic stripping (if,
foreach) to indent code with less calls to `strip` functions.
* Name the Make macro implementing a MAL core function exactly like the
function (modulo the encoding above) and simplify core_ns accordingly.
* Replace empty results representing `nil` with explicit MAL values.
* Implement large conditionals with a computed variable name, as already
done in printer.mk. For QUASIQUOTE and EVAL, this reduces a lot the
diff between steps.
* Represent the reader state as an explicit global variable instead of
passing the same name as argument again and again.
* Merge read-atom into read-form so that the switch on first character
is more visible.
Encapsulation
* Hide most representations into types.mk.
* Implement the type as a suffix in order to avoid a conditional in
_obj_type.
* Implement _error with throw.
* Create distinct types for keywords and macros.
* Move most metadata and atom stuff from core.mk to types.mk.
* Move parameter association from env to types because it hides more
about the representation of functions.
Representation
* Encode Make special characters in all strings/keywords/symbols, so
they can be used directly as spaced words and/or variable names for
map keys. (The encoding adding separating characters is kept for
read-string and seq).
* Change representation of numbers/strings/keywords/symbols, reducing
the number of Make variables.
Various
* Allow keyword argument for keyword core function.
* Shorten time-mes,slurp,readline...
* Remove obsolete stuff:
* `get` and `contains?` for vectors
* `count` for hash-maps
* `_join` from util.mk.
* `type` from core.mk.
* Add a function listing env_keys for DEBUG-EVAL.
* Fix some includes.
This improves readability because the return value was only a trick to
shorten `def!` and `defmacro!` and was ignored everywhere else.
As a side effect, this probably improves efficiency, as `let*` is the
most frequent caller.
Remove unneeded intermediate executable files.
Remove Cargo.lock from version control system.
Update dependency versions.
Update Dockerfile (converge to update-some-dockerfiles branch).
Apply changes suggested by rustfmt and clippy, or enforced by rustc.
Remove several unneeded clone().
Merge eval and eval-ast, remove quasiquoteexpand and macroexpand.
Report more errors during startup.
The package-lock.json file is intended to be checked in to source
control in order to make builds reproducible; without
a package-lock.json file `npm install` becomes non-deterministic.
See e.g.
https://docs.npmjs.com/cli/v8/configuring-npm/package-lock-json:
> package-lock.json is automatically generated for any operations where
> npm modifies either the node_modules tree, or package.json. It describes
> the exact tree that was generated, such that subsequent installs are
> able to generate identical trees, regardless of intermediate dependency
> updates.
>
> This file is intended to be committed into source repositories, and
> serves various purposes:
The update from ubuntu:vivid to ubuntu:20.04 update the version of sbcl
from 1.2.4.debian to 2.0.1.debian. This resulted in the cl-launch based
build process no longer working: dependencies were not resolved (but
running it several times would eventually resolve them. So use an sbcl
build command directly when building for sbcl.
Note: updating the image to ubuntu:24.04 upgrades the version of sbcl to
2.2.9.debian. Something about that version breaks how we do hash-maps.
They become temperamental: hash-map creation often results in a nil
object returned and doing (get hm key) usually results in nil returned
even if the key shows as being present.
Various trivial changes reducing the diff to #450.
Dockerfile: npm already depends on nodejs
Core.elm: change profile of deepEquals instead of uncurrying before
each call.
It was necessary to rename some ambiguous variables. Some more names
could probably be changed in order to reduce the diff with #450 (my
names were choosen in order to reduce the diff with master...)
Peek ideas from #450:
- sort imports
- skip a line between '->' or before 'else'
- no indentation after 'in'
- fix indentation when it was only intended to reduce diff
- remove some unneeded parenthesis
and
- if .. return True else False -> ...
