kiteco/vscode-plugin
1
1
Fork 0
mirror of https://github.com/kiteco/vscode-plugin.git synced 2024-08-17 20:00:43 +03:00
Code Issues Projects Releases Wiki Activity

Clear Decoration on Disable (#379)

Browse Source 
* fix: always clear decoration when not enabled

* fix: enableLineDecoration test
This commit is contained in:
tonycheang 2021-02-17 12:26:13 -08:00 committed by GitHub
parent 1aae18715b
commit 954ae979fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/codenav-decoration.ts
View File

@ -19,7 +19,7 @@ import {
import * as KiteAPI from "kite-api";
const relatedCodeLineDecoration: TextEditorDecorationType = window.createTextEditorDecorationType({
export const relatedCodeLineDecoration: TextEditorDecorationType = window.createTextEditorDecorationType({
rangeBehavior: DecorationRangeBehavior.ClosedOpen,
});
@ -58,6 +58,7 @@ export default class KiteRelatedCodeDecorationsProvider {
// Public for testing
public async onDidChangeTextEditorSelection(event: TextEditorSelectionChangeEvent): Promise<void> {
if (!this.enabled()) {
this.clearDecorations(event.textEditor)
return;
}

4
test/codenav-decoration.test.ts
View File

@ -14,7 +14,7 @@ import { assert } from 'chai';
import * as sinon from 'sinon';
import * as KiteAPI from 'kite-api';
import KiteRelatedCodeDecorationsProvider from '../src/codenav-decoration';
import KiteRelatedCodeDecorationsProvider, { relatedCodeLineDecoration } from '../src/codenav-decoration';
describe('KiteRelatedCodeDecorationsProvider', () => {
@ -66,7 +66,7 @@ describe('KiteRelatedCodeDecorationsProvider', () => {
await fireEvent();
assert.isFalse(getLineDecorationStub.called);
assert.isFalse(setDecorationSpy.called);
assert.isTrue(setDecorationSpy.calledWith(relatedCodeLineDecoration, []), "clears the decoration when disabled");
getConfigurationStub.restore();
});