kovidgoyal/kitty
1
1
Fork 0
mirror of https://github.com/kovidgoyal/kitty.git synced 2024-09-19 18:47:26 +03:00
Code Issues Projects Releases Wiki Activity

Images benchmark should not measure speed of zlib

Browse Source
This commit is contained in:
Kovid Goyal 2023-11-13 22:49:20 +05:30
parent 3d0a90e63d
commit 93430cd5f4
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/cmd/benchmark/main.go
View File

@ -170,14 +170,18 @@ func images() (r result, err error) {
g := graphics.GraphicsCommand{}
g.SetImageId(12345)
g.SetQuiet(graphics.GRT_quiet_silent)
g.SetAction(graphics.GRT_action_query)
g.SetAction(graphics.GRT_action_transmit)
g.SetFormat(graphics.GRT_format_rgba)
const dim = 2048
const dim = 1024
g.SetDataWidth(dim)
g.SetDataHeight(dim)
g.DisableCompression = true // dont want to measure the speed of zlib
b := strings.Builder{}
b.Grow(4*dim*dim + 256)
b.Grow(8 * dim * dim)
_ = g.WriteWithPayloadTo(&b, make([]byte, 4*dim*dim))
g.SetAction(graphics.GRT_action_delete)
g.SetDelete(graphics.GRT_free_by_id)
_ = g.WriteWithPayloadTo(&b, nil)
data := b.String()
duration, data_sz, err := benchmark_data(data, default_benchmark_options())
if err != nil {
@ -277,7 +281,7 @@ func main(args []string) (err error) {
fmt.Print(reset)
fmt.Println(
"These results measure the time it takes the terminal to fully parse all the data sent to it. Some terminals will not render all the data, skipping frames, thereby \"cheating\" in their results. kitty does render all data.")
"These results measure the time it takes the terminal to fully parse all the data sent to it. Note that not all data transmitted will be displayed as input parsing is typically asynchronous with rendering in high performance terminals.")
fmt.Println()
fmt.Println("Results:")
mlen := 10

3
tools/tui/graphics/command.go
View File

@ -145,6 +145,7 @@ type GraphicsCommand struct {
z int32
DisableCompression bool
WrapPrefix, WrapSuffix string
EncodeSerializedDataFunc func(string) string
@ -271,7 +272,7 @@ func (self *GraphicsCommand) WriteWithPayloadTo(o io.StringWriter, payload []byt
return self.serialize_to(o, base64.RawStdEncoding.EncodeToString(payload))
}
gc := *self
if self.Format() != GRT_format_png {
if !self.DisableCompression && self.Format() != GRT_format_png {
compressed := compress_with_zlib(payload)
if len(compressed) < len(payload) {
gc.SetCompression(GRT_compression_zlib)