From ea37799fb04c755e2d2b5d0c3be2c9ad47e42281 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sun, 6 Jan 2019 10:25:37 +0530 Subject: [PATCH] Fix linking happening even when not needed --- setup.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index cd8cac9bf..b1440601a 100755 --- a/setup.py +++ b/setup.py @@ -394,7 +394,8 @@ def compile_c_extension(kenv, module, incremental, compilation_database, all_key if todo: parallel_run(todo) dest = os.path.join(base, module + '.temp.so') - if not incremental or newer(dest, *objects): + real_dest = dest[:-len('.temp.so')] + '.so' + if not incremental or newer(real_dest, *objects): # Old versions of clang don't like -pthread being passed to the linker # Don't treat linker warnings as errors (linker generates spurious # warnings on some old systems) @@ -408,7 +409,7 @@ def compile_c_extension(kenv, module, incremental, compilation_database, all_key except EnvironmentError: pass else: - os.rename(dest, dest[:-len('.temp.so')] + '.so') + os.rename(dest, real_dest) def find_c_files():