This commit is contained in:
Kovid Goyal 2022-09-21 23:52:33 +05:30
parent c07dc220a8
commit ff4353b209
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 5 additions and 4 deletions

View File

@ -203,13 +203,13 @@ def __init__(
self, argv=None, rows=25, columns=80, scrollback=100, cell_width=10, cell_height=20,
cwd=None, env=None, stdin_fd=None, stdout_fd=None
):
self.is_child = False
if isinstance(argv, str):
argv = shlex.split(argv)
self.write_buf = b''
if argv is None:
from kitty.child import openpty
self.master_fd, self.slave_fd = openpty()
self.is_child = False
else:
self.child_pid, self.master_fd = fork()
self.is_child = self.child_pid == CHILD
@ -249,11 +249,12 @@ def is_echo_on(self):
def __del__(self):
if not self.is_child:
os.close(self.master_fd)
if hasattr(self, 'master_fd'):
os.close(self.master_fd)
del self.master_fd
if hasattr(self, 'slave_fd'):
os.close(self.slave_fd)
del self.slave_fd
del self.master_fd
def write_to_child(self, data, flush=False):
if isinstance(data, str):

View File

@ -155,7 +155,7 @@ def run_go(packages: Set[str], names: str) -> 'subprocess.Popen[bytes]':
def reduce_go_pkgs(module: str, names: Sequence[str]) -> Set[str]:
if not go_exe():
print('Skipping Go tests as go exe not found', file=sys.stderr)
return
return set()
go_packages, go_functions = find_testable_go_packages()
if module:
go_packages &= {module}