mirror of
https://github.com/lensapp/lens.git
synced 2024-09-20 13:57:23 +03:00
Use extension's app preference tab name when available (#5798)
Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
parent
d44599af00
commit
07c5de6e8e
@ -173,7 +173,7 @@ exports[`preferences - navigation to extension specific preferences given in pre
|
||||
id="extensions"
|
||||
>
|
||||
<h2>
|
||||
registered-tab-page-id
|
||||
Metrics tab
|
||||
|
||||
preferences
|
||||
</h2>
|
||||
@ -473,7 +473,7 @@ exports[`preferences - navigation to extension specific preferences given in pre
|
||||
id="extensions"
|
||||
>
|
||||
<h2>
|
||||
registered-tab-page-id
|
||||
Metrics tab
|
||||
|
||||
preferences
|
||||
</h2>
|
||||
@ -773,7 +773,7 @@ exports[`preferences - navigation to extension specific preferences given in pre
|
||||
id="extensions"
|
||||
>
|
||||
<h2>
|
||||
duplicated-tab-page-id
|
||||
Metrics tab
|
||||
|
||||
preferences
|
||||
</h2>
|
||||
@ -3264,7 +3264,7 @@ exports[`preferences - navigation to extension specific preferences when navigat
|
||||
id="extensions"
|
||||
>
|
||||
<h2>
|
||||
duplicated-tab-page-id
|
||||
Metrics tab
|
||||
|
||||
preferences
|
||||
</h2>
|
||||
|
@ -16,13 +16,14 @@ const extensionPreferencesModelInjectable = getInjectable({
|
||||
const route = di.inject(extensionPreferencesRouteInjectable);
|
||||
const pathParameters = di.inject(routePathParametersInjectable, route);
|
||||
const extensions = di.inject(rendererExtensionsInjectable);
|
||||
|
||||
|
||||
return computed(() => {
|
||||
const { extensionId, tabId } = pathParameters.get();
|
||||
const targetExtension = extensions.get().find((extension) => extension.sanitizedExtensionId === extensionId);
|
||||
|
||||
const targetAppTab = targetExtension?.appPreferenceTabs.find(tab => tab.id === tabId);
|
||||
|
||||
return {
|
||||
extensionName: targetExtension?.manifest.name,
|
||||
extensionName: targetAppTab?.title ?? targetExtension?.manifest.name,
|
||||
preferenceItems: getExtensionPreferenceItems(targetExtension, tabId),
|
||||
};
|
||||
});
|
||||
|
Loading…
Reference in New Issue
Block a user