From 323b3759fc2e204660d961f1f97b6a553f38356e Mon Sep 17 00:00:00 2001 From: Gabriel Date: Thu, 1 Jun 2023 22:36:49 +0200 Subject: [PATCH] chore: resolve comments Signed-off-by: Gabriel --- open-lens/src/main/index.ts | 2 -- package-lock.json | 10 +++++----- .../core/src/extensions/renderer-api/components.ts | 2 +- packages/ui-components/notifications/index.ts | 2 +- 4 files changed, 7 insertions(+), 9 deletions(-) diff --git a/open-lens/src/main/index.ts b/open-lens/src/main/index.ts index 631bec505f..8a90aaca46 100644 --- a/open-lens/src/main/index.ts +++ b/open-lens/src/main/index.ts @@ -15,7 +15,6 @@ import { loggerFeature } from "@k8slens/logger"; import { randomFeature } from "@k8slens/random"; import { kubeApiSpecificsFeature } from "@k8slens/kube-api-specifics"; import { prometheusFeature } from "@k8slens/prometheus"; -import { notificationsFeature } from "@k8slens/notifications"; const environment = "main"; @@ -37,7 +36,6 @@ runInAction(() => { messagingFeatureForMain, randomFeature, kubeApiSpecificsFeature, - notificationsFeature, ); try { diff --git a/package-lock.json b/package-lock.json index 5062762ffd..552593e91c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -3831,14 +3831,14 @@ "resolved": "packages/node-fetch", "link": true }, - "node_modules/@k8slens/prometheus": { - "resolved": "packages/technical-features/prometheus", - "link": true - }, "node_modules/@k8slens/notifications": { "resolved": "packages/ui-components/notifications", "link": true }, + "node_modules/@k8slens/prometheus": { + "resolved": "packages/technical-features/prometheus", + "link": true + }, "node_modules/@k8slens/random": { "resolved": "packages/random-id", "link": true @@ -34344,8 +34344,8 @@ "@k8slens/messaging-for-renderer": "^1.0.0-alpha.1", "@k8slens/metrics": "^6.5.0-alpha.7", "@k8slens/node-fetch": "^6.5.0-alpha.3", - "@k8slens/prometheus": "^1.0.0", "@k8slens/notifications": "^1.0.0", + "@k8slens/prometheus": "^1.0.0", "@k8slens/random": "^1.0.0", "@k8slens/react-application": "^1.0.0-alpha.5", "@k8slens/resizing-anchor": "^1.0.0-alpha.5", diff --git a/packages/core/src/extensions/renderer-api/components.ts b/packages/core/src/extensions/renderer-api/components.ts index 1ab3e6295d..91c5e98560 100644 --- a/packages/core/src/extensions/renderer-api/components.ts +++ b/packages/core/src/extensions/renderer-api/components.ts @@ -75,7 +75,7 @@ export * from "../../renderer/components/line-progress"; export * from "../../renderer/components/menu"; export { - type NotificationStatus, + NotificationStatus, type CreateNotificationOptions, type Notification, type NotificationId, diff --git a/packages/ui-components/notifications/index.ts b/packages/ui-components/notifications/index.ts index cdcb1da93f..7a4fb7c7d3 100644 --- a/packages/ui-components/notifications/index.ts +++ b/packages/ui-components/notifications/index.ts @@ -6,11 +6,11 @@ export type { NotificationId, NotificationMessage, - NotificationStatus, CreateNotificationOptions, Notification, NotificationsStore, } from "./src/notifications.store"; +export { NotificationStatus } from "./src/notifications.store"; export type { ShowNotification } from "./src/notifications"; export { Notifications } from "./src/notifications"; export { notificationsClusterFrameChildComponentInjectable } from "./src/notifications-cluster-frame-child-component.injectable";