lensapp/lens
1
0
Fork 0
mirror of https://github.com/lensapp/lens.git synced 2024-09-21 06:17:36 +03:00
Code Issues Projects Releases Wiki Activity

fix Notifications blocking items not visually under them from being interacted with (#915)

Browse Source 
* fix Notifications blocking items not visually under them from being interacted with

Signed-off-by: Sebastian Malton <sebastian@malton.name>
This commit is contained in:
Sebastian Malton 2020-09-21 14:47:44 -04:00 committed by GitHub
parent 78ab6f016b
commit 9a10db837e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/renderer/components/dock/info-panel.tsx
View File

@ -62,14 +62,13 @@ export class InfoPanel extends Component<Props> {
this.error = "";
this.waiting = true;
try {
this.result = await this.props.submit().finally(() => {
this.waiting = false;
});
this.result = await this.props.submit()
if (showNotifications) Notifications.ok(this.result);
} catch (error) {
this.error = error.toString();
if (showNotifications) Notifications.error(this.error);
throw error;
} finally {
this.waiting = false
}
}
@ -91,12 +90,13 @@ export class InfoPanel extends Component<Props> {
<>
{result && (
<div className="success flex align-center">
<Icon material="done"/> <span>{result}</span>
<Icon material="done" />
<span>{result}</span>
</div>
)}
{errorInfo && (
<div className="error flex align-center">
<Icon material="error_outline"/>
<Icon material="error_outline" />
<span>{errorInfo}</span>
</div>
)}
@ -114,9 +114,9 @@ export class InfoPanel extends Component<Props> {
{controls}
</div>
<div className="info flex gaps align-center">
{waiting ? <><Spinner/> {submittingMessage}</> : this.renderInfo()}
{waiting ? <><Spinner /> {submittingMessage}</> : this.renderInfo()}
</div>
<Button plain label={<Trans>Cancel</Trans>} onClick={close}/>
<Button plain label={<Trans>Cancel</Trans>} onClick={close} />
<Button
primary active
label={submitLabel}
@ -134,4 +134,4 @@ export class InfoPanel extends Component<Props> {
</div>
);
}
}
}

5
src/renderer/components/notifications/notifications.scss
View File

@ -3,10 +3,11 @@
position: absolute;
right: 0;
bottom: 0;
top: 0;
padding: $padding * 2;
max-height: 100vh;
z-index: 100000;
height: min-content!important;
&:empty {
display: none;
@ -42,4 +43,4 @@
}
}
}
}
}