diff --git a/package-lock.json b/package-lock.json index 95d6bebb81..150ae619f2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -34313,6 +34313,7 @@ "peerDependencies": { "@hapi/call": "^9.0.1", "@hapi/subtext": "^7.1.0", + "@k8slens/animate": "^1.0.0-alpha.0", "@k8slens/application": "^6.5.0-alpha.0", "@k8slens/application-for-electron-main": "^6.5.0-alpha.0", "@k8slens/button": "^1.0.0-alpha.5", @@ -35527,7 +35528,7 @@ }, "packages/ui-components/animate": { "name": "@k8slens/animate", - "version": "1.0.0", + "version": "1.0.0-alpha.0", "license": "MIT", "devDependencies": { "@k8slens/eslint-config": "^6.5.0", @@ -35536,9 +35537,9 @@ "peerDependencies": { "@k8slens/feature-core": "^6.5.0-alpha.0", "@k8slens/utilities": "^1.0.0-alpha.1", - "@ogre-tools/injectable": "^16.1.0", - "@ogre-tools/injectable-extension-for-auto-registration": "^16.1.0", - "@ogre-tools/injectable-react": "^16.1.0", + "@ogre-tools/injectable": "^17.1.0", + "@ogre-tools/injectable-extension-for-auto-registration": "^17.1.0", + "@ogre-tools/injectable-react": "^17.1.0", "react": "^17.0.2" } }, diff --git a/packages/core/package.json b/packages/core/package.json index 6b1563576e..becbf86a71 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -206,6 +206,7 @@ "peerDependencies": { "@hapi/call": "^9.0.1", "@hapi/subtext": "^7.1.0", + "@k8slens/animate": "^1.0.0-alpha.0", "@k8slens/application": "^6.5.0-alpha.0", "@k8slens/application-for-electron-main": "^6.5.0-alpha.0", "@k8slens/button": "^1.0.0-alpha.5", diff --git a/packages/core/src/renderer/components/dialog/dialog.tsx b/packages/core/src/renderer/components/dialog/dialog.tsx index 14124f593a..c391f20edf 100644 --- a/packages/core/src/renderer/components/dialog/dialog.tsx +++ b/packages/core/src/renderer/components/dialog/dialog.tsx @@ -9,13 +9,12 @@ import React from "react"; import { createPortal } from "react-dom"; import { disposeOnUnmount, observer } from "mobx-react"; import { reaction } from "mobx"; -import { Animate } from "@k8slens/animate"; +import { Animate, requestAnimationFrameInjectable } from "@k8slens/animate"; import type { StrictReactNode } from "@k8slens/utilities"; import { cssNames, noop, stopPropagation } from "@k8slens/utilities"; import type { ObservableHistory } from "mobx-observable-history"; import { withInjectables } from "@ogre-tools/injectable-react"; import { observableHistoryInjectionToken } from "@k8slens/routing"; -import { requestAnimationFrameInjectable } from "@k8slens/animate"; // todo: refactor + handle animation-end in props.onClose()? diff --git a/packages/core/src/renderer/getDiForUnitTesting.tsx b/packages/core/src/renderer/getDiForUnitTesting.tsx index 26437c1047..0feb093a79 100644 --- a/packages/core/src/renderer/getDiForUnitTesting.tsx +++ b/packages/core/src/renderer/getDiForUnitTesting.tsx @@ -9,7 +9,7 @@ import { getOverrideFsWithFakes } from "../test-utils/override-fs-with-fakes"; import terminalSpawningPoolInjectable from "./components/dock/terminal/terminal-spawning-pool.injectable"; import hostedClusterIdInjectable from "./cluster-frame-context/hosted-cluster-id.injectable"; import { runInAction } from "mobx"; -import { requestAnimationFrameInjectable } from "@k8slens/animate"; +import { animateFeature, requestAnimationFrameInjectable } from "@k8slens/animate"; import startTopbarStateSyncInjectable from "./components/layout/top-bar/start-state-sync.injectable"; import watchHistoryStateInjectable from "./remote-helpers/watch-history-state.injectable"; import legacyOnChannelListenInjectable from "./ipc/legacy-channel-listen.injectable"; @@ -21,7 +21,6 @@ import { registerFeature } from "@k8slens/feature-core"; import { messagingFeature, testUtils as messagingTestUtils } from "@k8slens/messaging"; import { routingFeature } from "@k8slens/routing"; import { loggerFeature } from "@k8slens/logger"; -import { animateFeature } from "@k8slens/animate"; export const getDiForUnitTesting = () => { const environment = "renderer"; diff --git a/packages/infrastructure/eslint-config/eslint-config.js b/packages/infrastructure/eslint-config/eslint-config.js index 14781a9690..f69f91f46a 100644 --- a/packages/infrastructure/eslint-config/eslint-config.js +++ b/packages/infrastructure/eslint-config/eslint-config.js @@ -160,7 +160,7 @@ module.exports = { // React specific rules "react-hooks/rules-of-hooks": "error", - "react-hooks/exhaustive-deps": "warn", + "react-hooks/exhaustive-deps": "off", "react/require-default-props": "off", "react/function-component-definition": "off", "react/prop-types": "off", diff --git a/packages/ui-components/animate/package.json b/packages/ui-components/animate/package.json index edf020bd6d..10b038cbef 100644 --- a/packages/ui-components/animate/package.json +++ b/packages/ui-components/animate/package.json @@ -1,7 +1,7 @@ { "name": "@k8slens/animate", "private": false, - "version": "1.0.0", + "version": "1.0.0-alpha.0", "description": "Highly extendable animate in the Lens.", "type": "commonjs", "files": [ @@ -35,9 +35,9 @@ "peerDependencies": { "@k8slens/feature-core": "^6.5.0-alpha.0", "@k8slens/utilities": "^1.0.0-alpha.1", - "@ogre-tools/injectable-react": "^16.1.0", - "@ogre-tools/injectable": "^16.1.0", - "@ogre-tools/injectable-extension-for-auto-registration": "^16.1.0", + "@ogre-tools/injectable-react": "^17.1.0", + "@ogre-tools/injectable": "^17.1.0", + "@ogre-tools/injectable-extension-for-auto-registration": "^17.1.0", "react": "^17.0.2" }, "devDependencies": { diff --git a/packages/ui-components/icon/src/icon.test.tsx b/packages/ui-components/icon/src/icon.test.tsx index 9ec30a780f..d15133cd8b 100644 --- a/packages/ui-components/icon/src/icon.test.tsx +++ b/packages/ui-components/icon/src/icon.test.tsx @@ -30,9 +30,7 @@ describe(" href technical tests", () => { setLegacyGlobalDiForExtensionApi(di, environment); runInAction(() => { - registerFeature(di, - loggerFeature, - ); + registerFeature(di, loggerFeature); }); logger = {