git.iko.soy/maciek134/podphoenix
on main help sign in
removed unnecessary bindings from empty state
commit39bf49fb3f84c6608225b40a767ff3ca912aa95a authorNekhelesh Ramananthan <krnekhelesh@gmail.com> dateWed 24 Feb 2016, 21:47 (11 years ago) parentf5d0afb
6 files changed+35−47
compare with main
unifiedsplit
app/components/EmptyState.qml+3−7 app/ui/EpisodesPage.qml+1−3 app/ui/PodcastsTab.qml+1−3 app/ui/SearchPage.qml+1−3 app/ui/WhatsNewTab.qml+1−3 po/com.mikeasoft.podbird.pot+28−28
app/components/EmptyState.qml+3−7
@@ -28,20 +28,16 @@ Item {
2828 id: emptyState
2929
3030 // Public APIs
31− property alias iconName: emptyIcon.name
31+ property alias icon: emptyIcon
3232 property alias title: emptyLabel.text
3333 property alias subTitle: emptySublabel.text
34− property alias iconSource: emptyIcon.source
35−
36− property real iconHeight: units.gu(10)
37− property real iconWidth: units.gu(10)
3834
3935 height: childrenRect.height
4036
4137 Icon {
4238 id: emptyIcon
43− width: parent.iconWidth
44− height: parent.iconHeight
39+ width: units.gu(22)
40+ height: units.gu(12)
4541 color: podbird.appTheme.baseIcon
4642 anchors.horizontalCenter: parent.horizontalCenter
4743 }
app/ui/EpisodesPage.qml+1−3
@@ -263,9 +263,7 @@ Page {
263263 Component {
264264 id: emptyStateComponent
265265 EmptyState {
266− iconHeight: units.gu(12)
267− iconWidth: units.gu(22)
268− iconSource: Qt.resolvedUrl("../graphics/notFound.svg")
266+ icon.source: Qt.resolvedUrl("../graphics/notFound.svg")
269267 title: i18n.tr("No episodes found")
270268 subTitle: i18n.tr("No episodes found matching the search term.")
271269 }
app/ui/PodcastsTab.qml+1−3
@@ -139,9 +139,7 @@ Page {
139139 Component {
140140 id: emptyStateComponent
141141 EmptyState {
142− iconHeight: units.gu(12)
143− iconWidth: units.gu(22)
144− iconSource: podcastModel.count === 0 ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
142+ icon.source: podcastModel.count === 0 ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
145143 title: podcastModel.count === 0 ? i18n.tr("No Podcast Subscriptions") : i18n.tr("No Podcasts Found")
146144 subTitle: podcastModel.count === 0 ? i18n.tr("You haven't subscribed to any podcasts yet, visit the 'Find New Podcasts' page to add some.")
147145 : i18n.tr("No podcasts found matching the search term.")
app/ui/SearchPage.qml+1−3
@@ -205,9 +205,7 @@ Page {
205205 Component {
206206 id: emptyStateComponent
207207 EmptyState {
208− iconHeight: units.gu(12)
209− iconWidth: units.gu(22)
210− iconSource: searchPage.header !== searchHeader ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
208+ icon.source: searchPage.header !== searchHeader ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
211209 title: searchPage.header !== searchHeader ? i18n.tr("Looking to add a new Podcast?") : i18n.tr("No Podcasts found")
212210 subTitle: searchPage.header !== searchHeader ? i18n.tr("Click the 'magnifier' at the top to search or the 'plus' button to add by URL")
213211 : i18n.tr("No podcasts found matching the search term.")
app/ui/WhatsNewTab.qml+1−3
@@ -135,9 +135,7 @@ Tab {
135135 Component {
136136 id: emptyStateComponent
137137 EmptyState {
138− iconHeight: units.gu(12)
139− iconWidth: units.gu(22)
140− iconSource: whatsNewModel.count === 0 ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
138+ icon.source: whatsNewModel.count === 0 ? Qt.resolvedUrl("../graphics/owlSearch.svg") : Qt.resolvedUrl("../graphics/notFound.svg")
141139 title: whatsNewModel.count === 0 ? i18n.tr("No New Episodes") : i18n.tr("No Episodes Found")
142140 subTitle: whatsNewModel.count === 0 ? i18n.tr("No more episodes to listen to!") : i18n.tr("No Episodes found matching the search term.")
143141 }
po/com.mikeasoft.podbird.pot+28−28
@@ -8,7 +8,7 @@ msgid ""
88msgstr ""
99"Project-Id-Version: \n"
1010"Report-Msgid-Bugs-To: \n"
11−"POT-Creation-Date: 2016-02-24 21:37+0530\n"
11+"POT-Creation-Date: 2016-02-25 02:15+0530\n"
1212"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
1313"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
1414"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -143,7 +143,7 @@ msgstr ""
143143#: ../app/settings/DownloadSetting.qml:34
144144#: ../app/settings/DownloadSetting.qml:35
145145#: ../app/settings/DownloadSetting.qml:36
146−#: ../app/settings/DownloadSetting.qml:37 ../app/ui/EpisodesPage.qml:349
146+#: ../app/settings/DownloadSetting.qml:37 ../app/ui/EpisodesPage.qml:347
147147#, qt-format
148148msgid "%1 episode"
149149msgid_plural "%1 episodes"
@@ -177,7 +177,7 @@ msgid "Mark all listened"
177177msgstr ""
178178
179179#: ../app/ui/EpisodesPage.qml:94 ../app/ui/EpisodesPage.qml:188
180−#: ../app/ui/SearchPage.qml:279
180+#: ../app/ui/SearchPage.qml:277
181181msgid "Unsubscribe"
182182msgstr ""
183183
@@ -201,32 +201,32 @@ msgstr ""
201201msgid "Are you sure you want to unsubscribe from <b>%1</b>?"
202202msgstr ""
203203
204−#: ../app/ui/EpisodesPage.qml:227 ../app/ui/WhatsNewTab.qml:219
204+#: ../app/ui/EpisodesPage.qml:227 ../app/ui/WhatsNewTab.qml:217
205205msgid "Episode Description"
206206msgstr ""
207207
208208#: ../app/ui/EpisodesPage.qml:239 ../app/ui/SearchPage.qml:181
209−#: ../app/ui/WhatsNewTab.qml:231
209+#: ../app/ui/WhatsNewTab.qml:229
210210msgid "Close"
211211msgstr ""
212212
213−#: ../app/ui/EpisodesPage.qml:269
213+#: ../app/ui/EpisodesPage.qml:267
214214msgid "No episodes found"
215215msgstr ""
216216
217−#: ../app/ui/EpisodesPage.qml:270
217+#: ../app/ui/EpisodesPage.qml:268
218218msgid "No episodes found matching the search term."
219219msgstr ""
220220
221−#: ../app/ui/EpisodesPage.qml:366
221+#: ../app/ui/EpisodesPage.qml:364
222222msgid "Unheard"
223223msgstr ""
224224
225−#: ../app/ui/EpisodesPage.qml:393
225+#: ../app/ui/EpisodesPage.qml:391
226226msgid "Listened"
227227msgstr ""
228228
229−#: ../app/ui/EpisodesPage.qml:418
229+#: ../app/ui/EpisodesPage.qml:416
230230msgid "Downloaded"
231231msgstr ""
232232
@@ -263,25 +263,25 @@ msgstr ""
263263msgid "Search podcast"
264264msgstr ""
265265
266−#: ../app/ui/PodcastsTab.qml:145
266+#: ../app/ui/PodcastsTab.qml:143
267267msgid "No Podcast Subscriptions"
268268msgstr ""
269269
270−#: ../app/ui/PodcastsTab.qml:145
270+#: ../app/ui/PodcastsTab.qml:143
271271msgid "No Podcasts Found"
272272msgstr ""
273273
274−#: ../app/ui/PodcastsTab.qml:146
274+#: ../app/ui/PodcastsTab.qml:144
275275msgid ""
276276"You haven't subscribed to any podcasts yet, visit the 'Find New Podcasts' "
277277"page to add some."
278278msgstr ""
279279
280−#: ../app/ui/PodcastsTab.qml:147 ../app/ui/SearchPage.qml:213
280+#: ../app/ui/PodcastsTab.qml:145 ../app/ui/SearchPage.qml:211
281281msgid "No podcasts found matching the search term."
282282msgstr ""
283283
284−#: ../app/ui/PodcastsTab.qml:185 ../app/ui/PodcastsTab.qml:233
284+#: ../app/ui/PodcastsTab.qml:183 ../app/ui/PodcastsTab.qml:231
285285#, qt-format
286286msgid "%1 unheard episode"
287287msgid_plural "%1 unheard episodes"
@@ -312,33 +312,33 @@ msgstr ""
312312msgid "Please check the URL and try again"
313313msgstr ""
314314
315−#: ../app/ui/SearchPage.qml:211
315+#: ../app/ui/SearchPage.qml:209
316316msgid "Looking to add a new Podcast?"
317317msgstr ""
318318
319−#: ../app/ui/SearchPage.qml:211
319+#: ../app/ui/SearchPage.qml:209
320320msgid "No Podcasts found"
321321msgstr ""
322322
323−#: ../app/ui/SearchPage.qml:212
323+#: ../app/ui/SearchPage.qml:210
324324msgid ""
325325"Click the 'magnifier' at the top to search or the 'plus' button to add by URL"
326326msgstr ""
327327
328−#: ../app/ui/SearchPage.qml:279
328+#: ../app/ui/SearchPage.qml:277
329329msgid "Subscribe"
330330msgstr ""
331331
332332#. TRANSLATORS: The first argument here is the date of when the podcast was last updated followed by
333333#. the podcast description.
334−#: ../app/ui/SearchPage.qml:318
334+#: ../app/ui/SearchPage.qml:316
335335#, qt-format
336336msgid ""
337337"Last Updated: %1\n"
338338"%2"
339339msgstr ""
340340
341−#: ../app/ui/SearchPage.qml:375
341+#: ../app/ui/SearchPage.qml:373
342342msgid "Not Available"
343343msgstr ""
344344
@@ -409,31 +409,31 @@ msgstr ""
409409msgid "Download all"
410410msgstr ""
411411
412−#: ../app/ui/WhatsNewTab.qml:141
412+#: ../app/ui/WhatsNewTab.qml:139
413413msgid "No New Episodes"
414414msgstr ""
415415
416−#: ../app/ui/WhatsNewTab.qml:141
416+#: ../app/ui/WhatsNewTab.qml:139
417417msgid "No Episodes Found"
418418msgstr ""
419419
420−#: ../app/ui/WhatsNewTab.qml:142
420+#: ../app/ui/WhatsNewTab.qml:140
421421msgid "No more episodes to listen to!"
422422msgstr ""
423423
424−#: ../app/ui/WhatsNewTab.qml:142
424+#: ../app/ui/WhatsNewTab.qml:140
425425msgid "No Episodes found matching the search term."
426426msgstr ""
427427
428−#: ../app/ui/WhatsNewTab.qml:280
428+#: ../app/ui/WhatsNewTab.qml:278
429429msgid "Today"
430430msgstr ""
431431
432−#: ../app/ui/WhatsNewTab.qml:284
432+#: ../app/ui/WhatsNewTab.qml:282
433433msgid "Yesterday"
434434msgstr ""
435435
436−#: ../app/ui/WhatsNewTab.qml:288
436+#: ../app/ui/WhatsNewTab.qml:286
437437msgid "Older"
438438msgstr ""
439439