marian/CONTRIBUTING.md

57 lines
1.8 KiB
Markdown
Raw Normal View History

2017-10-15 01:27:50 +03:00
How to contribute to Marian
===========================
## Reporting a bug/asking questions
Did you find a bug or want to ask a question? Great!
* Ensure the bug was not already reported or the question was not asked on
[the github issues](https://github.com/marian-nmt/marian-dev/issues) or
[the Google discussion group](https://groups.google.com/forum/#!forum/marian-nmt).
* Open a new issue/question if you're unable to find yours.
2017-10-15 01:27:50 +03:00
* For bugs please provide as much relevant information as possible, and do not
forget to attach training/decoding logs and your Marian command.
2017-10-15 01:27:50 +03:00
You are also welcome to request a new feature.
Especially if you plan to help us adding it :)
## Submitting changes
Whenever possible, please send a Github Pull Request with a clear list of what
you've done. Feel free to update CHANGELOG.md file. We will love you
2017-10-15 01:27:50 +03:00
forever if you provide unit or regression tests.
Please follow our coding convention (below) and do not forget to test your
changes by running unit tests:
2017-10-15 01:27:50 +03:00
cd marian-dev/build
cmake .. -DCOMPILE_TESTS=ON
make test
2017-10-15 01:27:50 +03:00
and [regression tests](http://github.com/marian-nmt/marian-regression-tests.git):
cd marian-dev/regression-tests
make install
2017-10-15 01:27:50 +03:00
./run_mrt.sh
## Coding conventions
Main code style rules:
* no tabs, 2 whitespaces instead
* lines no longer than 100 characters
2017-10-15 01:27:50 +03:00
* no trailing whitespaces
* no space between control statements and opening brackets
* `UpperCamelCase` for class names
* `camelCaseWithTrailingUnderscore_` for class variables
* `camelCase` for variables, methods and functions
* `UPPERCASE_WITH_UNDERSCORES` for constants
You may also use [ClangFormat](https://clang.llvm.org/docs/ClangFormat.html)
and the `.clang-format` file provided in the root directory to help you with
code formatting.
2017-10-15 01:27:50 +03:00