mirror of
https://github.com/marian-nmt/marian.git
synced 2024-10-05 19:17:10 +03:00
best-deep alias broken (#968)
The best-deep alias in marian is currently broken, because it doesn't set the model type and the default is `amum` which is incompatible with multiple layers. This commit just adds the type to the best-deep alias entry.
This commit is contained in:
parent
cda2f2112f
commit
07a2ac8126
@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
|
||||
- Fixed fp16 training/inference with factors-combine concat method
|
||||
- Fixed clang 13.0.1 compatibility
|
||||
- Fixed potential vulnerabilities from lxml<4.9.1 or mistune<2.0.31
|
||||
- Fixed the `--best-deep` RNN alias not setting the s2s model type
|
||||
|
||||
### Changed
|
||||
- Parameter synchronization in local sharding model now executes hash checksum before syncing
|
||||
|
@ -46,6 +46,7 @@ void ConfigParser::addAliases(cli::CLIWrapper& cli) {
|
||||
|
||||
// Options setting the BiDeep architecture proposed in http://www.aclweb.org/anthology/W17-4710
|
||||
cli.alias("best-deep", "true", [](YAML::Node& config) {
|
||||
config["type"] = "s2s";
|
||||
config["layer-normalization"] = true;
|
||||
config["tied-embeddings"] = true;
|
||||
config["enc-type"] = "alternating";
|
||||
|
Loading…
Reference in New Issue
Block a user