marian-nmt/marian
1
1
Fork 0
mirror of https://github.com/marian-nmt/marian.git synced 2024-10-05 19:17:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

best-deep alias broken (#968)

Browse Source 
The best-deep alias in marian is currently broken, because it doesn't set the model type and the default is `amum` which is incompatible with multiple layers. This commit just adds the type to the best-deep alias entry.
This commit is contained in:
Nikolay Bogoychev 2022-11-02 11:16:14 +00:00 committed by GitHub
parent cda2f2112f
commit 07a2ac8126
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed fp16 training/inference with factors-combine concat method
- Fixed clang 13.0.1 compatibility
- Fixed potential vulnerabilities from lxml<4.9.1 or mistune<2.0.31
- Fixed the `--best-deep` RNN alias not setting the s2s model type
### Changed
- Parameter synchronization in local sharding model now executes hash checksum before syncing

1
src/common/aliases.cpp
View File

@ -46,6 +46,7 @@ void ConfigParser::addAliases(cli::CLIWrapper& cli) {
// Options setting the BiDeep architecture proposed in http://www.aclweb.org/anthology/W17-4710
cli.alias("best-deep", "true", [](YAML::Node& config) {
config["type"] = "s2s";
config["layer-normalization"] = true;
config["tied-embeddings"] = true;
config["enc-type"] = "alternating";