Commit Graph

4398 Commits

Author SHA1 Message Date
Martin Junczys-Dowmunt
f042eae53f Merged PR 10268: Make compile for GCC >= 7
Removes error checking from destructors that might throw.
2019-11-05 16:07:00 +00:00
Marcin Junczys-Dowmunt
baf4d299e9 make compile for GCC >= 7 2019-11-03 15:36:13 -08:00
Marcin Junczys-Dowmunt
7886867576 fix unit test 2019-11-01 16:58:19 -07:00
Marcin Junczys-Dowmunt
1abd12520d bump version once more 2019-11-01 16:37:12 -07:00
Marcin Junczys-Dowmunt
e3399ef17d merge 2019-11-01 16:35:30 -07:00
Marcin Junczys-Dowmunt
54fba7868e update changelog and version 2019-11-01 16:33:29 -07:00
Martin Junczys-Dowmunt
52c761898b Merged PR 10259: switch to change abort to exception
Switch to change abort to exception, first attempt.
2019-11-01 21:22:38 +00:00
Young Jin Kim
5050aad8db Fix vs project warnings 2019-11-01 11:03:56 -07:00
Young Jin Kim
5ed441f843 Merged PR 9284: Packed model support in production
This PR enables loading and serving of offline packed models.
* Enable support for FBGEMM offline-packed models
* Added different parameters sets for different parameter element types (currently inference only)
* New types (packed*) are used for the packed memory format.
* Added CPU instruction query into the quicksand API.

Related work items: #102572
2019-11-01 17:24:49 +00:00
Marcin Junczys-Dowmunt
8c3cb06944 move regression tests 2019-10-30 15:05:16 -07:00
Martin Junczys-Dowmunt
7efde49c73 Merged PR 10205: towards multiple separated parameter types
This is a helper PR for making Young's packed models cleaner. Parameter objects in Marian are meant to be of one type (say float32) and cannot be correctly mixed for various reasons. This introduces a type -> parameter object map that separates parameters with different types into different spaces. Currently this only works reliably for inference (I hope) and will abort for training if more than one parameter type are specified. With this we will be able to have a parameter object for packed16 and one for float32.

It should also be possible in the future to have the same name for a parameter but differentiated by type, which might solve the tied-embedding problem we discussed a while ago.
2019-10-30 21:27:34 +00:00
Ulrich Germann
7b36b329ef Use ccache for faster compilation if available. (#525)
* Use ccache only when requested via cmake -DUSE_CCACHE=on
* Add link to https://ccache.dev in comment about using ccache.
* Issue success / missing ccache message when ccache is requested during the CCACHE run
* Issue cmake warning instead of cmake status message when use of ccache is requested but ccache cannot be found.
2019-10-30 17:29:27 +00:00
Roman Grundkiewicz
e53a46ae21 Fix multi-line string 2019-10-30 16:51:13 +00:00
Roman Grundkiewicz
b32e677aff
Merge pull request #527 from marian-nmt/add-authors-and-cite-flags
Add --authors and --cite flags
2019-10-30 16:28:42 +00:00
Roman Grundkiewicz
b930762c7a Update regression-tests submodule 2019-10-30 15:25:18 +00:00
Roman Grundkiewicz
9e8c7721ea Add a comment to authors() 2019-10-30 14:10:46 +00:00
Roman Grundkiewicz
6d330e3544 Merge branch 'master' of https://github.com/marian-nmt/marian-dev into add-authors-and-cite-flags 2019-10-30 13:56:01 +00:00
Roman Grundkiewicz
011664664a Update badges 2019-10-30 13:54:59 +00:00
Marcin Junczys-Dowmunt
81c14cd1bb fix compilation error 2019-10-29 14:44:10 -07:00
Martin Junczys-Dowmunt
0bb5dd1ec5 Merged PR 10173: Fix all gcc and cuda incompatibilities accros different hardware and versions
Make everything compile as far as possible on gcc 5.0 to 8.3 and CUDA 8.0 to 10.1.

Also created this compatibility/bug list. BUG is a bug in GCC or CUDA, not Marian.

```
		CUDA
		8.0	9.0	9.2	10.0	10.1	comment
gcc	<5.0	NO					incompatible with c++11 features (codecvt)
	5.4	YES	YES	YES	YES	YES	Any version of gcc 5 smaller than 5.4 should be fine too
	5.5	NO/BUG	NO/BUG	NO/BUG	YES	YES	bugs in GCC and CUDA<9.2
	6.5	NO	NO/BUG	YES	YES	YES	bug in GCC and CUDA 9.0
	7.4	NO	NO	YES	YES	YES
	8.3	NO	NO	NO	NO	YES	warnings in 3rd-party code
	9.2	NO	NO	NO	NO	NO	not yet supported by CUDA

			TC	FP16	FP16	FP16
```
2019-10-29 21:36:30 +00:00
Marcin Junczys-Dowmunt
af7df9d7b7 Address comments from review 2019-10-29 14:31:51 -07:00
Marcin Junczys-Dowmunt
939625ff6c simplify code for compute capability of matrix products 2019-10-29 13:35:22 -07:00
Marcin Junczys-Dowmunt
9d8777b60e fix CUDA 8.0 compilation 2019-10-29 13:05:06 -07:00
Marcin Junczys-Dowmunt
880cc5dca8 make sure that old GPUs do not run cublasGemmEx 2019-10-29 11:37:27 -07:00
Marcin Junczys-Dowmunt
3a16eb624f remove left-over debug info 2019-10-29 08:58:29 -07:00
Marcin Junczys-Dowmunt
6b6444dcc1 fix tests for GPUs with lower compute capability 2019-10-29 08:52:55 -07:00
Marcin Junczys-Dowmunt
5476f623b8 add checking for GPU compute capability 2019-10-29 08:39:25 -07:00
Roman Grundkiewicz
42250be8aa Add --authors and --cite flags 2019-10-29 15:20:44 +00:00
Marcin Junczys-Dowmunt
bf10d36d1e disable FBGEMM by default 2019-10-29 07:29:20 -07:00
Marcin Junczys-Dowmunt
47eb65625f back-compat with CUDA 8.0 2019-10-28 17:28:37 -07:00
Marcin Junczys-Dowmunt
a0e472294a remove compatibility check for gcc 4.9 and below, as we cannot compile on 4.9 anyway 2019-10-28 13:57:43 -07:00
Marcin Junczys-Dowmunt
0a89e8f168 fix compilation for various gcc and cuda combinations 2019-10-28 13:18:07 -07:00
Martin Junczys-Dowmunt
2dfb302091 Merged PR 10148: Update internal master with changes to public master
Update internal master with changes to public master. Includes a few PRs accepted in public master. Preparation to merge internal changes back to public master.

I don't think there is actually anything to review here.
2019-10-28 02:15:00 +00:00
Marcin Junczys-Dowmunt
321fab9511 move sigterm handling out of class Scheduler 2019-10-27 19:12:45 -07:00
Hieu Hoang
05c24fcacf Merged PR 10147: tweaks for windows compile
tweaks for windows compile
2019-10-27 22:46:33 +00:00
Marcin Junczys-Dowmunt
398ed0c8d2 update version and changelog 2019-10-27 15:02:18 -07:00
Marcin Junczys-Dowmunt
b478917799 Merge branch 'pmaster' into mjd/syncWithPublic 2019-10-27 15:00:56 -07:00
Marcin Junczys-Dowmunt
9f669f9ac5
Merge pull request #442 from marian-nmt/ug-graceful-shutdown
Save models before exiting after receiving signal SIGTERM
2019-10-27 14:59:48 -07:00
Ulrich Germann
ad6f7ff5a0 Changes as requested by @snukky. 2019-10-27 21:37:07 +00:00
Ulrich Germann
aff86fd1e5
Update scheduler.cpp
Added link to explanation as to why sigaction is deemed better than signal.
2019-10-27 18:26:24 +00:00
Hieu Hoang
86533709d4 tweaks for windows compile 2019-10-27 10:52:02 -07:00
Marcin Junczys-Dowmunt
8fc0772fac move regression test pointer 2019-10-26 16:56:57 -07:00
Marcin Junczys-Dowmunt
55e3bcfd74 bump patch and changelog 2019-10-26 15:19:01 -07:00
Marcin Junczys-Dowmunt
1ab2484978 Merge branch 'master' into mjd/syncWithPublic 2019-10-26 15:17:14 -07:00
Martin Junczys-Dowmunt
463b29c4e8 Merged PR 10144: Bye Bye Boost
* Remove hard dependency on Boost
* Now optional:
  * Compiling with g++-4.9 still requires boost::regex
  * Compiling marian_server requires boost::asio (marian_server is optional now)
  * Handled automatically by cmake.
2019-10-26 22:12:08 +00:00
Marcin Junczys-Dowmunt
68f9d90bfa fix changelog 2019-10-26 09:04:18 -07:00
Marcin Junczys-Dowmunt
e375905404 update changelog and version 2019-10-26 08:53:57 -07:00
Marcin Junczys-Dowmunt
abf95d0cdd move regtest pointer 2019-10-26 08:41:27 -07:00
Marcin Junczys-Dowmunt
27ce11826e add comments about gradient clipping bug 2019-10-26 08:15:59 -07:00
Marcin Junczys-Dowmunt
e20de4924e move pointer to fitting regression tests 2019-10-25 23:42:54 -07:00