Commit Graph

4889 Commits

Author SHA1 Message Date
rhenry-nv
595fba4145
Fixes bug for certain reductions (#746)
* Fixes reductions into scalars for <= 32 input elements. Only affects reductions where 0 is not the identity
* Update CHANGELOG.md
* Adds space before "?"
* Adds comment explaining increase in margin for reduction tests. Adds axis comment to argument to reduce functions. Adds more tests for small reduction operators
2020-10-26 12:26:41 -07:00
Roman Grundkiewicz
ae866af035 Merged PR 15561: Properly compile FBGEMM in CMake MSVC build
This fixes compilation of FBGEMM on Windows using CMake:
1. Compiling FBGEMM and cpuinfo statically
2. Forcing USE_STATIC_LIBS if USE_FBGEMM is set
2020-09-25 15:50:56 +00:00
Roman Grundkiewicz
244cfaa07e Merged PR 15332: Add CPU-only and GPU-only builds to Azure Pipelines
A few updates to Azure Pipelines:
* Adding CPU-only and GPU-only builds on Ubuntu
* Compiling Marian statically in some of the Ubuntu builds
* Ubuntu build with minimum supported versions of CMake (3.5.1), gcc (5.5), CUDA (10.0 due to GCC 5.5), no MKL
* Compiling marian-server with Boost 1.72 on Windows builds
* Minor clean up
2020-09-25 14:57:39 +00:00
Martin Junczys-Dowmunt
91ad534c65 Merged PR 15320: Sync internal and external master
Updates internal master to external master.

Changes:
* Correct behavior for Pre-Norm transformer
* Small changes to CMake files
2020-09-19 16:22:08 +00:00
Roman Grundkiewicz
467b15e2b9
Updates to GitHub CI workflows (#730)
* Update GitHub workflows
* Disable marian-server on Windows checks
* Rename GitHub workflows
* Remove CMakeSettings.json files used for CI only
2020-09-16 10:27:38 +01:00
Roman Grundkiewicz
97f094b444
Release workflows (#731)
* Add GitHub workflow for generating releases
* Update pattern and job names
2020-09-15 09:42:37 -07:00
Roman Grundkiewicz
b32144c055 Clean up Ubuntu builds 2020-09-14 14:36:04 +01:00
Roman Grundkiewicz
621be16954 Build marian-server on Windows with Boost 1.72 2020-09-14 14:23:10 +01:00
Roman Grundkiewicz
26175e8286 Set timeout for Ubuntu jobs 2020-09-14 09:59:05 +01:00
Roman Grundkiewicz
fbdff66ee0 Remove call to marian-server.exe 2020-09-11 17:53:27 +01:00
Roman Grundkiewicz
3348390f27 Use CUDA 10 in UbuntuBuildMinimal 2020-09-11 17:36:55 +01:00
Roman Grundkiewicz
9e0d6e5f3a Set CUDA_TOOLKIT_ROOT_DIR 2020-09-11 16:58:11 +01:00
Roman Grundkiewicz
20338fd0d5 Fix path to custom cmake 2020-09-11 16:50:41 +01:00
Roman Grundkiewicz
1931bbaa8c Add Ubuntu build with minimum GCC and CMake supported 2020-09-11 14:28:29 +01:00
Roman Grundkiewicz
c192be1660 Disable building marian-server in Windows CI 2020-09-11 13:43:23 +01:00
Roman Grundkiewicz
f9a069c0eb Add matrix.static to Ubuntu builds 2020-09-11 13:31:02 +01:00
Roman Grundkiewicz
976f892917 Add comment on Boost on Azure-hosted runners 2020-09-11 13:25:32 +01:00
Roman Grundkiewicz
02d15861a6 Windows builds with marian-server 2020-09-11 13:03:26 +01:00
Roman Grundkiewicz
29d805a101 Try variables.var syntax for matrix variables 2020-09-11 12:20:31 +01:00
Roman Grundkiewicz
b71c66b8a3 Add matrix.gpu to Ubuntu builds 2020-09-11 11:49:55 +01:00
Roman Grundkiewicz
96291157d1 Move 'variables' to job level 2020-09-11 11:30:27 +01:00
Roman Grundkiewicz
0f1cab6c03 Add CPU-only and GPU-only builds to Azure DevOps 2020-09-11 11:11:34 +01:00
Roman Grundkiewicz
c1e823a6ca
Update VERSION 2020-09-11 10:09:00 +01:00
Roman Grundkiewicz
a28cbf123e
Remove duplicated EXT_LIBS (#728) 2020-09-10 14:04:42 -07:00
Marcin Junczys-Dowmunt
c904b05471 Old CMAKE does not understand VERSION_EQUAL_GREATER 2020-09-09 21:27:24 -07:00
Marcin Junczys-Dowmunt
4937f59747 suppress sentencepiece warnings for g++ > 8.0 2020-09-09 21:20:37 -07:00
Marcin Junczys-Dowmunt
2bd1f1c3c7 Merge branch 'master' into pmaster 2020-09-09 18:35:06 -07:00
Aaron Burke
5c45a37fcc Merged PR 14474: CMake build fixes for QuickSAND
- Add installation targets (enabled by GENERATE_MARIAN_INSTALL_TARGETS; default: OFF to preserve CMake 3.5.1 compatibility)
- Add COMPILE_LIBRARY_ONLY option (default: OFF) to exclude in-source executables from the build
- Compiler warning flags are no longer exported as part of the public link interface, only when building privately
- Always set CPUINFO_BUILD_TOOLS=OFF when building fbgemm, not just for MSVC builds

Related work items: #108034
2020-09-10 01:33:44 +00:00
Nikolay Bogoychev
9c6ad012a9
Compute75 for NCCL (#711)
* Propagate SM75 and SM80 to NCCL
2020-09-09 08:28:54 -07:00
Marcin Junczys-Dowmunt
951ecfe932
Enable final stack post-processing for transformer for correct prenorm behavior (#719)
This PR enables final post-processing of a full transformer stack for correct prenorm behavior.
See issues: #715 and #699,

List of changes:

Add final post-processing in encoder and decoder if requested with --transformer-postprocess-top. Can take combinations of d, n, a. Using a will add a skip connection from the bottom of the stack.
Add --task transformer-base-prenorm and --task transformer-big-prenorm which correspond to --task transformer-base --transformer-preprocess n --transformer-postprocess da --transformer-postprocess-top n.
2020-09-09 08:06:20 -07:00
Marcin Junczys-Dowmunt
660719cd27 Merge branch 'master' into pmaster 2020-09-08 11:50:47 -07:00
Marcin Junczys-Dowmunt
e71e7e2469 fix compilation with -DCOMPILE_CPU=off 2020-09-08 11:41:37 -07:00
Roman Grundkiewicz
4f8c2ed6a6 Merged PR 15232: Update Azure Pipelines
A few improvements to Azure Pipelines:
- Disabling build on Ubuntu 20.04 due to [issues with FBGEMM and GCC 9+](https://github.com/marian-nmt/marian-dev/issues/709)
- Replacing Invoke-WebRequest with wget.exe
- Cleaning environmental variables
2020-09-08 16:58:03 +00:00
Marcin Junczys-Dowmunt
794d6f7a55 Merge branch 'master' into pmaster 2020-09-07 12:39:21 -07:00
Martin Junczys-Dowmunt
e3916b3d08 Merged PR 15233: Sync internal master with public master
Regular sync of public and internal master.
2020-09-07 19:37:41 +00:00
Marcin Junczys-Dowmunt
82b5f3feb2 Merge branch 'master' into pmaster 2020-09-07 12:30:12 -07:00
Roman Grundkiewicz
d20172c406
Disable GitHub check with Ubuntu 20.04 and GCC 9 (#717)
* Disable GitHub check with Ubuntu 20.04 and GCC 9
* Use wget instead of Invoke-WebRequest
2020-09-07 20:04:00 +01:00
Roman Grundkiewicz
2457b49356 Update submodule regression-tests 2020-09-06 09:29:59 +01:00
Marcin Junczys-Dowmunt
f9f4155357 move pointer to NCCL version with reduced warnings on > g++-7 2020-09-05 18:58:53 -07:00
Martin Junczys-Dowmunt
ea3ac624c6 Merged PR 15155: Enable output layer without output bias
Adds `--output-omit-bias` option which allows to train an output layer without a bias vector. This is expected to be useful for `--output-approx-knn` during decoding, as the LSH-based k-NN search is then exactly approximating the correct top-K values for decoding. The bias adds a shift otherwise. In first experiments the lack of the output bias does not seem to result in any performance loss.
2020-09-04 17:58:28 +00:00
Roman Grundkiewicz
a4eb201632 Update submodule regression-tests 2020-09-04 09:36:02 -07:00
Roman Grundkiewicz
452f9c79e6
Print message that marian-server is listening on port X after it is accepting connections (#705)
* Print 'server is listening' after it is accepting connections; fix #701
* Minor code formatting
2020-09-03 11:47:10 +01:00
Roman Grundkiewicz
9336746f89
Add GitHub workflow with CUDA 11 on Ubuntu 20.04 (#704)
* Add GitHub workflow with CUDA 11 on Ubuntu 20.04
* Make build job names unique
* Make build with CUDA 11 experimental
2020-09-02 17:20:34 +01:00
Nikolay Bogoychev
4d9d15649e
Enable compute75 when using cuda10 (#698)
* Enable compute75 when using cuda10 or newer and disable compute <50 when using CUDA11
* Re-enable deprecated architectures with CUDA11
2020-09-01 08:56:24 -07:00
Roman Grundkiewicz
cd04725639 Update VERSION 2020-09-01 02:45:02 -07:00
Ulrich Germann
044b416af5
Improved handling of SIGTERM (#660)
* Return exit code 15 (SIGTERM) after SIGTERM.
When marian receives signal SIGTERM and exits gracefully (save model & exit),
it should then exit with a non-zero exit code, to signal to any parent process
that it did not exit "naturally".
* Added explanatory comment about exiting marian_train with non-zero status after SIGTERM.
* Bug fix: better handling of SIGTERM for graceful shutdown during training.
Prior to this bug fix, BatchGenerator::fetchBatches, which runs in a separate
thread, would ignore SIGTERM during training (training uses a custom signal handler
for SIGTERM, which simply sets a global flag, to enable graceful shutdown (i.e.,
save models and current state of training before shutting down).

The changes in this commit also facilitate custom handling of other signals in the
future by providing a general singal handler for all signals with a signal number
below 32 (setSignalFlag) and a generic flag checking function (getSignalFlag(sig))
for checking such flags.
2020-08-31 21:13:41 -07:00
Nikolay Bogoychev
96738fea25
Partial CUDA11 Support (#696)
* Partial CUDA11 Support
* Add an extra abort
* Remove unnecessary CUDA11 defines
2020-08-27 13:46:23 -07:00
Roman Grundkiewicz
428703b939 Merged PR 14978: Add Azure DevOps on Windows and with CUDA 11
Updating Azure pipelines with two builds on Windows (CMake, CPU-only and CPU+CUDA), and a build on Ubuntu 20.04 with CUDA 11.
2020-08-26 19:56:14 +00:00
Roman Grundkiewicz
e41c3dbb86 Merged PR 14928: Initial Azure Pipelines
This PR adds initial Azure Pipelines with builds on Ubuntu (with CUDA) and macOS (CPU-only).

The scripts installing CUDA are already in the public master.
2020-08-25 06:59:07 +00:00
Kenneth Heafield
e9d7de4499
Update simple websocket server (#702)
Crucially this includes 6ee2a61a64 that was breaking on machines without ipv6
2020-08-24 12:34:53 +01:00