Commit Graph

122 Commits

Author SHA1 Message Date
Frank Seide
ff4db737bf updated after merge from master 2019-02-04 17:05:01 -08:00
Frank Seide
41117fb432 abstracted Expr State::targetIndices_ to Words targetWords_, in prep for factored word representations 2019-02-04 16:34:26 -08:00
Frank Seide
bcbe247a57 auto-merged pieces of last merge 2019-02-04 12:45:25 -08:00
Frank Seide
f9e63da391 removed auto-conversion between Word and WordIndex, and dealt with fallout 2019-01-31 22:24:26 -08:00
Frank Seide
acee183116 towards fixing the bug that bert.h includes transformer.h 2019-01-31 14:55:45 -08:00
Frank Seide
7b649c00e0 In VS Project, changed transformer.h from CPP file to a true header, and added the stub, to fix a compilation warning 2019-01-31 14:45:51 -08:00
Frank Seide
93763c30e6 now always normalizes factors 2019-01-28 10:02:53 -08:00
Marcin Junczys-Dowmunt
50d64de62c
Merge pull request #415 from marian-nmt/chmod-x
C++ source should not have execute bits
2019-01-25 08:52:30 -08:00
Kenneth Heafield
f100a8649a C++ source is should not have execute bits 2019-01-23 23:20:46 +00:00
Frank Seide
2e331b254d merged dot_csr() change 2019-01-15 16:45:49 -08:00
Frank Seide
31f4f721b4 scaffolding for new operation dot_csr(); renamed prod.cu to prod.cpp, since it no longer has CUDA code 2019-01-15 13:25:36 -08:00
Frank Seide
c5839f07e0 towards factored embeddings; towards csr_dot() operation 2019-01-10 21:14:55 -08:00
Frank Seide
664e29ff6e removed operator-> for Factories 2019-01-08 17:59:05 -08:00
Frank Seide
9023bf8b90 fixed build break due to MPI change in examples 2019-01-08 17:15:39 -08:00
Frank Seide
f6de599980 generalized step() to narrow() and sliceView(), new class Slice;
bug fix: SliceViewNodeOp should use correct size for memory piece;
new operation stopGradient()
2018-12-26 16:35:56 -08:00
Frank Seide
efc20adacc added elementwise comparison operators (lt(), eq(), );
bug fix: Maximum and Minimum got it backwards;
streamlined the operator tests a little
2018-12-26 14:21:23 -08:00
Frank Seide
4cf97df51e minibatch-size warmup (manually merged over from fseide/covbias);
minibatches are now fed in GPU-sized chunks rather than a massive joint batch for all GPUs in the update;
Adam hyper-parameter adjustment limited to learning rate, as momentum adjustment is counterproductive for MB scaling;
log output now includes the last batch size;
log output now shows current best for stalled validation metrics;
bug fix: Adam optimizer should persist denominators;
bug fix: Adam and Adagrad should use correct element size when persisting;
min and max renamed to minimum and maximum, for consistency with other toolkits;
pathie now compiles in manual VS Project
2018-12-12 18:40:46 -08:00
Marcin Junczys-Dowmunt
28629ea516 switch CUDA back on 2018-12-12 13:45:57 -08:00
Marcin Junczys-Dowmunt
0ae07c5323 handle warnings in sse2 and avx code 2018-12-12 13:33:04 -08:00
Marcin Junczys-Dowmunt
fc490bba03 google protobuf from cmake 2018-12-11 15:01:50 -08:00
Marcin Junczys-Dowmunt
b44195c33d fix more warnings 2018-12-11 14:01:11 -08:00
Marcin Junczys-Dowmunt
cdfe90a9a3 update instructions, fix more warnings 2018-12-10 15:51:45 -08:00
Marcin Junczys-Dowmunt
30b6219773 fix more warnings, make CUDA optional for windows 2018-12-10 15:40:17 -08:00
Marcin Junczys-Dowmunt
634ba54839 fix warnings 2018-12-10 14:40:11 -08:00
Marcin Junczys-Dowmunt
8f604afb88 make things compile under windows again 2018-12-10 13:32:22 -08:00
Frank Seide
bad990f6ed fixed VS Project 2018-11-21 11:29:28 -08:00
Frank Seide
28e633d5e7 manually added back some lost SentencePiece entries in the VS Project 2018-11-21 10:56:22 -08:00
Frank Seide
47c0af45a3 reverted the VS Proj to master, since stuff got deleted somehow 2018-11-21 10:50:44 -08:00
Frank Seide
12f81faf25 main source is now called marian_main.cpp, hoping to reduce the confusion caused by renaming 2018-11-21 10:48:24 -08:00
Frank Seide
b5015f8dba merged from master, VS Project is now broken 2018-11-21 10:38:09 -08:00
Frank Seide
79c256c176 enabled the main wrapper that combines all Marian EXEs into a single command line tool 2018-11-21 10:30:54 -08:00
Frank Seide
53c14314ee Merged PR 5582: added SentencePiece to VS solution
added SentencePiece to VS solution

Related work items: #96098
2018-11-19 23:44:03 +00:00
Frank Seide
ff17777c02 renamed type 'sample' to 'Sample'; added a missing .cpp file to Windows Project 2018-11-14 03:06:35 -08:00
Frank Seide
1e358e4c40 added SentencePiece to VS solution 2018-11-09 19:55:28 -08:00
Frank Seide
015f392e82 reenabled -Wunused-variable and dealt with fallout 2018-11-05 21:24:02 -08:00
Frank Seide
fca0510133 enabled most warnings on gcc, and fixed them 2018-11-05 20:21:50 -08:00
Frank Seide
4fcdd191ab Merged PR 5379: bug fix: git revision should be updated accurately
This PR separates the old `version.h` (now renamed to `project_version.h`, which is really meant for the project version and therefore gets created only at time of `cmake`, and a new process that creates a new file `git_revision.h` whenever the HEAD changes.

By using a clever trick from StackOverflow that makes `git_revision.h` depend directly on git's `HEAD` file, this new header file only gets recreated when the HEAD changes (e.g. a commit or checkout command). As a result, if the revision has does not change, a repeated `make` invocation will not compile or link anything.

This version is now logged directly at program startup, together with hostname, process id, and the command line.

What is still missing is a "dirty" flag in the version number.

Related work items: #96098
2018-10-29 21:24:09 +00:00
Frank Seide
88d141060a added -Werror; added warning for missing 'override' and fixed the fallout; now always compiles quicksand.cpp to ensure it builds 2018-10-25 14:51:39 -07:00
Frank Seide
ab8c3e9009 renamed version.h* to project_version.h*; created new version.cpp that is the only place that includes version header(s) 2018-10-24 15:24:08 -07:00
Frank Seide
dd05dde278 made SentencePiece changes compile under Windows 2018-10-19 13:29:43 -07:00
Frank Seide
581d00360b minor VS build fixes 2018-10-18 14:02:19 -07:00
Frank Seide
e8443b0875 fixed (eliminated) all TABs that had snuck in so far; fixed a few warnings on Windows 2018-10-15 13:27:29 -07:00
Frank Seide
34f3eb13a0 addressed PR feedback 2018-10-09 20:39:37 -07:00
Frank Seide
c477031fae setGuidedAlignment() now accepts an rvalue ref; reenabled the findBatchSize() sanity check, since it makes no runtime difference; added quicksand sources to VS Project 2018-10-09 16:59:39 -07:00
Frank Seide
1057841140 now includes the MPI rank in each log msg; bug fix: fixed a few compilation problems on Windows 2018-10-05 14:38:12 -07:00
Frank Seide
108a3e8980 addressed some merge problems. This still does not link 2018-10-04 17:48:28 -07:00
Frank Seide
c55338277e towards logging the call stack on Segfault 2018-09-30 16:29:17 -07:00
Cédric Rousseau
9551e03c8f Addressed PR review 2018-09-26 22:29:14 +02:00
Frank Seide
3b3d45e024 turned communicator.cu into a header communicator_nccl.h;
renamed Communicator to ICommunicator;
some cleanup in NcclCommunicator;
first steps towards supporting MPI in graph_group_sync (works locally so far)
2018-09-25 13:56:37 -07:00
Cédric Rousseau
06aaefc2e0 Fix deps check script + top-level comments 2018-09-17 17:24:25 +02:00
Cédric Rousseau
77516c9239 Update scripts to build on Windows 2018-09-14 15:52:42 +02:00
Cédric Rousseau
7465921290 Update README 2018-09-11 17:57:25 +02:00
Cédric Rousseau
b6d8177c2f Improve configuration script to use installed libraries 2018-09-07 18:00:51 +02:00
Cédric Rousseau
eb98a45b04 merge Master 2018-09-07 13:29:38 +02:00
Cédric Rousseau
900fe0eda0 update README 2018-09-07 11:41:31 +02:00
Frank Seide
da56daa4eb Windows version now compiles with MPI 2018-09-05 13:59:57 -07:00
Cédric Rousseau
c930885d0a Update README 2018-09-05 17:09:08 +02:00
Cédric Rousseau
4fd2360918 Fix CUDA+MSVC incompatibility with Boost.Preprocessor 2018-09-05 15:42:16 +02:00
Cédric Rousseau
78dd2a2d59 Fix unresolved external due to a removed #include directive 2018-09-05 13:16:53 +02:00
Cédric Rousseau
fbb221e995 Fix mismatched class/struct forward declarations 2018-09-05 11:58:09 +02:00
Cédric Rousseau
0659b2c5d5 Build in Release, with improved debug info 2018-09-04 16:58:49 +02:00
Cédric Rousseau
5fae8a0da7 Fix Cuda error : Unsupported Visual Studio Version Error 2018-09-04 16:38:28 +02:00
Cédric Rousseau
29dfffc93c Adding scripts and readme file 2018-09-04 16:34:21 +02:00
Frank Seide
14631160db fixed all warnings discovered by Visual Studio 2018-08-31 19:21:14 -07:00
Frank Seide
70417fa306 fixed Visual Studio projects to actually build the EXE 2018-08-20 14:03:43 -07:00
Frank Seide
dc881d824a removed old (incorrect) VS files 2018-08-20 13:22:18 -07:00
Frank Seide
a8ad3a028e added VS Solution and Project 2018-08-19 16:18:32 -07:00
Roman Grundkiewicz
9557b2b82e Move VS build 2018-07-31 14:21:33 +01:00
Frank Seide
e87564c664 bug fix: History::Add() should obey the actual EOS symbol from the given vocabulary;
SubBatch now holds the vocabulary, allowing to debug-print the sequences with word ids;
new operators: logsum, max, min;
new overload operator/(float,Expr);
shift() now takes a padding value;
transformer.h is now a compiled .cpp file on Windows (in prep for renaming to transformer.cpp);
fixed two MSVC warnings;
bug fix: logger should not output two \r characters at the end of the line;
minor changes (const correctness, accessors)
2018-06-21 13:34:19 -07:00
Frank Seide
8adde0787e rolled back the accidental change of the vcxproj 2018-06-21 13:15:28 -07:00
Martin Junczys-Dowmunt
2882b441b7 Merged PR 3923: replace aligned_alloc with malloc
replace aligned_alloc with malloc
2018-06-11 21:23:23 +00:00
Frank Seide
e3f32ad892 moved vs project into its own folder 2018-06-07 16:15:28 -07:00