martinvonz/jj
1
1
Fork 0
mirror of https://github.com/martinvonz/jj.git synced 2024-09-20 10:18:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

revset: simplify evaluation of "all()"

Browse Source 
I think this is more readable, and apparently it produces slightly better code
maybe because the compiler can determine that there are no unwanted markers.
This commit is contained in:
Yuya Nishihara 2023-04-03 12:12:40 +09:00
parent 0bfdbcaa1e
commit 426f3e4e0a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/src/default_revset_engine.rs
View File

@ -549,7 +549,8 @@ impl<'index, 'heads> EvaluationContext<'index, 'heads> {
// (and `remote_branches()`) specified in the revset expression. Alternatively, // (and `remote_branches()`) specified in the revset expression. Alternatively,
// some optimization rules could be removed, but that means `author(_) & x` // some optimization rules could be removed, but that means `author(_) & x`
// would have to test `:heads() & x`. // would have to test `:heads() & x`.
self.evaluate(&RevsetExpression::visible_heads().ancestors()) let walk = self.composite_index.walk_revs(self.visible_heads, &[]);
Ok(Box::new(RevWalkRevset { walk }))
} }
RevsetExpression::Commits(commit_ids) => Ok(self.revset_for_commit_ids(commit_ids)), RevsetExpression::Commits(commit_ids) => Ok(self.revset_for_commit_ids(commit_ids)),
RevsetExpression::Children(roots) => { RevsetExpression::Children(roots) => {