From 100be45fb49e0807cd27964cbf54d30c69c62230 Mon Sep 17 00:00:00 2001
From: Elliott Marquez <emarquez@google.com>
Date: Fri, 20 Sep 2019 15:40:26 -0700
Subject: [PATCH] =?UTF-8?q?fix=20extra=20spacing=20=E2=80=93=20older=20bro?=
 =?UTF-8?q?wsers=20(#493)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix extra spacing – older browsers

* fix css colors on 'required' asterisk

* update changelog
---
 CHANGELOG.md                                         |  8 ++++++--
 .../notched-outline/src/mwc-notched-outline.scss     |  5 -----
 packages/textfield/src/mwc-textfield.scss            | 12 ++++++++++--
 3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 535beec63..b27bc2068 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,13 +24,17 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   `lit-element` or `lit-html` APIs (e.g. `LitElement`, `customElement`,
   `classMap`). Users should import directly from the `lit-element` and
   `lit-html` modules instead.
-- `mwc-input` and `mwc-textarea` now update `value` on `input` rather than on
-  `change`.
+- **BREAKING** `mwc-textfield` and `mwc-textarea` will now update their `.value`
+  on the native `input`'s `input` event instead of `change`.
 
 ### Fixed
 
 - `<mwc-drawer>` can now be used with Rollup (via version bump to pick up
   [WICG/inert#135](https://github.com/WICG/inert/pull/135)).
+- `<mwc-textfield>` and `<mwc-textarea>` will now have the same height between
+  their filled and outlined variants with helper text on older browsers.
+- `mwc-textfield[required]` and `mwc-textarea[required]` will now have their
+  required asterisk colored correctly when customized.
 - `<mwc-textfield>` and `<mwc-textarea>` can now have basic usability in IE.
 
 
diff --git a/packages/notched-outline/src/mwc-notched-outline.scss b/packages/notched-outline/src/mwc-notched-outline.scss
index e18f8ff8e..98ab645e2 100644
--- a/packages/notched-outline/src/mwc-notched-outline.scss
+++ b/packages/notched-outline/src/mwc-notched-outline.scss
@@ -53,11 +53,6 @@ limitations under the License.
 
 .mdc-notched-outline--upgraded ::slotted(.mdc-floating-label--float-above) {
   max-width: calc(100% / .75);
-
-  @include mdc-theme-prop(color, (
-    varname: --mdc-theme-primary,
-    fallback: $mdc-theme-primary
-  ));
 }
 
 .mdc-notched-outline__leading {
diff --git a/packages/textfield/src/mwc-textfield.scss b/packages/textfield/src/mwc-textfield.scss
index b691b327a..86344699a 100644
--- a/packages/textfield/src/mwc-textfield.scss
+++ b/packages/textfield/src/mwc-textfield.scss
@@ -38,13 +38,14 @@ limitations under the License.
 }
 
 .mdc-text-field {
+  display: flex;
+
   width: 100%;
 
   @include mdc-theme-prop(border-radius, (
     varname: --mdc-text-field-filled-border-radius,
     fallback: mdc-shape-mask-radius(mdc-shape-prop-value(small), 1 1 0 0)
   ));
-
 }
 
 mwc-notched-outline {
@@ -79,7 +80,14 @@ mwc-notched-outline {
       --mdc-notched-outline-border-color: var(--mdc-text-field-focused-label-color, var(--mdc-theme-primary, #{$mdc-text-field-focused-label-color}));
     }
 
-    .mdc-floating-label, .mdc-floating-label::after {
+    .mdc-floating-label {
+      @include mdc-theme-prop(color, (
+        varname: --mdc-theme-primary,
+        fallback: $mdc-theme-primary
+      ));
+    }
+
+    @include mdc-required-text-field-label-asterisk_ {
       @include mdc-theme-prop(color, (
         varname: --mdc-theme-primary,
         fallback: $mdc-theme-primary