From 363fc054d3cc8b491c8887e1faf56e01b64f0a83 Mon Sep 17 00:00:00 2001 From: Elizabeth Mitchell Date: Wed, 27 Dec 2023 15:48:57 -0800 Subject: [PATCH] chore: remove un-actionable todos from labs PiperOrigin-RevId: 594112463 --- labs/badge/internal/badge.ts | 2 +- labs/navigationbar/internal/navigation-bar.ts | 2 +- .../internal/_navigation-drawer-modal.scss | 2 +- labs/navigationdrawer/internal/_navigation-drawer.scss | 2 +- labs/navigationdrawer/internal/navigation-drawer-modal.ts | 2 +- labs/navigationdrawer/internal/navigation-drawer.ts | 2 +- labs/navigationtab/internal/navigation-tab.ts | 4 ++-- labs/navigationtab/internal/state.ts | 7 ------- .../internal/_outlined-segmented-button.scss | 4 ++-- labs/segmentedbutton/internal/_shared.scss | 2 +- labs/segmentedbutton/internal/outlined-segmented-button.ts | 2 +- .../internal/outlined-segmented-button-set.ts | 2 +- 12 files changed, 13 insertions(+), 20 deletions(-) diff --git a/labs/badge/internal/badge.ts b/labs/badge/internal/badge.ts index 9dfa96f3f..0b25b67d3 100644 --- a/labs/badge/internal/badge.ts +++ b/labs/badge/internal/badge.ts @@ -9,7 +9,7 @@ import {property} from 'lit/decorators.js'; import {classMap} from 'lit/directives/class-map.js'; /** - * TODO(b/265340196): add docs + * b/265340196 - add docs */ export class Badge extends LitElement { @property() value = ''; diff --git a/labs/navigationbar/internal/navigation-bar.ts b/labs/navigationbar/internal/navigation-bar.ts index 49658ecb4..45e82955d 100644 --- a/labs/navigationbar/internal/navigation-bar.ts +++ b/labs/navigationbar/internal/navigation-bar.ts @@ -18,7 +18,7 @@ import {NavigationTabInteractionEvent} from './constants.js'; import {NavigationBarState} from './state.js'; /** - * TODO(b/265346501): add docs + * b/265346501 - add docs * * @fires navigation-bar-activated {CustomEvent} * Dispatched whenever the `activeIndex` changes. --bubbles --composed diff --git a/labs/navigationdrawer/internal/_navigation-drawer-modal.scss b/labs/navigationdrawer/internal/_navigation-drawer-modal.scss index 990aa8ebc..2881ac33c 100644 --- a/labs/navigationdrawer/internal/_navigation-drawer-modal.scss +++ b/labs/navigationdrawer/internal/_navigation-drawer-modal.scss @@ -23,7 +23,7 @@ $_reference: ( 'container-height': 100%, 'container-shape': 0 16px 16px 0, 'container-width': 360px, - // TODO(b/216384393): Temporary existing token to use for shadow color + // b/216384393 - Temporary existing token to use for shadow color 'divider-color': #000, 'modal-container-elevation': 1, 'scrim-color': null, diff --git a/labs/navigationdrawer/internal/_navigation-drawer.scss b/labs/navigationdrawer/internal/_navigation-drawer.scss index c217727d3..eeed37bbc 100644 --- a/labs/navigationdrawer/internal/_navigation-drawer.scss +++ b/labs/navigationdrawer/internal/_navigation-drawer.scss @@ -21,7 +21,7 @@ $_reference: ( 'container-height': 100%, 'container-shape': 0 16px 16px 0, 'container-width': 360px, - // TODO(b/216384393): Temporary existing token to use for shadow color + // b/216384393 - Temporary existing token to use for shadow color 'divider-color': #000, 'modal-container-elevation': 1, 'standard-container-elevation': 0, diff --git a/labs/navigationdrawer/internal/navigation-drawer-modal.ts b/labs/navigationdrawer/internal/navigation-drawer-modal.ts index 3f6991e70..b64aa9b73 100644 --- a/labs/navigationdrawer/internal/navigation-drawer-modal.ts +++ b/labs/navigationdrawer/internal/navigation-drawer-modal.ts @@ -12,7 +12,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js'; import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js'; /** - * TODO(b/265346501): add docs + * b/265346501 - add docs * * @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>} * Dispatched whenever the drawer opens or closes --bubbles --composed diff --git a/labs/navigationdrawer/internal/navigation-drawer.ts b/labs/navigationdrawer/internal/navigation-drawer.ts index 452f001b0..82156c562 100644 --- a/labs/navigationdrawer/internal/navigation-drawer.ts +++ b/labs/navigationdrawer/internal/navigation-drawer.ts @@ -14,7 +14,7 @@ import {ARIAMixinStrict} from '../../../internal/aria/aria.js'; import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js'; /** - * TODO(b/265346501): add docs + * b/265346501 - add docs * * @fires navigation-drawer-changed {CustomEvent<{opened: boolean}>} * Dispatched whenever the drawer opens or closes --bubbles --composed diff --git a/labs/navigationtab/internal/navigation-tab.ts b/labs/navigationtab/internal/navigation-tab.ts index 4e94dd834..be81de846 100644 --- a/labs/navigationtab/internal/navigation-tab.ts +++ b/labs/navigationtab/internal/navigation-tab.ts @@ -18,7 +18,7 @@ import {requestUpdateOnAriaChange} from '../../../internal/aria/delegate.js'; import {NavigationTabState} from './state.js'; /** - * TODO(b/265346501): add docs + * b/265346501 - add docs * * @fires navigation-tab-rendered {Event} Dispatched when the navigation tab's * DOM has rendered and custom element definition has loaded. --bubbles @@ -117,7 +117,7 @@ export class NavigationTab extends LitElement implements NavigationTabState { } handleClick() { - // TODO(b/269772145): connect to ripple + // b/269772145 - connect to ripple this.dispatchEvent( new CustomEvent('navigation-tab-interaction', { detail: {state: this}, diff --git a/labs/navigationtab/internal/state.ts b/labs/navigationtab/internal/state.ts index 46cbb7e25..ffba2f417 100644 --- a/labs/navigationtab/internal/state.ts +++ b/labs/navigationtab/internal/state.ts @@ -16,11 +16,4 @@ export interface NavigationTabState { * If true, when inactive label will be hidden. */ hideInactiveLabel: boolean; - - /** - * Inner button for the tab - * TODO(b/229015424): Remove this when the jscompiler rename issue is - * understood. - */ - buttonElement: HTMLElement | null; } diff --git a/labs/segmentedbutton/internal/_outlined-segmented-button.scss b/labs/segmentedbutton/internal/_outlined-segmented-button.scss index 6012a4907..a20154e0e 100644 --- a/labs/segmentedbutton/internal/_outlined-segmented-button.scss +++ b/labs/segmentedbutton/internal/_outlined-segmented-button.scss @@ -15,7 +15,7 @@ @mixin styles() { $tokens: tokens.md-comp-outlined-segmented-button-values(); - // TODO(b/198759625): Remove spacing tokens once provided. + // b/198759625 - Remove spacing tokens once provided. $tokens: map.merge( $tokens, ( @@ -33,7 +33,7 @@ .md3-segmented-button__outline { border-radius: inherit; border-style: solid; - // TODO(b/233762888): Move border-width and inset into theme after generating latest version of tokens. + // Move border-width and inset into theme. border-width: 1px; inset: 0px -0.5px; pointer-events: none; diff --git a/labs/segmentedbutton/internal/_shared.scss b/labs/segmentedbutton/internal/_shared.scss index b8bd58c99..8d2905d8b 100644 --- a/labs/segmentedbutton/internal/_shared.scss +++ b/labs/segmentedbutton/internal/_shared.scss @@ -98,7 +98,7 @@ &.md3-segmented-button--selected.md3-segmented-button--with-label.md3-segmented-button--with-checkmark, &.md3-segmented-button--selected.md3-segmented-button--without-label.md3-segmented-button--with-checkmark { .md3-segmented-button__graphic { - // TODO(b/198759625): Use padding token instead of hardcoded 8px value. + // b/198759625 - Use padding token instead of hardcoded 8px value. width: calc(var(--_icon-size) + 8px); } } diff --git a/labs/segmentedbutton/internal/outlined-segmented-button.ts b/labs/segmentedbutton/internal/outlined-segmented-button.ts index 3f80077a3..6cde7840c 100644 --- a/labs/segmentedbutton/internal/outlined-segmented-button.ts +++ b/labs/segmentedbutton/internal/outlined-segmented-button.ts @@ -9,7 +9,7 @@ import {html} from 'lit'; import {SegmentedButton} from './segmented-button.js'; /** - * TODO(b/265346443): add docs + * b/265346443 - add docs */ export class OutlinedSegmentedButton extends SegmentedButton { protected override getRenderClasses() { diff --git a/labs/segmentedbuttonset/internal/outlined-segmented-button-set.ts b/labs/segmentedbuttonset/internal/outlined-segmented-button-set.ts index 56a401394..bd699200c 100644 --- a/labs/segmentedbuttonset/internal/outlined-segmented-button-set.ts +++ b/labs/segmentedbuttonset/internal/outlined-segmented-button-set.ts @@ -7,7 +7,7 @@ import {SegmentedButtonSet} from './segmented-button-set.js'; /** - * TODO(b/265346443): add docs + * b/265346443 - add docs */ export class OutlinedSegmentedButtonSet extends SegmentedButtonSet { protected override getRenderClasses() {