material-components/material-web
1
1
Fork 0
mirror of https://github.com/material-components/material-web.git synced 2024-08-17 09:30:27 +03:00
Code Issues Projects Releases Wiki Activity

fix(select): ensure md-select selection logic uses fresh DOM references

Browse Source 
Previously selectItem would work with cached references to select-option elements which could become stale causing the deactivation logic to fail. This cl just ensures that selectItem always re-fetches the nodes to avoid the issue.

PiperOrigin-RevId: 595524158
This commit is contained in:
Material Web Team 2024-01-03 15:50:15 -08:00 committed by Copybara-Service
parent 68b078b4e1
commit 89427158b7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
select/internal/select.ts
View File

@ -725,7 +725,8 @@ export abstract class Select extends selectBaseClass {
* @return Whether the last selected option has changed.
*/
private selectItem(item: SelectOption) {
this.lastSelectedOptionRecords.forEach(([option]) => {
const selectedOptions = this.getSelectedOptions() ?? [];
selectedOptions.forEach(([option]) => {
if (item !== option) {
option.selected = false;
}