mirror of
https://github.com/mawww/kakoune.git
synced 2024-09-11 13:00:41 +03:00
Fix compilation due to failing template deduction for aggregates
gcc 11.2.0 compiles us just fine but clang 13.0.1 fails with this error clang++ -DKAK_DEBUG -O0 -pedantic -std=c++2a -g -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-address -frelaxed-template-template-args -Wno-ambiguous-reversed-operator -MD -MP -MF .ranges.debug.d -c -o .ranges.debug.o ranges.cc ranges.cc:30:17: error: no viable constructor or deduction guide for deduction of template arguments of 'Array' check_equal(Array{{""_sv, "abc"_sv, ""_sv, "def"_sv, ""_sv}} | flatten(), "abcdef"_sv); ^ ./constexpr_utils.hh:14:8: note: candidate template ignored: couldn't infer template argument 'T' struct Array ^ ./constexpr_utils.hh:14:8: note: candidate function template not viable: requires 0 arguments, but 1 was provided 1 error generated. The same error can be reproduced with this C++ input template<typename T, int N> struct Array { T m_data[N]; }; void test() { (void)Array{{1, 2}}; } Since "Array" has no constructor, the compiler uses aggregate initialization. Only recent g++ seems to be smart enough to deduce template arguments in this case. Help other compilers by adding a deduction guide. The deduction guide needs to count the array elements to infer the array size, hence we need to remove braces. Happily, this is allowed and it's also what std::array does. Closes #4597
This commit is contained in:
parent
ceaac1c400
commit
8a7109f9c5
@ -28,6 +28,9 @@ struct Array
|
||||
T m_data[N];
|
||||
};
|
||||
|
||||
template<typename T, typename... U> requires (std::is_same_v<T, U> and ...)
|
||||
Array(T, U...) -> Array<T, 1 + sizeof...(U)>;
|
||||
|
||||
template<typename T, size_t N, size_t... Indices>
|
||||
constexpr Array<T, N> make_array(const T (&data)[N], std::index_sequence<Indices...>)
|
||||
{
|
||||
|
@ -27,7 +27,7 @@ UnitTest test_ranges{[] {
|
||||
check_equal(R"(\\,\\,)"_sv | split<StringView>(',', '\\')
|
||||
| transform(unescape<',', '\\'>), Strs{R"(\)", R"(\)", ""});
|
||||
|
||||
check_equal(Array{{""_sv, "abc"_sv, ""_sv, "def"_sv, ""_sv}} | flatten(), "abcdef"_sv);
|
||||
check_equal(Array{""_sv, "abc"_sv, ""_sv, "def"_sv, ""_sv} | flatten(), "abcdef"_sv);
|
||||
check_equal(Vector<StringView>{"", ""} | flatten(), ""_sv);
|
||||
check_equal(Vector<StringView>{} | flatten(), ""_sv);
|
||||
}};
|
||||
|
Loading…
Reference in New Issue
Block a user