From dbd8cf214526ca29ff06cdcf85729f07404d8176 Mon Sep 17 00:00:00 2001 From: Johannes Altmanninger Date: Wed, 9 Feb 2022 12:43:36 +0100 Subject: [PATCH] Make Shift+Backspace erase a character in insert mode Terminals that support CSI u escape codes (like iTerm2, Kitty and foot) allow us to map independently of . Users expect that does the same as , especially when typing ALL_CAPS. Make it so. The first version of 0cf719103 (Make Shift+Space insert a space in insert mode, 2022-02-09) did that already but I later dropped it because I wasn't sure if it's right. --- src/input_handler.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/input_handler.cc b/src/input_handler.cc index 4f67678ef..ff09b1dfd 100644 --- a/src/input_handler.cc +++ b/src/input_handler.cc @@ -469,7 +469,7 @@ public: m_cursor_pos = 0; else if (key == Key::End or key == ctrl('e')) m_cursor_pos = m_line.char_length(); - else if (key == Key::Backspace or key == ctrl('h')) + else if (key == Key::Backspace or key == shift(Key::Backspace) or key == ctrl('h')) { if (m_cursor_pos != 0) { @@ -810,7 +810,7 @@ public: return; } else if (key == Key::Escape or key == ctrl('c') or - ((key == Key::Backspace or key == ctrl('h')) and line.empty())) + ((key == Key::Backspace or key == shift(Key::Backspace) or key == ctrl('h')) and line.empty())) { history_push(line); context().print_status(DisplayLine{}); @@ -1263,7 +1263,7 @@ public: m_completer.reset(); pop_mode(); } - else if (key == Key::Backspace) + else if (key == Key::Backspace or key == shift(Key::Backspace)) { Vector sels; for (auto& sel : context().selections())