Merge remote-tracking branch 'maximbaz/improve-comment-line'

rc/core/comment.kak

@@ -143,23 +143,38 @@ define-command comment-line -docstring '(un)comment selected lines using line co
             echo "fail \"The 'comment_line' option is empty, could not comment the line\""
         fi
     }
-    evaluate-commands -draft %{
+    evaluate-commands -save-regs '"/' -draft %{
         # Select the content of the lines, without indentation
         execute-keys <a-s>gi<a-l>
 
         try %{
             # Keep non-empty lines
             execute-keys <a-K>\A\s*\z<ret>
+        }
 
         try %{
-                # Select the comment characters and remove them
-                set-register / "\A\Q%opt{comment_line}\E\h*"
-                execute-keys s<ret>d
-            } catch %{
-                # Comment the line
+            set-register / "\A\Q%opt{comment_line}\E\h?"
+
+            try %{
+                # See if there are any uncommented lines in the selection
+                execute-keys -draft <a-K><ret>
+
+                # There are uncommented lines, so comment everything
                 set-register '"' "%opt{comment_line} "
+                align-selections-left
                 execute-keys P
+            } catch %{
+                # All lines were commented, so uncomment everything
+                execute-keys s<ret>d
             }
         }
     }
 }
+
+define-command align-selections-left -docstring 'extend selections to the left to align with the leftmost selected column' %{
+    evaluate-commands %sh{
+        leftmost_column=$(echo "$kak_selections_desc" | tr ' ' '\n' | cut -d',' -f1 | cut -d'.' -f2 | sort -n | head -n1)
+        aligned_selections=$(echo "$kak_selections_desc" | sed -E "s/\.[0-9]+,/.$leftmost_column,/g")
+        echo "select $aligned_selections"
+    }
+}

test/indent/comment/comment-multiple-lines-indented/cmd

@@ -0,0 +1 @@
+jXXXXX:comment-line<ret>

test/indent/comment/comment-multiple-lines-indented/in

@@ -0,0 +1,6 @@
+a:
+    b: 1
+    c:
+        d: 2
+
+    e: 3

test/indent/comment/comment-multiple-lines-indented/out

@@ -0,0 +1,6 @@
+a:
+    # b: 1
+    # c:
+    #     d: 2
+
+    # e: 3

test/indent/comment/comment-multiple-lines-indented/rc

@@ -0,0 +1,4 @@
+source "%val{runtime}/colors/default.kak"
+source "%val{runtime}/rc/base/yaml.kak"
+source "%val{runtime}/rc/core/comment.kak"
+set buffer filetype yaml

test/indent/comment/comment-multiple-lines-unindented/cmd

@@ -0,0 +1 @@
+%:comment-line<ret>

test/indent/comment/comment-multiple-lines-unindented/in

@@ -0,0 +1,6 @@
+a:
+    b: 1
+    c:
+        d: 2
+
+    e: 3

test/indent/comment/comment-multiple-lines-unindented/out

@@ -0,0 +1,6 @@
+# a:
+#     b: 1
+#     c:
+#         d: 2
+
+#     e: 3

test/indent/comment/comment-multiple-lines-unindented/rc

@@ -0,0 +1,4 @@
+source "%val{runtime}/colors/default.kak"
+source "%val{runtime}/rc/base/yaml.kak"
+source "%val{runtime}/rc/core/comment.kak"
+set buffer filetype yaml

test/indent/comment/comment-multiple-lines-when-partially-commented/cmd

@@ -0,0 +1 @@
+%:comment-line<ret>

test/indent/comment/comment-multiple-lines-when-partially-commented/in

@@ -0,0 +1,6 @@
+a:
+    # b: 1
+    c:
+        d: 2
+
+    e: 3

test/indent/comment/comment-multiple-lines-when-partially-commented/out

@@ -0,0 +1,6 @@
+# a:
+#     # b: 1
+#     c:
+#         d: 2
+
+#     e: 3

test/indent/comment/comment-multiple-lines-when-partially-commented/rc

@@ -0,0 +1,4 @@
+source "%val{runtime}/colors/default.kak"
+source "%val{runtime}/rc/base/yaml.kak"
+source "%val{runtime}/rc/core/comment.kak"
+set buffer filetype yaml

test/indent/comment/uncomment-multiple-indented-lines/cmd

@@ -0,0 +1 @@
+%:comment-line<ret>

test/indent/comment/uncomment-multiple-indented-lines/in

@@ -0,0 +1,3 @@
+# a:
+#     b: 1
+#     c: 2

test/indent/comment/uncomment-multiple-indented-lines/out

@@ -0,0 +1,3 @@
+a:
+    b: 1
+    c: 2

test/indent/comment/uncomment-multiple-indented-lines/rc

@@ -0,0 +1,4 @@
+source "%val{runtime}/colors/default.kak"
+source "%val{runtime}/rc/base/yaml.kak"
+source "%val{runtime}/rc/core/comment.kak"
+set buffer filetype yaml