Merge 1bd5637b56 into ba504431dc

doc/pages/highlighters.asciidoc

@@ -41,27 +41,22 @@ highlighter is replaced with the new one.
     using the `Whitespace` face, with the following *options*:
 
     *-lf* <separator>:::
-        a one character long separator that will replace line feeds,
-        or an empty string to ignore them.
+        a one character long separator that will replace line feeds
 
     *-spc* <separator>:::
-        a one character long separator that will replace spaces,
-        or an empty string to ignore them.
+        a one character long separator that will replace spaces
 
     *-nbsp* <separator>:::
-        a one character long separator that will replace non-breakable spaces,
-        or an empty string to ignore them.
+        a one character long separator that will replace non-breakable spaces
 
     *-tab* <separator>:::
-        a one character long separator that will replace tabulations,
-        or an empty string to ignore them.
+        a one character long separator that will replace tabulations
 
     *-tabpad* <separator>:::
         a one character long separator that will be appended to tabulations to honor the *tabstop* option
 
     *-indent* <separator>:::
-        a one character long separator that will replace the first space in indentation 
-        according to the *indentwidth* option, or an empty string to ignore them.
+        a one character long separator that will replace the first space in indentation according to the *indentwidth* option
         This will use the `WhitespaceIndent` face.
 
     *-only-trailing*:::

doc/pages/hooks.asciidoc

@@ -147,11 +147,6 @@ name. Hooks with no description will always use an empty string.
 *SessionRenamed* `<old name>:<new name>`::
     executed when a session is renamed using the `rename-session` command
 
-*EnterDirectory* `path`::
-    executed on startup and when the current working directory is changed
-    using the `change-directory` command. The hook param is an absolute path
-    to the new working directory.
-
 *RuntimeError* `error message`::
     an error was encountered while executing a user command
 

rc/filetype/elixir.kak

@@ -8,7 +8,7 @@ hook global BufCreate .*[.](ex|exs) %{
     set-option buffer filetype elixir
 }
 
-hook global BufCreate .*[.]html[.][lh]?eex %{
+hook global BufCreate .*[.]html[.]l?eex %{
     set-option buffer filetype eex
 }
 
@@ -64,7 +64,6 @@ add-highlighter shared/elixir/single_string region "'" "(?<!\\)(?:\\\\)*'" fill
 add-highlighter shared/elixir/comment region '#' '$' fill comment
 
 add-highlighter shared/elixir/leex region -match-capture '~L("""|")' '(?<!\\)(?:\\\\)*("""|")' ref eex
-add-highlighter shared/elixir/heex region -match-capture '~H("""|")' '(?<!\\)(?:\\\\)*("""|")' ref eex
 
 add-highlighter shared/elixir/double_string/base default-region fill string
 add-highlighter shared/elixir/double_string/interpolation region -recurse \{ \Q#{ \} fill builtin

rc/tools/comment.kak

@@ -75,7 +75,7 @@ hook global BufSetOption filetype=(html|xml) %{
     set-option buffer comment_block_end '-->'
 }
 
-hook global BufSetOption filetype=(erlang|latex|mercury) %{
+hook global BufSetOption filetype=(latex|mercury) %{
     set-option buffer comment_line '%'
 }
 

rc/tools/fifo.kak

@@ -1,14 +1,12 @@
 provide-module fifo %{
 
 define-command -params .. -docstring %{
-    fifo [-name <name>] [-scroll] [-script <script>] [--] <args>...: run command in a fifo buffer
-    if <script> is used, eval it with <args> as '$@', else pass arguments directly to the shell
+    fifo [-name <buffer-name>] [-scroll] [--] <command>...: run command in a fifo buffer
 } fifo %{ evaluate-commands %sh{
     name='*fifo*'
     while true; do
         case "$1" in
             "-scroll") scroll="-scroll"; shift ;;
-            "-script") script="$2"; shift 2 ;;
             "-name") name="$2"; shift 2 ;;
             "--") shift; break ;;
             *) break ;;
@@ -16,11 +14,7 @@ define-command -params .. -docstring %{
     done
     output=$(mktemp -d "${TMPDIR:-/tmp}"/kak-fifo.XXXXXXXX)/fifo
     mkfifo ${output}
-    if [ -n "$script" ]; then
-        ( eval "$script" > ${output} 2>&1 & ) > /dev/null 2>&1 < /dev/null
-    else
-        ( "$@" > ${output} 2>&1 & ) > /dev/null 2>&1 < /dev/null
-    fi
+    ( eval "$@" > ${output} 2>&1 & ) > /dev/null 2>&1 < /dev/null
 
     printf %s\\n "
             edit! -fifo ${output} ${scroll} ${name}

rc/tools/grep.kak

@@ -12,7 +12,8 @@ define-command -params .. -docstring %{
     Passing no argument will perform a literal-string grep for the current selection
 } grep %{
     evaluate-commands -try-client %opt{toolsclient} %{
-        fifo -name *grep* -script %{
+        fifo -name *grep* %{
+            shift 2
             trap - INT QUIT
             if [ $# -eq 0 ]; then
                 case "$kak_opt_grepcmd" in
@@ -28,7 +29,7 @@ define-command -params .. -docstring %{
                 esac
             fi
             $kak_opt_grepcmd "$@" 2>&1 | tr -d '\r'
-        } -- %arg{@}
+        } 'exit;' %arg{@} # pass arguments for "$@" above, exit to avoid evaluating them
         set-option buffer filetype grep
         set-option buffer jump_current_line 0
     }

rc/tools/make.kak

@@ -13,10 +13,11 @@ define-command -params .. -docstring %{
     All the optional arguments are forwarded to the make utility
 } make %{
     evaluate-commands -try-client %opt{toolsclient} %{
-        fifo -scroll -name *make* -script %{
+        fifo -scroll -name *make* %{
+            shift 2
             trap - INT QUIT
             $kak_opt_makecmd "$@"
-        } -- %arg{@}
+        } 'exit;' %arg{@} # pass arguments for "$@" above, exit to avoid evaluating them
         set-option buffer filetype make
         set-option buffer jump_current_line 0
     }

src/commands.cc

@@ -2600,15 +2600,13 @@ const CommandDesc change_directory_cmd = {
                                         cursor_pos, FilenameFlags::OnlyDirectories),
                       Completions::Flags::Menu };
         }),
-    [](const ParametersParser& parser, Context& ctx, const ShellContext&)
+    [](const ParametersParser& parser, Context&, const ShellContext&)
     {
         StringView target = parser.positional_count() == 1 ? StringView{parser[0]} : "~";
-        auto path = real_path(parse_filename(target));
-        if (chdir(path.c_str()) != 0)
+        if (chdir(parse_filename(target).c_str()) != 0)
             throw runtime_error(format("unable to change to directory: '{}'", target));
         for (auto& buffer : BufferManager::instance())
             buffer->update_display_name();
-        ctx.hooks().run_hook(Hook::EnterDirectory, path, ctx);
     }
 };
 

src/context.cc

@@ -424,7 +424,7 @@ StringView Context::main_sel_register_value(StringView reg) const
     return RegisterManager::instance()[reg].get_main(*this, index);
 }
 
-void Context::set_name(String name) {
+void Context::set_name(String name) { 
     String old_name = std::exchange(m_name, std::move(name));
     hooks().run_hook(Hook::ClientRenamed, format("{}:{}", old_name, m_name), *this);
 }

src/hash_map.hh

@@ -239,7 +239,7 @@ struct HashMap
     constexpr bool contains(const KeyType& key) const { return find_index(key) >= 0; }
 
     template<typename KeyType> requires IsHashCompatible<Key, std::remove_cvref_t<KeyType>>
-    constexpr EffectiveValue& operator[](KeyType&& key)
+    constexpr EffectiveValue& operator[](KeyType&& key) 
     {
         const auto hash = hash_value(key);
         auto index = find_index(key, hash);

src/highlighters.cc

@@ -981,14 +981,18 @@ struct ShowWhitespacesHighlighter : Highlighter
         bool only_trailing = (bool) parser.get_switch("only-trailing");
         auto get_param = [&](StringView param,  StringView fallback) {
             StringView value = parser.get_switch(param).value_or(fallback);
-            if (value.char_length() > 1)
-                throw runtime_error{format("-{} expects a single character or empty parameter", param)};
+            if (value.char_length() != 1)
+                throw runtime_error{format("-{} expects a single character parameter", param)};
             return value.str();
         };
 
+        String indent = parser.get_switch("indent").value_or("│").str();
+        if (indent.char_length() > 1)
+            throw runtime_error{format("-indent expects a single character or empty parameter")};
+
         return std::make_unique<ShowWhitespacesHighlighter>(
             get_param("tab", "→"), get_param("tabpad", " "), get_param("spc", "·"),
-            get_param("lf", "¬"), get_param("nbsp", "⍽"), get_param("indent", "│"), only_trailing);
+            get_param("lf", "¬"), get_param("nbsp", "⍽"), indent, only_trailing);
     }
 
 private:
@@ -1039,28 +1043,28 @@ private:
                         if (it != end)
                             atom_it = line.split(atom_it, it.coord());
 
-                        if (cp == '\t' and not m_tab.empty() and not m_tabpad.empty())
+                        if (cp == '\t')
                         {
                             const ColumnCount column = get_column(buffer, tabstop, coord);
                             const ColumnCount count = tabstop - (column % tabstop);
                             atom_it->replace(m_tab + String(m_tabpad[(CharCount)0], count - m_tab.column_length()));
                         }
-                        else if (cp == ' ' and is_indentation and indentwidth > 0 and not m_indent.empty()) {
-                            const ColumnCount column = get_column(buffer, tabstop, coord);
-                            if (column % indentwidth == 0 and column != 0) {
-                                atom_it->replace(m_indent);
-                                face = indentface;
-                            }
-                            else {
+                        else if (cp == ' ') {
+                            if (m_indent.empty() or indentwidth == 0 or not is_indentation) {
                                 atom_it->replace(m_spc);
+                            } else {
+                                const ColumnCount column = get_column(buffer, tabstop, coord);
+                                if (column % indentwidth == 0 and column != 0) {
+                                    atom_it->replace(m_indent);
+                                    face = indentface;
+                                } else  {
+                                    atom_it->replace(m_spc);
+                                }
                             }
                         }
-                        else if (cp == ' ' and not m_spc.empty()) {
-                            atom_it->replace(m_spc);
-                        }
-                        else if (cp == '\n' and not m_lf.empty())
+                        else if (cp == '\n')
                             atom_it->replace(m_lf);
-                        else if ((cp == 0xA0 or cp == 0x202F) and not m_nbsp.empty())
+                        else if (cp == 0xA0 or cp == 0x202F)
                             atom_it->replace(m_nbsp);
                         atom_it->face = merge_faces(atom_it->face, face);
                         break;

src/hook_manager.hh

@@ -50,7 +50,6 @@ enum class Hook
     NextKeyIdle,
     NormalKey,
     ModeChange,
-    EnterDirectory,
     RawKey,
     RegisterModified,
     WinClose,
@@ -98,7 +97,6 @@ constexpr auto enum_desc(Meta::Type<Hook>)
         {Hook::NextKeyIdle, "NextKeyIdle"},
         {Hook::NormalKey, "NormalKey"},
         {Hook::ModeChange, "ModeChange"},
-        {Hook::EnterDirectory, "EnterDirectory"},
         {Hook::RawKey, "RawKey"},
         {Hook::RegisterModified, "RegisterModified"},
         {Hook::WinClose, "WinClose"},

src/main.cc

@@ -842,7 +842,6 @@ int run_server(StringView session, StringView server_init,
 
     {
         Context empty_context{Context::EmptyContextFlag{}};
-        global_scope.hooks().run_hook(Hook::EnterDirectory, real_path("."), empty_context);
         global_scope.hooks().run_hook(Hook::KakBegin, session, empty_context);
     }
 

src/normal.cc

@@ -589,13 +589,13 @@ void pipe(Context& context, NormalParams params)
                 return;
 
             Buffer& buffer = context.buffer();
+            SelectionList selections = context.selections();
             if (replace)
             {
-                buffer.throw_if_read_only();
                 ScopedEdition edition(context);
                 ForwardChangesTracker changes_tracker;
                 size_t timestamp = buffer.timestamp();
-                SelectionList selections = context.selections();
+                Vector<Selection> new_sels;
                 for (auto& sel : selections)
                 {
                     const auto beg = changes_tracker.get_new_coord_tolerant(sel.min());
@@ -614,27 +614,20 @@ void pipe(Context& context, NormalParams params)
 
                     auto new_end = apply_diff(buffer, beg, in, out);
                     if (new_end != beg)
-                    {
-                        auto& min = sel.min();
-                        auto& max = sel.max();
-                        min = beg;
-                        max = buffer.char_prev(new_end);
-                    }
+                        new_sels.push_back(keep_direction({beg, buffer.char_prev(new_end), std::move(sel.captures())}, sel));
                     else
                     {
                         if (new_end != BufferCoord{})
                             new_end = buffer.char_prev(new_end);
-                        sel.set(new_end);
+                        new_sels.push_back({new_end, new_end, std::move(sel.captures())});
                     }
 
                     changes_tracker.update(buffer, timestamp);
                 }
-                selections.force_timestamp(timestamp);
-                context.selections_write_only() = std::move(selections);
+                context.selections_write_only().set(std::move(new_sels), selections.main_index());
             }
             else
             {
-                SelectionList& selections = context.selections();
                 const auto old_main = selections.main_index();
                 for (int i = 0; i < selections.size(); ++i)
                 {

src/regex_impl.cc

@@ -753,10 +753,7 @@ private:
                 {
                     auto node = compile_node<direction>(child);
                     if (child != index+1)
-                    {
-                        --split_pos;
-                        m_program.instructions[split_pos].param.split = {.offset = offset(node, split_pos), .prioritize_parent = true};
-                    }
+                        m_program.instructions[--split_pos].param.split = CompiledRegex::Param::Split{.offset = offset(node, split_pos), .prioritize_parent = true};
                     if (get_node(child).children_end != end)
                     {
                         auto jump = push_inst(CompiledRegex::Jump);

src/register_manager.cc

@@ -40,7 +40,7 @@ void HistoryRegister::set(Context& context, ConstArrayView<String> values, bool
         return;
     }
 
-    for (auto&& entry : values | reverse())
+    for (auto&& entry : values | reverse()) 
     {
         m_content.erase(std::remove(m_content.begin(), m_content.end(), entry), m_content.end());
         m_content.insert(m_content.begin(), entry);

src/string.cc

@@ -6,7 +6,7 @@
 
 namespace Kakoune
 {
-namespace
+namespace 
 {
 // Avoid including all of <algorithm> just for this.
 constexpr auto max(auto lhs, auto rhs) { return lhs > rhs ? lhs : rhs;}
@@ -69,7 +69,7 @@ void String::Data::reserve(size_t new_capacity)
     if (current_capacity != 0 and new_capacity <= current_capacity)
         return;
 
-    if (!is_long() and new_capacity <= Short::capacity)
+    if (!is_long() and new_capacity <= Short::capacity) 
         return;
 
     kak_assert(new_capacity <= Long::max_capacity);

src/string.hh

@@ -169,9 +169,9 @@ public:
         using Alloc = Allocator<char, MemoryDomain::String>;
 
         Data() { set_empty(); }
-        Data(NoCopy, const char* data, size_t size) : u{Long{const_cast<char*>(data),
+        Data(NoCopy, const char* data, size_t size) : u{Long{const_cast<char*>(data), 
                                                              size,
-                                                             /*capacity=*/0,
+                                                             /*capacity=*/0, 
                                                              /*mode=*/Long::active_mask}} {}
 
         Data(const char* data, size_t size, size_t capacity);

src/string_utils.cc

@@ -202,7 +202,7 @@ InplaceString<23> to_string(Grouped val)
     InplaceString<23> res;
     for (int pos = 0, len = ungrouped.m_length; pos != len; ++pos)
     {
-        if (res.m_length and ((len - pos) % 3) == 0)
+        if (res.m_length and ((len - pos) % 3) == 0) 
             res.m_data[res.m_length++] = ',';
         res.m_data[res.m_length++] = ungrouped.m_data[pos];
     }

src/string_utils.hh

@@ -144,10 +144,10 @@ decltype(auto) to_string(const StronglyTypedNumber<RealType, ValueType>& val)
 namespace detail
 {
 
-template<typename T> requires std::is_convertible_v<T, StringView>
+template<typename T> requires std::is_convertible_v<T, StringView> 
 StringView format_param(const T& val) { return val; }
 
-template<typename T> requires (not std::is_convertible_v<T, StringView>)
+template<typename T> requires (not std::is_convertible_v<T, StringView>) 
 decltype(auto) format_param(const T& val) { return to_string(val); }
 
 }

src/terminal_ui.cc

@@ -377,7 +377,7 @@ void TerminalUI::Screen::output(bool force, bool synchronized, Writer& writer)
     {
         for (int line = 0; line < (int)size.line; ++line)
         {
-            auto hash = hash_line(lines[line]);
+            auto hash = hash_line(lines[line]); 
             if (hash == hashes[line])
                 continue;
             hashes[line] = hash;