fix(dashboard): allow arbitrary version numbers like nightlyl

Previously the app would crash if the version was not a strictly valid semver string.
Now arbitrary names can be used and it will always be considered not latest
This commit is contained in:
Nicolas Meienberger 2024-02-09 20:40:02 +01:00 committed by Nicolas Meienberger
parent 694e5147c2
commit 4047f2bbed
4 changed files with 7 additions and 7 deletions

View File

@ -77,7 +77,7 @@ services:
- .env
environment:
NODE_ENV: development
TIPI_VERSION: 0.0.0
TIPI_VERSION: development
volumes:
# Dev mode
- ./packages/worker/src:/app/packages/worker/src
@ -140,7 +140,7 @@ services:
- .env
environment:
NODE_ENV: development
TIPI_VERSION: 0.0.0
TIPI_VERSION: development
NEXT_PUBLIC_TIPI_VERSION: 0.0.0
networks:
- tipi_main_network

View File

@ -63,7 +63,7 @@ services:
dockerfile: ./packages/worker/Dockerfile
args:
- SENTRY_DISABLE_AUTO_UPLOAD=true
- TIPI_VERSION=0.0.0
- TIPI_VERSION=development
container_name: tipi-worker
deploy:
resources:
@ -85,7 +85,7 @@ services:
- .env
environment:
NODE_ENV: production
TIPI_VERSION: 0.0.0
TIPI_VERSION: development
volumes:
- /proc:/host/proc
- ./.env:/app/.env

View File

@ -31,7 +31,8 @@ export default async function DashboardLayout({ children }: { children: React.Re
const systemService = new SystemServiceClass();
const { latest, current } = await systemService.getVersion();
const isLatest = semver.gte(current, latest || '0.0.0');
const isLatest = semver.valid(current) && semver.valid(latest) && semver.gte(current, latest);
return (
<div className="page">

View File

@ -13,8 +13,7 @@ export const GeneralActions = (props: Props) => {
const t = useTranslations();
const { version } = props;
const defaultVersion = '0.0.0';
const isLatest = semver.gte(version.current || defaultVersion, version.latest || defaultVersion);
const isLatest = semver.valid(version.current) && semver.valid(version.latest) && semver.gte(version.current, version.latest);
const renderUpdate = () => {
if (isLatest) {