2020-04-28 20:37:23 +03:00
|
|
|
{
|
2020-07-02 01:22:29 +03:00
|
|
|
"comment": "Do not edit this file, use utils/roll_browser.js",
|
2020-04-28 20:37:23 +03:00
|
|
|
"browsers": [
|
|
|
|
|
{
|
|
|
|
|
"name": "chromium",
|
2021-09-03 15:47:43 +03:00
|
|
|
"revision": "917400",
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 21:43:29 +03:00
|
|
|
"installByDefault": true
|
2020-04-28 20:37:23 +03:00
|
|
|
},
|
2021-06-16 03:57:31 +03:00
|
|
|
{
|
|
|
|
|
"name": "chromium-with-symbols",
|
2021-09-03 15:47:43 +03:00
|
|
|
"revision": "917400",
|
2021-06-16 03:57:31 +03:00
|
|
|
"installByDefault": false
|
|
|
|
|
},
|
2020-04-28 20:37:23 +03:00
|
|
|
{
|
|
|
|
|
"name": "firefox",
|
2021-09-01 19:16:36 +03:00
|
|
|
"revision": "1290",
|
2021-06-08 01:55:01 +03:00
|
|
|
"installByDefault": true
|
2020-04-28 20:37:23 +03:00
|
|
|
},
|
2021-04-20 07:26:33 +03:00
|
|
|
{
|
2021-06-08 19:34:17 +03:00
|
|
|
"name": "firefox-beta",
|
2021-09-01 19:16:11 +03:00
|
|
|
"revision": "1287",
|
2021-06-08 01:55:01 +03:00
|
|
|
"installByDefault": false
|
2021-04-20 07:26:33 +03:00
|
|
|
},
|
2020-04-28 20:37:23 +03:00
|
|
|
{
|
|
|
|
|
"name": "webkit",
|
2021-09-03 12:07:06 +03:00
|
|
|
"revision": "1540",
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 21:43:29 +03:00
|
|
|
"installByDefault": true,
|
2021-03-17 19:34:09 +03:00
|
|
|
"revisionOverrides": {
|
2021-06-08 02:29:37 +03:00
|
|
|
"mac10.14": "1446"
|
2021-03-17 19:34:09 +03:00
|
|
|
}
|
2021-02-03 20:19:11 +03:00
|
|
|
},
|
|
|
|
|
{
|
|
|
|
|
"name": "ffmpeg",
|
2021-02-04 08:15:09 +03:00
|
|
|
"revision": "1005",
|
fix(installer): retain browsers installed via Playwrigth CLI (#5904)
Browser registry is responsible for 3 things:
1. Remove downloaded browsers if there are no packages that refer to them
2. Install default browsers needed for the current package
3. Install browsers on-demand when used through Playwright CLI
Currently, registry relies on a single "download" field in `browsers.json`
to carry both (1) and (2). However, browsers in (3) are marked as
`download: false` so that they aren't installed automatically in (2), so
auto-remove procedure in (1) removes them on subsequent installation.
One possible approach to fix this would be modifying package's `browsers.json` to
change `download: false` to `true` when browsers are installed with
Playwright CLI. This approach was explored here:
https://github.com/microsoft/playwright/commit/bc04a51800d6d6322e43b7d147fc0ec42181e084
We decided against this since we have a history of issues related to
package modifications after NPM installation. This breaks all
sorts of yarn/npm caching mechanisms.
Instead, this patch is a two-step refactor:
- remove the "download" field in `browsers.json`. Now, all registries
(including old ones from previously-released versions) will retain any
browsers that are mentioned in the `browsers.json`.
- add a new flag "installByDefault", that is **only used** for default
installation.
With this change, the registry tasks are done like this:
- (1) auto-removal: if browser has a back reference, it is retained,
otherwise it is removed from registry
- (2) default installation: use only `installByDefault` to carry default installations
- (3) CLI installation: simply installs browsers. Since we retain
everythings that's referenced in (1), browsers aren't removed.
Fixes #5902
2021-03-22 21:43:29 +03:00
|
|
|
"installByDefault": true
|
2020-04-28 20:37:23 +03:00
|
|
|
}
|
|
|
|
|
]
|
|
|
|
|
}
|
